René's URL Explorer Experiment


Title: socketmodule: support FreeBSD divert(4) socket · Issue #96534 · python/cpython · GitHub

Open Graph Title: socketmodule: support FreeBSD divert(4) socket · Issue #96534 · python/cpython

X Title: socketmodule: support FreeBSD divert(4) socket · Issue #96534 · python/cpython

Description: FreeBSD has divert(4) socket since previous century. Until recently it was in the namespace of PF_INET: s = socket(PF_INET, SOCK_RAW, IPPROTO_DIVERT) This had no problems with Python's socketmodule, we just put a numeric constant in plac...

Open Graph Description: FreeBSD has divert(4) socket since previous century. Until recently it was in the namespace of PF_INET: s = socket(PF_INET, SOCK_RAW, IPPROTO_DIVERT) This had no problems with Python's socketmodule...

X Description: FreeBSD has divert(4) socket since previous century. Until recently it was in the namespace of PF_INET: s = socket(PF_INET, SOCK_RAW, IPPROTO_DIVERT) This had no problems with Python's socketmo...

Opengraph URL: https://github.com/python/cpython/issues/96534

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"socketmodule: support FreeBSD divert(4) socket","articleBody":"FreeBSD has divert(4) socket since previous century. Until recently it was in the namespace of PF_INET:\r\n\r\n`s = socket(PF_INET, SOCK_RAW, IPPROTO_DIVERT)`\r\n\r\nThis had no problems with Python's socketmodule, we just put a numeric constant in place of IPPROTO_DIVERT. And since bind(2) argument for divert(4) socket is struct sockaddr_in, luckily everything just worked.\r\n\r\nRecently I [moved the divert(4) out of PF_INET namespace](https://cgit.freebsd.org/src/commit/sys/netinet/ip_divert.c?id=8624f4347e8133911b0554e816f6bedb56dc5fb3), and now it should be created as:\r\n\r\n`s = socket(PF_DIVERT, SOCK_RAW, 0)`\r\n\r\nUnfortunately Python's socketmodule can't support this, cause to perform socket.bind() it doesn't know how to construct sockaddr. Attempt to socket.bind() just bails out due to internal socket module error, not even coming to syscall:\r\n```\r\n    s.bind(('0.0.0.0', port))\r\nOSError: bind(): bad family\r\n```\r\nThis functionality is important for FreeBSD, cause [we use python in our internal regression testing suite](https://cgit.freebsd.org/src/plain/tests/sys/common/divert.py).\r\n\r\nSo, better late than never, let socketmodule recognize and support FreeBSD divert(4) socket. Making pull request in a few minutes.\n\n\u003c!-- gh-pr-number: gh-96536 --\u003e\n* PR: gh-96536\n\u003c!-- /gh-pr-number --\u003e\n","author":{"url":"https://github.com/glebius","@type":"Person","name":"glebius"},"datePublished":"2022-09-03T15:45:44.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/96534/cpython/issues/96534"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:35e45234-afdd-1c2a-a93b-fa83f1b284f5
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB900:24B668:16D5B40:1E990E0:6969A9D4
html-safe-nonce85b8eac3411ad72155eee1387c5631974e29590e8c90521fe4515f2f4ad123a5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTAwOjI0QjY2ODoxNkQ1QjQwOjFFOTkwRTA6Njk2OUE5RDQiLCJ2aXNpdG9yX2lkIjoiMzkwMDYwMjE2MzY5OTIzMTE4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac366fad8e258546797569b21b843581952da1b0a02a7b4c5097c9e2b28c781f9b
hovercard-subject-tagissue:1360893005
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/96534/issue_layout
twitter:imagehttps://opengraph.githubassets.com/62bb97235e865ab0843809053553c6092e481f5d017fd62a728eeceea6dc3ebb/python/cpython/issues/96534
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/62bb97235e865ab0843809053553c6092e481f5d017fd62a728eeceea6dc3ebb/python/cpython/issues/96534
og:image:altFreeBSD has divert(4) socket since previous century. Until recently it was in the namespace of PF_INET: s = socket(PF_INET, SOCK_RAW, IPPROTO_DIVERT) This had no problems with Python's socketmodule...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameglebius
hostnamegithub.com
expected-hostnamegithub.com
None24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release124667f43168afb6c9c03b7c02eb5b1d2e1be3d9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/96534#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F96534
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F96534
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/96534
Reloadhttps://github.com/python/cpython/issues/96534
Reloadhttps://github.com/python/cpython/issues/96534
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/96534
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/96534
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/96534
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/96534
socketmodule: support FreeBSD divert(4) sockethttps://github.com/python/cpython/issues/96534#top
extension-modulesC modules in the Modules dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22extension-modules%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/glebius
https://github.com/glebius
glebiushttps://github.com/glebius
on Sep 3, 2022https://github.com/python/cpython/issues/96534#issue-1360893005
moved the divert(4) out of PF_INET namespacehttps://cgit.freebsd.org/src/commit/sys/netinet/ip_divert.c?id=8624f4347e8133911b0554e816f6bedb56dc5fb3
we use python in our internal regression testing suitehttps://cgit.freebsd.org/src/plain/tests/sys/common/divert.py
gh-96534: socketmodule: support FreeBSD divert(4) socket #96536https://github.com/python/cpython/pull/96536
extension-modulesC modules in the Modules dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22extension-modules%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.