René's URL Explorer Experiment


Title: Inconsistent `ast.parse` result for `python<3.9` and PEP614 · Issue #96427 · python/cpython · GitHub

Open Graph Title: Inconsistent `ast.parse` result for `python<3.9` and PEP614 · Issue #96427 · python/cpython

X Title: Inconsistent `ast.parse` result for `python<3.9` and PEP614 · Issue #96427 · python/cpython

Description: PEP614 introduces relaxed decorator grammar in 3.9: https://peps.python.org/pep-0614/ Right now, ast.parse with feature_version=(3, 8) and bellow behave differently from specified python versions themself. For example, main branch is abl...

Open Graph Description: PEP614 introduces relaxed decorator grammar in 3.9: https://peps.python.org/pep-0614/ Right now, ast.parse with feature_version=(3, 8) and bellow behave differently from specified python versions t...

X Description: PEP614 introduces relaxed decorator grammar in 3.9: https://peps.python.org/pep-0614/ Right now, ast.parse with feature_version=(3, 8) and bellow behave differently from specified python versions t...

Opengraph URL: https://github.com/python/cpython/issues/96427

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Inconsistent `ast.parse` result for `python\u003c3.9` and PEP614","articleBody":"PEP614 introduces relaxed decorator grammar in 3.9: https://peps.python.org/pep-0614/\r\n\r\nRight now, `ast.parse` with `feature_version=(3, 8)` and bellow behave differently from specified python versions themself.\r\n\r\nFor example, `main` branch is able to parse this code:\r\n\r\n```python\r\nPython 3.12.0a0 (heads/main-dirty:e860e521ec, Aug 28 2022, 21:36:18) [Clang 11.0.0 (clang-1100.0.33.16)] on darwin\r\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\r\n>>> import ast\r\n>>> code = \"\"\"\r\n... @decs[0].func\r\n... def some(): pass\r\n... \"\"\"\r\n>>> ast.parse(code)\r\n\u003cast.Module object at 0x102db8150>\r\n>>> ast.parse(code, feature_version=(3, 8))\r\n\u003cast.Module object at 0x102d9d320>\r\n```\r\n\r\nWhile `python==3.8.x` is not able to:\r\n\r\n```python\r\nPython 3.8.9 (default, May  3 2021, 12:15:25) \r\n[Clang 11.0.0 (clang-1100.0.33.16)] on darwin\r\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\r\n>>> import ast\r\n>>> code = \"\"\"\r\n... @decs[0].func\r\n... def some(): pass\r\n... \"\"\"\r\n>>> ast.parse(code)\r\nTraceback (most recent call last):\r\n  File \"\u003cstdin>\", line 1, in \u003cmodule>\r\n  File \"/Users/sobolev/.pyenv/versions/3.8.9/lib/python3.8/ast.py\", line 47, in parse\r\n    return compile(source, filename, mode, flags,\r\n  File \"\u003cunknown>\", line 2\r\n    @decs[0].func\r\n         ^\r\nSyntaxError: invalid syntax\r\n```\r\n\r\nWhen looking at `we-love-parsers/pegen` - it does have a version check for this: https://github.com/we-like-parsers/pegen/blame/599255a5ba3930e86367cd3fc78fae91ee184dd5/data/python.gram#L660-L662\r\n\r\n## Pros and Cons\r\n\r\nI think that there are several key points to this, pros:\r\n1. Correct parsing of older versions\r\n2. Consistency with other parser like `we-love-parsers/pegen`\r\n\r\nHowever, there are some serious cons to it:\r\n1. Grammar is made quite significanly more complex\r\n2. There might be new bugs in new behaviour: locations / performance / etc\r\n\r\nI think it is up to @pablogsal and other core devs to decide.\r\n\r\n## Proposed solution\r\n\r\nI've modified an existing `we-love-parsers/pegen`'s solution a bit, here's what it looks like:\r\n\r\n```\r\ndecorators[asdl_expr_seq*]: a[asdl_expr_seq*]=decorator+\r\ndecorator[expr_ty]:\r\n    | a=('@' f=dec_maybe_call NEWLINE { f }) { a }\r\n    | a=('@' f=named_expression NEWLINE { f }) {\r\n        CHECK_VERSION(expr_ty, 9, \"Relaxed decorator syntax is\", a) }\r\ndec_maybe_call[expr_ty]:\r\n    | a=dec_primary '(' b=[arguments] ')' {\r\n        _PyAST_Call(a,\r\n                    (b) ? ((expr_ty) b)->v.Call.args : NULL,\r\n                    (b) ? ((expr_ty) b)->v.Call.keywords : NULL,\r\n                    EXTRA) }\r\n    | dec_primary\r\ndec_primary[expr_ty]:\r\n    | a=dec_primary '.' b=NAME { _PyAST_Attribute(a, b->v.Name.id, Load, EXTRA) }\r\n    | a=NAME\r\n```\r\n\r\nI will send a PR with all the changes / tests / auto-generated files, so we can take a closer look and decide whether we want this or not.","author":{"url":"https://github.com/sobolevn","@type":"Person","name":"sobolevn"},"datePublished":"2022-08-30T13:49:10Z","url":"https://github.com/python/cpython/issues/96427"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:81ee9067-fb2d-50c5-971d-14eef5405df2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC760:11BB24:2B41419:3AFCDE3:6B005198
html-safe-nonce864e776616a74d90d7832abd0c902bb52cd34f97e2bf39f40ac2c35f85c97a61
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzYwOjExQkIyNDoyQjQxNDE5OjNBRkNERTM6NkIwMDUxOTgiLCJ2aXNpdG9yX2lkIjoiNTc3MDAzMjkxMDMzNzg1NTg5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac28c987e12159521797c0c7e64798293701c646224cedfd4b9bf491958a1f66a9
hovercard-subject-tagissue:1355804760
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/96427/issue_layout
twitter:imagehttps://opengraph.githubassets.com/5809f689a1a6861a90c9ada6c8bf53a79fc566b130b48777ae41a8e6088d7729/python/cpython/issues/96427
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5809f689a1a6861a90c9ada6c8bf53a79fc566b130b48777ae41a8e6088d7729/python/cpython/issues/96427
og:image:altPEP614 introduces relaxed decorator grammar in 3.9: https://peps.python.org/pep-0614/ Right now, ast.parse with feature_version=(3, 8) and bellow behave differently from specified python versions t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesobolevn
hostnamegithub.com
expected-hostnamegithub.com
Nonef420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26e00df917aba0f128135dc073ea0c5e33a70d40
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/96427#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F96427
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F96427
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/96427
Reloadhttps://github.com/python/cpython/issues/96427
Reloadhttps://github.com/python/cpython/issues/96427
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/96427
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/96427
Inconsistent ast.parse result for python<3.9 and PEP614https://github.com/python/cpython/issues/96427#top
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Aug 30, 2022https://github.com/python/cpython/issues/96427#issue-1355804760
https://peps.python.org/pep-0614/https://peps.python.org/pep-0614/
https://github.com/we-like-parsers/pegen/blame/599255a5ba3930e86367cd3fc78fae91ee184dd5/data/python.gram#L660-L662https://github.com/we-like-parsers/pegen/blame/599255a5ba3930e86367cd3fc78fae91ee184dd5/data/python.gram#L660-L662
@pablogsalhttps://github.com/pablogsal
sobolevnhttps://github.com/sobolevn
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
on Aug 30, 2022https://github.com/python/cpython/issues/96427#event-7287803107
sobolevnhttps://github.com/sobolevn
on Aug 30, 2022https://github.com/python/cpython/issues/96427#event-7287834217
pythongh-96427: Raise `SyntaxError` for `PEP614` on older python vers…https://github.com/sobolevn/cpython/commit/2e6ca88144cf305cce41a2e07908d23ed715cf68
pythongh-96427https://github.com/python/cpython/issues/96427
2e6ca88https://github.com/sobolevn/cpython/commit/2e6ca88144cf305cce41a2e07908d23ed715cf68
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
on Aug 30, 2022https://github.com/python/cpython/issues/96427#issuecomment-1231825648
@isidenticalhttps://github.com/isidentical
@lysnikolaouhttps://github.com/lysnikolaou
@sobolevnhttps://github.com/sobolevn
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Aug 30, 2022https://github.com/python/cpython/issues/96427#issuecomment-1231830873
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
on Aug 30, 2022https://github.com/python/cpython/issues/96427#issuecomment-1231918138
@pablogsalhttps://github.com/pablogsal
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Aug 30, 2022https://github.com/python/cpython/issues/96427#issuecomment-1231927032
pablogsalhttps://github.com/pablogsal
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Aug 30, 2022https://github.com/python/cpython/issues/96427#event-7289552553
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Aug 30, 2022https://github.com/python/cpython/issues/96427#issuecomment-1231977153
https://github.com/python/mypy/blob/master/mypy/fastparse.py#L275-L303https://github.com/python/mypy/blob/master/mypy/fastparse.py#L275-L303
https://github.com/psf/black/blob/44d5da00b520a05cd56e58b3998660f64ea59ebd/src/black/parsing.py#L149-L169https://github.com/psf/black/blob/44d5da00b520a05cd56e58b3998660f64ea59ebd/src/black/parsing.py#L149-L169
https://cs.github.com/?q=feature_version%3D%20language%3APython&scopeName=All%20repos&scope=#https://cs.github.com/?q=feature_version%3D%20language%3APython&scopeName=All%20repos&scope=
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/96427
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/96427
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.