René's URL Explorer Experiment


Title: `BUILTINS` is not a valid field name for a frozen dataclass · Issue #96151 · python/cpython · GitHub

Open Graph Title: `BUILTINS` is not a valid field name for a frozen dataclass · Issue #96151 · python/cpython

X Title: `BUILTINS` is not a valid field name for a frozen dataclass · Issue #96151 · python/cpython

Description: This is not a bug that I encountered in the wild, but I happened to notice the possibility for this while reading the source. from dataclasses import dataclass @dataclass(frozen=True) class X: BUILTINS: str X(5) will give you: Traceback ...

Open Graph Description: This is not a bug that I encountered in the wild, but I happened to notice the possibility for this while reading the source. from dataclasses import dataclass @dataclass(frozen=True) class X: BUIL...

X Description: This is not a bug that I encountered in the wild, but I happened to notice the possibility for this while reading the source. from dataclasses import dataclass @dataclass(frozen=True) class X: BUIL...

Opengraph URL: https://github.com/python/cpython/issues/96151

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`BUILTINS` is not a valid field name for a frozen dataclass","articleBody":"This is not a bug that I encountered in the wild, but I happened to notice the possibility for this while reading the source.\r\n\r\n```\r\nfrom dataclasses import dataclass\r\n@dataclass(frozen=True)\r\nclass X:\r\n    BUILTINS: str\r\nX(5)\r\n```\r\n\r\nwill give you:\r\n```\r\nTraceback (most recent call last):\r\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\r\n  File \"\u003cstring\u003e\", line 3, in __init__\r\nAttributeError: 'int' object has no attribute 'object'\r\n```\r\n\r\nThere are other field names that you can use to trick dataclass into bad behaviour, but all of the other ones are prefixed by an underscore.\r\n\r\nSo one \"fix\" is pretty simple: just rename `BUILTINS` to `_BUILTINS` in dataclasses.py to bring it in line with the others.\r\n\r\nIf a single underscore doesn't feel like sufficient \"this is the user's fault\", we could use `__dataclass_*` (like we do for `__dataclass_self__` param to `__init__`)\r\n\r\nFor what it's worth, the only thing we need `BUILTINS` for is so we can access `object` inside `__init__`, so an alternative fix could be to use `().__class__.__base__` instead of `BUILTINS.object` (and skip the locals dance needed to define `BUILTINS` altogether)\r\n\r\nIf any of that sounds worth doing, I'd be happy to open a PR\n\n\u003c!-- gh-pr-number: gh-98143 --\u003e\n* PR: gh-98143\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-98899 --\u003e\n* PR: gh-98899\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-98900 --\u003e\n* PR: gh-98900\n\u003c!-- /gh-pr-number --\u003e\n","author":{"url":"https://github.com/hauntsaninja","@type":"Person","name":"hauntsaninja"},"datePublished":"2022-08-21T07:45:58.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/96151/cpython/issues/96151"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e0650e9b-9dc5-4747-b734-ea4b2d115ad2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD426:147A05:FF40FD:15AC836:6A4F0963
html-safe-nonce4f427fb0b523304b270d96103634946bebaaffe06150d7330b693cb5ba040880
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDI2OjE0N0EwNTpGRjQwRkQ6MTVBQzgzNjo2QTRGMDk2MyIsInZpc2l0b3JfaWQiOiIyMjU5MzA4MzA3MzYwNDUwOTE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0e49a7c9e46e99bf68d2207a73b2a93969b5c2c9a71f02b80ca06c631753d3d7
hovercard-subject-tagissue:1345413689
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/96151/issue_layout
twitter:imagehttps://opengraph.githubassets.com/a2901becf2fe471cf76676d7d700611ba350d97c74b0d042e7f95bc23208973b/python/cpython/issues/96151
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a2901becf2fe471cf76676d7d700611ba350d97c74b0d042e7f95bc23208973b/python/cpython/issues/96151
og:image:altThis is not a bug that I encountered in the wild, but I happened to notice the possibility for this while reading the source. from dataclasses import dataclass @dataclass(frozen=True) class X: BUIL...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehauntsaninja
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/96151#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F96151
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F96151
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/96151
Reloadhttps://github.com/python/cpython/issues/96151
Reloadhttps://github.com/python/cpython/issues/96151
Please reload this pagehttps://github.com/python/cpython/issues/96151
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/96151
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
BUILTINS is not a valid field name for a frozen dataclasshttps://github.com/python/cpython/issues/96151#top
https://github.com/ericvsmith
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Aug 21, 2022https://github.com/python/cpython/issues/96151#issue-1345413689
gh-96151: Use a private name for passing builtins to dataclass #98143https://github.com/python/cpython/pull/98143
[3.10] gh-96151: Use a private name for passing builtins to dataclass. This now allows for a field named BUILTIN (gh-98143) #98899https://github.com/python/cpython/pull/98899
[3.11] gh-96151: Use a private name for passing builtins to dataclass. This now allows for a field named BUILTIN (gh-98143) #98900https://github.com/python/cpython/pull/98900
ericvsmithhttps://github.com/ericvsmith
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.