Title: Lib/inspect.py: Avoid wild replacement in formatannotation · Issue #96073 · python/cpython · GitHub
Open Graph Title: Lib/inspect.py: Avoid wild replacement in formatannotation · Issue #96073 · python/cpython
X Title: Lib/inspect.py: Avoid wild replacement in formatannotation · Issue #96073 · python/cpython
Description: Bug report Source: cpython/Lib/inspect.py Lines 1449 to 1458 in 91afe66 def formatannotation(annotation, base_module=None): if getattr(annotation, '__module__', None) == 'typing': return repr(annotation).replace('typing.', '') if isinsta...
Open Graph Description: Bug report Source: cpython/Lib/inspect.py Lines 1449 to 1458 in 91afe66 def formatannotation(annotation, base_module=None): if getattr(annotation, '__module__', None) == 'typing': return repr(annot...
X Description: Bug report Source: cpython/Lib/inspect.py Lines 1449 to 1458 in 91afe66 def formatannotation(annotation, base_module=None): if getattr(annotation, '__module__', None) == 'typing': r...
Opengraph URL: https://github.com/python/cpython/issues/96073
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Lib/inspect.py: Avoid wild replacement in formatannotation","articleBody":"\u003c!--\r\n If you're new to Python and you're not sure whether what you're experiencing is a bug, the CPython issue tracker is not\r\n the right place to seek help. Consider the following options instead:\r\n\r\n - reading the Python tutorial: https://docs.python.org/3/tutorial/\r\n - posting in the \"Users\" category on discuss.python.org: https://discuss.python.org/c/users/7\r\n - emailing the Python-list mailing list: https://mail.python.org/mailman/listinfo/python-list\r\n - searching our issue tracker (https://github.com/python/cpython/issues) to see if\r\n your problem has already been reported\r\n--\u003e\r\n\r\n# Bug report\r\n\r\nSource: https://github.com/python/cpython/blob/91afe66707237558d808aeca4683d0822aa0511e/Lib/inspect.py#L1449-L1458\r\n\r\nAn error replacement happens in:\r\n\r\n```python\r\nrepr(annotation).replace('typing.', '')\r\n```\r\n\r\nSuppose that I define a class or Protocol under `foo/typing.py`:\r\n\r\n```python\r\nclass A:\r\n pass\r\n```\r\n\r\nThen `Union[int, A]` will turn to `Union[int, foo.A]`, but expected result is `Union[int, foo.typing.A]`\r\n\r\nAny module with suffix like `xxtyping` will be replaced, such as `nptyping`.\r\n\r\n# Solution\r\n\r\nReplace the line to:\r\n\r\n```python\r\n def repl(match):\r\n text = match.group()\r\n if text.startswith('typing.'):\r\n return text[len('typing.'):]\r\n return text\r\n return re.sub(r'[\\w\\.]+', repl, repr(annotation))\r\n```\r\n\r\n","author":{"url":"https://github.com/iyume","@type":"Person","name":"iyume"},"datePublished":"2022-08-18T14:13:21.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/96073/cpython/issues/96073"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:411c9a17-6ecf-2b0d-1821-6856e33348c1 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CB32:2FF27D:17CE81:1FCDB5:6969A65C |
| html-safe-nonce | ab6c1b60e06daff0186b42209dc6547bf355d49c3cb73ae6cb97143030bfc9a4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjMyOjJGRjI3RDoxN0NFODE6MUZDREI1OjY5NjlBNjVDIiwidmlzaXRvcl9pZCI6IjQwNTA4MjYzMzI4NjgyOTAxNDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f21c167bd940843576e4d21fd791cc8f34a1b48b589db9f9c9bef055ad5acd72 |
| hovercard-subject-tag | issue:1343170960 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/96073/issue_layout |
| twitter:image | https://opengraph.githubassets.com/bb06644278df1695064cd6b113721a8234a0cab65e2b9fc3fd11eaf00d3a4f6d/python/cpython/issues/96073 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bb06644278df1695064cd6b113721a8234a0cab65e2b9fc3fd11eaf00d3a4f6d/python/cpython/issues/96073 |
| og:image:alt | Bug report Source: cpython/Lib/inspect.py Lines 1449 to 1458 in 91afe66 def formatannotation(annotation, base_module=None): if getattr(annotation, '__module__', None) == 'typing': return repr(annot... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | iyume |
| hostname | github.com |
| expected-hostname | github.com |
| None | 24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 124667f43168afb6c9c03b7c02eb5b1d2e1be3d9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width