René's URL Explorer Experiment


Title: urlparse does not correctly handle signs, underscores, and whitespace in port numbers · Issue #96035 · python/cpython · GitHub

Open Graph Title: urlparse does not correctly handle signs, underscores, and whitespace in port numbers · Issue #96035 · python/cpython

X Title: urlparse does not correctly handle signs, underscores, and whitespace in port numbers · Issue #96035 · python/cpython

Description: Background RFC 3986 (spec for URIs) defines a valid port string with the following grammar rule: port = *DIGIT Here's the WHATWG URL spec definition: """ A URL-port string must be one of the following: the empty string one or more ASCII ...

Open Graph Description: Background RFC 3986 (spec for URIs) defines a valid port string with the following grammar rule: port = *DIGIT Here's the WHATWG URL spec definition: """ A URL-port string must be one of the follow...

X Description: Background RFC 3986 (spec for URIs) defines a valid port string with the following grammar rule: port = *DIGIT Here's the WHATWG URL spec definition: """ A URL-port string must b...

Opengraph URL: https://github.com/python/cpython/issues/96035

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"urlparse does not correctly handle signs, underscores, and whitespace in port numbers","articleBody":"# Background\r\nRFC 3986 (spec for URIs) defines a valid port string with the following grammar rule:\r\n- `port = *DIGIT`\r\n\r\nHere's the WHATWG URL spec definition:\r\n\"\"\"\r\nA URL-port string must be one of the following:\r\n- the empty string\r\n- one or more [ASCII digits](https://infra.spec.whatwg.org/#ascii-digit) representing a decimal number no greater than $2^{16} − 1$.\r\n\r\n\"\"\"[^1]\r\n[^1]:Given that this is `urlparse` and not `uriparse`, it seems appropriate that we do not accept port numbers outside `range(2**16)`, even though such numbers are allowed by RFC 3986.\r\n\r\n# The bug\r\nThis is the port string parsing code from `Lib/urllib/parse.py:166-176`:\r\n```python\r\ndef port(self):\r\n    port = self._hostinfo[1]\r\n    if port is not None:\r\n        try:\r\n            port = int(port, 10)\r\n        except ValueError:\r\n            message = f'Port could not be cast to integer value as {port!r}'\r\n            raise ValueError(message) from None\r\n        if not ( 0 \u003c= port \u003c= 65535):\r\n            raise ValueError(\"Port out of range 0-65535\")\r\n    return port\r\n```\r\nThis will erroneously validate strings  `\"-0\"` and `f\"+{x}\"` for any value of `x` in the valid range. Given that `+` and `-` are not digits, this behavior is in violation of both specifications.\r\n\r\nThis bug is easily reproducible with the following snippet:\r\n```python\r\nfrom urllib.parse import urlparse\r\nurl1 = urlparse(\"http://python.org:-0\")\r\nurl2 = urlparse(\"http://python.org:+80\")\r\nprint(url1.port) # prints 0, but error is expected\r\nprint(url2.port) # prints 80, but error is expected\r\n```\r\nHappy to submit a PR, but don't want to step on any toes over at #25774.\r\n\r\n# My environment\r\n- CPython version tested on:\r\n  - 3.10.6\r\n- Operating system and architecture:\r\n  - Arch Linux x86_64","author":{"url":"https://github.com/kenballus","@type":"Person","name":"kenballus"},"datePublished":"2022-08-16T20:45:48Z","url":"https://github.com/python/cpython/issues/96035"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:7fe1a58f-2063-7005-72dd-e5a2596091e2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB798:23DB5F:118FCEC:1609774:6B02459F
html-safe-nonce94d0dceb3b55b5bb46c85689f9001e6b7f15dc5b8f929b6a237096dc8858c8d0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzk4OjIzREI1RjoxMThGQ0VDOjE2MDk3NzQ6NkIwMjQ1OUYiLCJ2aXNpdG9yX2lkIjoiMjQwNzQ1NjkxMjEyMDYyODYzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9ee63eb359e0dca4ba1234216b4e27d3ed683613927858fc0ab491471a2965a3
hovercard-subject-tagissue:1340863065
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/96035/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b416d79f62773d67bc07c632c4741a0d6a2b0ee14d71d5c30bb17d0d10099a29/python/cpython/issues/96035
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b416d79f62773d67bc07c632c4741a0d6a2b0ee14d71d5c30bb17d0d10099a29/python/cpython/issues/96035
og:image:altBackground RFC 3986 (spec for URIs) defines a valid port string with the following grammar rule: port = *DIGIT Here's the WHATWG URL spec definition: """ A URL-port string must be one of the follow...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekenballus
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/96035#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F96035
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F96035
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/96035
Reloadhttps://github.com/python/cpython/issues/96035
Reloadhttps://github.com/python/cpython/issues/96035
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/96035
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/96035
urlparse does not correctly handle signs, underscores, and whitespace in port numbershttps://github.com/python/cpython/issues/96035#top
https://github.com/JelleZijlstra
3.10 (EOL)end of lifehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.10%20(EOL)%22
3.11only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.11%22
3.12only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.12%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
triagedThe issue has been accepted as valid by a triager.https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22triaged%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/kenballus
kenballushttps://github.com/kenballus
on Aug 16, 2022https://github.com/python/cpython/issues/96035#issue-1340863065
ASCII digitshttps://infra.spec.whatwg.org/#ascii-digit
1https://github.com/python/cpython/issues/96035#user-content-fn-1-84a60848dc61c1bf7ddb94b1d0651e73
#25774https://github.com/python/cpython/pull/25774
↩https://github.com/python/cpython/issues/96035#user-content-fnref-1-84a60848dc61c1bf7ddb94b1d0651e73
kenballushttps://github.com/kenballus
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
on Aug 16, 2022https://github.com/python/cpython/issues/96035#event-7200474710
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on Aug 16, 2022https://github.com/python/cpython/issues/96035#issuecomment-1217149569
https://github.com/kenballus
kenballushttps://github.com/kenballus
on Aug 16, 2022https://github.com/python/cpython/issues/96035#issuecomment-1217177298
http://python.org:80_80http://python.org:80_80
JelleZijlstrahttps://github.com/JelleZijlstra
on Aug 16, 2022https://github.com/python/cpython/issues/96035#event-7200669696
https://github.com/lightswitch05
lightswitch05https://github.com/lightswitch05
on Aug 23, 2022https://github.com/python/cpython/issues/96035#issuecomment-1224004617
https://github.com/kenballus
kenballushttps://github.com/kenballus
on Aug 23, 2022https://github.com/python/cpython/issues/96035#issuecomment-1224067785
https://github.com/lightswitch05
lightswitch05https://github.com/lightswitch05
on Aug 23, 2022https://github.com/python/cpython/issues/96035#issuecomment-1224219085
https://github.com/kenballus
kenballushttps://github.com/kenballus
on Aug 23, 2022https://github.com/python/cpython/issues/96035#issuecomment-1224235672
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
on Sep 13, 2022https://github.com/python/cpython/issues/96035#issuecomment-1246000408
gpsheadhttps://github.com/gpshead
3.11only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.11%22
3.10 (EOL)end of lifehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.10%20(EOL)%22
3.12only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.12%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
triagedThe issue has been accepted as valid by a triager.https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22triaged%22
on Sep 13, 2022https://github.com/python/cpython/issues/96035#event-7380413164
JelleZijlstrahttps://github.com/JelleZijlstra
on Oct 20, 2022https://github.com/python/cpython/issues/96035#event-7634959045
gh-96035: Make urllib.parse.urlparse reject non-numeric ports (#98273)https://github.com/python/cpython/commit/6f15ca8c7afa23e1adc87f2b66b958b721f9acab
gh-96035https://github.com/python/cpython/issues/96035
#98273https://github.com/python/cpython/pull/98273
6f15ca8https://github.com/python/cpython/commit/6f15ca8c7afa23e1adc87f2b66b958b721f9acab
miss-islingtonhttps://github.com/miss-islington
on Oct 20, 2022https://github.com/python/cpython/issues/96035#event-7634963458
pythongh-96035: Make urllib.parse.urlparse reject non-numeric ports (p…https://github.com/miss-islington/cpython/commit/1bae88cced1133abe1e716540e28108a4b19d1dd
pythongh-96035https://github.com/python/cpython/issues/96035
p…https://github.com/python/cpython/pull/98273
1bae88chttps://github.com/miss-islington/cpython/commit/1bae88cced1133abe1e716540e28108a4b19d1dd
pythongh-96035: Make urllib.parse.urlparse reject non-numeric ports (p…https://github.com/miss-islington/cpython/commit/c0f35769b43d6a0ad3feaf2f197650f58d1b0939
pythongh-96035https://github.com/python/cpython/issues/96035
p…https://github.com/python/cpython/pull/98273
c0f3576https://github.com/miss-islington/cpython/commit/c0f35769b43d6a0ad3feaf2f197650f58d1b0939
JelleZijlstrahttps://github.com/JelleZijlstra
on Oct 20, 2022https://github.com/python/cpython/issues/96035#event-7635043405
miss-islingtonhttps://github.com/miss-islington
on Oct 20, 2022https://github.com/python/cpython/issues/96035#event-7635145492
gh-96035: Make urllib.parse.urlparse reject non-numeric ports (GH-98273)https://github.com/python/cpython/commit/1520f4e45bc9d968a98d062ca6880387a0d98c08
gh-96035https://github.com/python/cpython/issues/96035
GH-98273https://github.com/python/cpython/pull/98273
1520f4ehttps://github.com/python/cpython/commit/1520f4e45bc9d968a98d062ca6880387a0d98c08
gh-96035: Make urllib.parse.urlparse reject non-numeric ports (GH-98273)https://github.com/python/cpython/commit/0db4c5990c7b994e0272b7812e2692d110ab2aec
gh-96035https://github.com/python/cpython/issues/96035
GH-98273https://github.com/python/cpython/pull/98273
0db4c59https://github.com/python/cpython/commit/0db4c5990c7b994e0272b7812e2692d110ab2aec
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on Oct 20, 2022https://github.com/python/cpython/issues/96035#issuecomment-1286182136
JelleZijlstrahttps://github.com/JelleZijlstra
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 20, 2022https://github.com/python/cpython/issues/96035#event-7635188829
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/96035
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/96035
JelleZijlstrahttps://github.com/JelleZijlstra
3.10 (EOL)end of lifehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.10%20(EOL)%22
3.11only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.11%22
3.12only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.12%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
triagedThe issue has been accepted as valid by a triager.https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22triaged%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.