Title: Check tokens[0] after allocating memory · Issue #95355 · python/cpython · GitHub
Open Graph Title: Check tokens[0] after allocating memory · Issue #95355 · python/cpython
X Title: Check tokens[0] after allocating memory · Issue #95355 · python/cpython
Description: Bug report I have questions when reading the source code of file pegen.c. There is a code snippet in function _PyPegen_Parser_New: p->tokens[0] = PyMem_Calloc(1, sizeof(Token)); if (!p->tokens) { PyMem_Free(p->tokens); PyMem_Free(p); ret...
Open Graph Description: Bug report I have questions when reading the source code of file pegen.c. There is a code snippet in function _PyPegen_Parser_New: p->tokens[0] = PyMem_Calloc(1, sizeof(Token)); if (!p->tokens) { P...
X Description: Bug report I have questions when reading the source code of file pegen.c. There is a code snippet in function _PyPegen_Parser_New: p->tokens[0] = PyMem_Calloc(1, sizeof(Token)); if (!p->token...
Opengraph URL: https://github.com/python/cpython/issues/95355
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Check tokens[0] after allocating memory","articleBody":"\u003c!--\r\n If you're new to Python and you're not sure whether what you're experiencing is a bug, the CPython issue tracker is not\r\n the right place to seek help. Consider the following options instead:\r\n\r\n - reading the Python tutorial: https://docs.python.org/3/tutorial/\r\n - posting in the \"Users\" category on discuss.python.org: https://discuss.python.org/c/users/7\r\n - emailing the Python-list mailing list: https://mail.python.org/mailman/listinfo/python-list\r\n - searching our issue tracker (https://github.com/python/cpython/issues) to see if\r\n your problem has already been reported\r\n--\u003e\r\n\r\n# Bug report\r\n\r\nI have questions when reading the source code of file `pegen.c`.\r\nThere is a code snippet in function `_PyPegen_Parser_New`:\r\n```c\r\np-\u003etokens[0] = PyMem_Calloc(1, sizeof(Token));\r\nif (!p-\u003etokens) {\r\n PyMem_Free(p-\u003etokens);\r\n PyMem_Free(p);\r\n return (Parser *) PyErr_NoMemory();\r\n}\r\n```\r\nI think it makes more sense to check `p-\u003etokens[0]` but not `p-\u003etokens` in if condition.\r\n\r\nI look at the PR #19669 where the code was introduced and no one discussed this. Is this an oversight, or am I wrong?\r\n\r\n# Your environment\r\n\r\n\u003c!-- Include as many relevant details as possible about the environment you experienced the bug in --\u003e\r\n\r\n- CPython versions tested on: main branch\r\n\r\n\u003c!--\r\nYou can freely edit this text. Remove any lines you believe are unnecessary.\r\n--\u003e\r\n","author":{"url":"https://github.com/imzhuhl","@type":"Person","name":"imzhuhl"},"datePublished":"2022-07-28T05:08:16.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/95355/cpython/issues/95355"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:cfc81dce-6ef0-e383-a529-ffd21579cd74 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 813E:296AF5:BE9748:1098E41:696A7F5A |
| html-safe-nonce | 434c845f16a156b9ed773d621e95292faa15fee068ef9ea6ea51160d66bc7c2a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTNFOjI5NkFGNTpCRTk3NDg6MTA5OEU0MTo2OTZBN0Y1QSIsInZpc2l0b3JfaWQiOiI0Mzc3ODc4NTQwNDUxNDc5Mzg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d42af44db8a17688b1f40cc70f16bc584d396dcfd12565e18fb9b0fd2c898af8 |
| hovercard-subject-tag | issue:1320400335 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/95355/issue_layout |
| twitter:image | https://opengraph.githubassets.com/48dddaf0d9ae9b0f51e22413ef470ae3d309b533f05922cdd7a741b49c4e330a/python/cpython/issues/95355 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/48dddaf0d9ae9b0f51e22413ef470ae3d309b533f05922cdd7a741b49c4e330a/python/cpython/issues/95355 |
| og:image:alt | Bug report I have questions when reading the source code of file pegen.c. There is a code snippet in function _PyPegen_Parser_New: p->tokens[0] = PyMem_Calloc(1, sizeof(Token)); if (!p->tokens) { P... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | imzhuhl |
| hostname | github.com |
| expected-hostname | github.com |
| None | 913560fa317c3c5a71e34f9b19253c9f09d02b4b958a86c2a56f4c8541116377 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5998c30593994bf2589055aef7b22d368a499367 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width