René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Argument Clinic does not increase NoneType refcount when returning NoneType from a function with no parameters","articleBody":"**Bug report**\r\n\r\n```python\r\n/*[clinic input]\r\nfunction -\u003e NoneType\r\n[clinic start generated code]*/\r\n```\r\n\r\nwill produce this function:\r\n```c\r\nstatic PyObject *\r\nfunction(PyObject *module, PyObject *Py_UNUSED(ignored))\r\n{\r\n    return function_impl(module);\r\n}\r\n```\r\n\r\nwhile `function_impl` returns `Py_None` (as it should, if using NoneType return converter), refcount is not increased.\r\n\r\nhere is a working example of NoneType return converter:\r\n```python\r\n/*[clinic input]\r\nfunction -\u003e NoneType\r\n\r\n    a: int\r\n    /\r\n[clinic start generated code]*/\r\n```\r\n```c\r\nstatic PyObject *\r\nfunction(PyObject *module, PyObject *arg)\r\n{\r\n    PyObject *return_value = NULL;\r\n    int a;\r\n    PyObject *_return_value;\r\n\r\n    a = _PyLong_AsInt(arg);\r\n    if (a == -1 \u0026\u0026 PyErr_Occurred()) {\r\n        goto exit;\r\n    }\r\n    _return_value = function_impl(module, a);\r\n    if (_return_value != Py_None) {\r\n        goto exit;\r\n    }\r\n    return_value = Py_None;\r\n    Py_INCREF(Py_None);\r\n\r\nexit:\r\n    return return_value;\r\n}\r\n```\r\n\r\nGeneration also fails when generating a function with a single `object` parameter.\r\n\r\nIt seems like the problem is with `default_return_converter` in clinic.py, being set to `True`\r\n","author":{"url":"https://github.com/noamcohen97","@type":"Person","name":"noamcohen97"},"datePublished":"2022-07-19T14:08:54.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/95007/cpython/issues/95007"}