René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"make `asyncio.iscoroutinefunction` a deprecated alias of `inspect.iscoroutinefunction` and remove `asyncio.coroutines._is_coroutine`","articleBody":"currently asyncio.iscoroutinefunction and inspect.iscoroutinefunction behave differently in [confusing and hard to document ways](https://github.com/python/cpython/issues/67707). It's possible to bring them into alignment but I think it would be better to make `asyncio.iscoroutinefunction` a deprecated alias of `inspect.iscoroutinefunction` and remove `asyncio.coroutines._is_coroutine`.\r\n\r\nThis is now possible with the recent [removal of `@asyncio.coroutine`](https://github.com/python/cpython/pull/26369) and support for [AsyncMock and other duck-type functions in inspect.iscoroutinefunction](https://github.com/python/cpython/pull/94050)\r\n\r\nthe only caveats are - what should happen to users of the `asyncio.coroutines._is_coroutine` mark? eg:\r\nhttps://github.com/python/cpython/blob/1c0cf0aef4b43b875b0191fd6f8956c929694a1f/Lib/asyncio/tasks.py#L686-L696\r\n\r\nand all of these:\r\n\r\n```\r\nLib/test/test_asyncio/test_base_events.py:    m_socket.getaddrinfo._is_coroutine = False\r\nLib/test/test_asyncio/test_base_events.py:        self.loop._add_reader._is_coroutine = False\r\nLib/test/test_asyncio/test_base_events.py:        self.loop._add_writer._is_coroutine = False\r\nLib/test/test_asyncio/test_base_events.py:        self.loop._add_reader._is_coroutine = False\r\nLib/test/test_asyncio/test_base_events.py:        self.loop._add_writer._is_coroutine = False\r\nLib/test/test_asyncio/test_base_events.py:        self.loop._add_reader._is_coroutine = False\r\nLib/test/test_asyncio/test_base_events.py:        self.loop._add_writer._is_coroutine = False\r\nLib/test/test_asyncio/test_base_events.py:        m_socket.getaddrinfo._is_coroutine = False\r\nLib/test/test_asyncio/test_base_events.py:        m_socket.getaddrinfo._is_coroutine = False\r\nLib/test/test_asyncio/test_base_events.py:        self.loop._add_reader._is_coroutine = False\r\nLib/test/test_asyncio/test_selector_events.py:        self.loop.add_reader._is_coroutine = False\r\nLib/test/test_asyncio/test_subprocess.py:        protocol.connection_made._is_coroutine = False\r\nLib/test/test_asyncio/test_subprocess.py:        protocol.process_exited._is_coroutine = False\r\nLib/unittest/mock.py:    mock._is_coroutine = asyncio.coroutines._is_coroutine\r\nLib/unittest/mock.py:        # iscoroutinefunction() checks _is_coroutine property to say if an\r\nLib/unittest/mock.py:        self.__dict__['_is_coroutine'] = asyncio.coroutines._is_coroutine\r\n```\n\n\u003c!-- gh-pr-number: gh-99247 --\u003e\n* PR: gh-99247\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-100935 --\u003e\n* PR: gh-100935\n\u003c!-- /gh-pr-number --\u003e\n","author":{"url":"https://github.com/graingert","@type":"Person","name":"graingert"},"datePublished":"2022-07-17T00:25:40.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":34},"url":"https://github.com/94912/cpython/issues/94912"}