René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"makesetup can fail on macOS and uses wrong CFLAGS","articleBody":"**Bug report**\r\n\r\nThe script ``Modules/makesetup`` has two issues\r\n\r\n1) It uses sed ``i`` command with multiple escapes newlines. The feature works fine in GNU sed but does not work correctly with macOS' BSD sed. @ned-deily found a [workaround](https://github.com/python/cpython/pull/93940#issuecomment-1169390421) for the problem. The ``r`` command with an external replacement file works correctly on GNU and BSD sed.\r\n\r\n2) ``makesetup`` creates wrong compile rules for object files that end up in a shared library. The variables ``$(CCSHARED) $(PY_CFLAGS_NODIST) $(PY_CPPFLAGS)`` are missing some flags like address sanitizer. The script should create rules with ``$(PY_STDMODULE_CFLAGS) $(CCSHARED)`` instead.\r\n\r\n3) the order of cflags can break builds. For example macOS ARM64 builds are [broken](https://buildbot.python.org/all/#/builders/721/builds/481) because ``-I./Modules/_decimal/libmpdec`` comes after ``-I/opt/homebrew/include`` and the buildbot seems to come with an incompatible libmpdec header. Module-specific CFLAGs should come before Python CFLAGs. It is probably easier to move module CFLAGS before ``PY_STDMODULE_CFLAGS``. The homebrew flag comes from ``PY_CPPFLAGS`` and ``CONFIGURE_CPPFLAGS``.","author":{"url":"https://github.com/tiran","@type":"Person","name":"tiran"},"datePublished":"2022-06-29T06:55:47.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/94404/cpython/issues/94404"}