René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"test_logging: test_config_queue_handler() race condition","articleBody":"The implementation of test_logging.test_config_queue_handler() uses time.sleep(0.010) as synchronization primitive.\r\n\r\n@vsajip: please don't use time.sleep() as sync primitive: https://pythondev.readthedocs.io/unstable_tests.html#don-t-use-sleep-as-synchronization\r\n\r\nThe test fails when the machine is busy:\r\n\r\n```\r\n$ ./python -m test test_logging -m test_config_queue_handler -F -j10 -v\r\n(...)\r\n0:00:10 load avg: 2.36 [ 48/1] test_logging failed (1 failure)\r\ntest_config_queue_handler (test.test_logging.ConfigDictTest.test_config_queue_handler) ... FAIL\r\n\r\n======================================================================\r\nFAIL: test_config_queue_handler (test.test_logging.ConfigDictTest.test_config_queue_handler)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/home/vstinner/python/main/Lib/test/test_logging.py\", line 3647, in test_config_queue_handler\r\n    self.do_queuehandler_configuration(qspec, lspec)\r\n    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n  File \"/home/vstinner/python/main/Lib/test/test_logging.py\", line 3621, in do_queuehandler_configuration\r\n    self.assertEqual(data, ['foo', 'bar', 'baz'])\r\n    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\nAssertionError: Lists differ: [] != ['foo', 'bar', 'baz']\r\n\r\nSecond list contains 3 additional elements.\r\nFirst extra element 0:\r\n'foo'\r\n\r\n- []\r\n+ ['foo', 'bar', 'baz']\r\n\r\n----------------------------------------------------------------------\r\nRan 1 test in 0.466s\r\n\r\nFAILED (failures=1)\r\n```\r\n\r\nExtract of the test:\r\n\r\n```\r\n        delay = 0.01\r\n        try:\r\n            self.apply_config(cd)\r\n            qh = logging.getHandlerByName('ah')\r\n            self.assertEqual(sorted(logging.getHandlerNames()), ['ah', 'h1'])\r\n            self.assertIsNotNone(qh.listener)\r\n            qh.listener.start()\r\n            # Need to let the listener thread get started\r\n            time.sleep(delay)\r\n            logging.debug('foo')\r\n            logging.info('bar')\r\n            logging.warning('baz')\r\n            # Need to let the listener thread finish its work\r\n            time.sleep(delay)\r\n            with open(fn, encoding='utf-8') as f:\r\n                data = f.read().splitlines()\r\n            self.assertEqual(data, ['foo', 'bar', 'baz'])\r\n        finally:\r\n            if qh:\r\n                qh.listener.stop()\r\n            h = logging.getHandlerByName('h1')\r\n            if h:\r\n                self.addCleanup(closeFileHandler, h, fn)\r\n            else:\r\n                self.addCleanup(os.remove, fn)\r\n```","author":{"url":"https://github.com/vstinner","@type":"Person","name":"vstinner"},"datePublished":"2022-06-13T09:16:44.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/93761/cpython/issues/93761"}