René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"setup.py only reports successful builds if one or more stdlib modules are missing","articleBody":"_\"Python build finished successfully!\"_ is only printed if there were missing modules:\r\n\r\nhttps://github.com/python/cpython/blob/cf730b595eea0460a7305205f7dfb6ecf0346351/setup.py#L539-L547\r\n\r\nEither we print it every time the build succeeds:\r\n\r\n```diff\r\ndiff --git a/setup.py b/setup.py\r\nindex 4c497346e8..e87da57a47 100644\r\n--- a/setup.py\r\n+++ b/setup.py\r\n@@ -538,5 +538,9 @@ def print_three_column(lst):\r\n \r\n-        if self.missing:\r\n+        if not self.failed:\r\n             print()\r\n             print(\"Python build finished successfully!\")\r\n+            print()\r\n+\r\n+        if self.missing:\r\n+            print()\r\n             print(\"The necessary bits to build these optional modules were not \"\r\n```\r\n\r\nOr we just remove that line from `setup.py`.\r\n\r\nI'm fine with either.\r\n\r\n_Originally reported by @izumiberat in https://github.com/python/cpython/issues/93659#issuecomment-1152435498_","author":{"url":"https://github.com/erlend-aasland","@type":"Person","name":"erlend-aasland"},"datePublished":"2022-06-10T18:35:42.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/93692/cpython/issues/93692"}