Title: Reorder instructions in with/async-with exception handler to reduce the size of the exception table. · Issue #93621 · python/cpython · GitHub
Open Graph Title: Reorder instructions in with/async-with exception handler to reduce the size of the exception table. · Issue #93621 · python/cpython
X Title: Reorder instructions in with/async-with exception handler to reduce the size of the exception table. · Issue #93621 · python/cpython
Description: The dis for this function: def f1(cm): with cm: x = 1 x = 2 is this: 11 0 RESUME 0 12 2 LOAD_FAST 0 (cm) 4 BEFORE_WITH 6 POP_TOP 13 8 LOAD_CONST 1 (1) 10 STORE_FAST 1 (x) 12 12 LOAD_CONST 0 (None) 14 LOAD_CONST 0 (None) 16 LOAD_CONST 0 (...
Open Graph Description: The dis for this function: def f1(cm): with cm: x = 1 x = 2 is this: 11 0 RESUME 0 12 2 LOAD_FAST 0 (cm) 4 BEFORE_WITH 6 POP_TOP 13 8 LOAD_CONST 1 (1) 10 STORE_FAST 1 (x) 12 12 LOAD_CONST 0 (None) ...
X Description: The dis for this function: def f1(cm): with cm: x = 1 x = 2 is this: 11 0 RESUME 0 12 2 LOAD_FAST 0 (cm) 4 BEFORE_WITH 6 POP_TOP 13 8 LOAD_CONST 1 (1) 10 STORE_FAST 1 (x) 12 12 LOAD_CONST 0 (None) ...
Opengraph URL: https://github.com/python/cpython/issues/93621
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Reorder instructions in with/async-with exception handler to reduce the size of the exception table.","articleBody":"The dis for this function:\r\n\r\n```\r\ndef f1(cm):\r\n with cm:\r\n x = 1\r\n x = 2\r\n```\r\n\r\nis this:\r\n\r\n```\r\n 11 0 RESUME 0\r\n\r\n 12 2 LOAD_FAST 0 (cm)\r\n 4 BEFORE_WITH\r\n 6 POP_TOP\r\n\r\n 13 8 LOAD_CONST 1 (1)\r\n 10 STORE_FAST 1 (x)\r\n\r\n 12 12 LOAD_CONST 0 (None)\r\n 14 LOAD_CONST 0 (None)\r\n 16 LOAD_CONST 0 (None)\r\n 18 CALL 2\r\n 28 POP_TOP\r\n\r\n 14 30 LOAD_CONST 2 (2)\r\n 32 STORE_FAST 1 (x)\r\n 34 LOAD_CONST 0 (None)\r\n 36 RETURN_VALUE\r\n\r\n 12 \u003e\u003e 38 PUSH_EXC_INFO\r\n 40 WITH_EXCEPT_START\r\n 42 POP_JUMP_FORWARD_IF_TRUE 4 (to 52)\r\n 44 RERAISE 2\r\n \u003e\u003e 46 COPY 3\r\n 48 POP_EXCEPT\r\n 50 RERAISE 1\r\n \u003e\u003e 52 POP_TOP\r\n 54 POP_EXCEPT\r\n 56 POP_TOP\r\n 58 POP_TOP\r\n\r\n 14 60 LOAD_CONST 2 (2)\r\n 62 STORE_FAST 1 (x)\r\n 64 LOAD_CONST 0 (None)\r\n 66 RETURN_VALUE\r\nExceptionTable:\r\n 6 to 10 -\u003e 38 [1] lasti\r\n 38 to 44 -\u003e 46 [3] lasti\r\n 52 to 52 -\u003e 46 [3] lasti\r\n```\r\n\r\nNote the last row of the exception table: inst 52 goes to 46, same as 38-44. We can reorder the code so that this block is consecutive, and we save one entry in the exception table for each with/async with:\r\n\r\n```\r\n 11 0 RESUME 0\r\n\r\n 12 2 LOAD_FAST 0 (cm)\r\n 4 BEFORE_WITH\r\n 6 POP_TOP\r\n\r\n 13 8 LOAD_CONST 1 (1)\r\n 10 STORE_FAST 1 (x)\r\n\r\n 12 12 LOAD_CONST 0 (None)\r\n 14 LOAD_CONST 0 (None)\r\n 16 LOAD_CONST 0 (None)\r\n 18 CALL 2\r\n 28 POP_TOP\r\n\r\n 14 30 LOAD_CONST 2 (2)\r\n 32 STORE_FAST 1 (x)\r\n 34 LOAD_CONST 0 (None)\r\n 36 RETURN_VALUE\r\n\r\n 12 \u003e\u003e 38 PUSH_EXC_INFO\r\n 40 WITH_EXCEPT_START\r\n 42 POP_JUMP_FORWARD_IF_TRUE 1 (to 46)\r\n 44 RERAISE 2\r\n \u003e\u003e 46 POP_TOP\r\n 48 POP_EXCEPT\r\n 50 POP_TOP\r\n 52 POP_TOP\r\n\r\n 14 54 LOAD_CONST 2 (2)\r\n 56 STORE_FAST 1 (x)\r\n 58 LOAD_CONST 0 (None)\r\n 60 RETURN_VALUE\r\n \u003e\u003e 62 COPY 3\r\n 64 POP_EXCEPT\r\n 66 RERAISE 1\r\nExceptionTable:\r\n 6 to 10 -\u003e 38 [1] lasti\r\n 38 to 46 -\u003e 62 [3] lasti\r\n```","author":{"url":"https://github.com/iritkatriel","@type":"Person","name":"iritkatriel"},"datePublished":"2022-06-08T23:05:46.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/93621/cpython/issues/93621"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:7434e399-705f-a850-6732-830497ddbf8a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 998A:3545E1:26293E2:31AF703:696B5B69 |
| html-safe-nonce | ef28a2d624b216a9ccbce38eaa68e6a2e961936d21d4061f511348d7396b47af |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OThBOjM1NDVFMToyNjI5M0UyOjMxQUY3MDM6Njk2QjVCNjkiLCJ2aXNpdG9yX2lkIjoiOTAwMzIyNDMwMjkzMTg5MzA5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ca37d1fd26f9125968bb7b0acf327d0b3357ef0aab79c6c76481ee89e3964420 |
| hovercard-subject-tag | issue:1265402140 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/93621/issue_layout |
| twitter:image | https://opengraph.githubassets.com/d16dbcbcb74e50bd2c2519ad67a419c7280761a035b4c0961ee8de636cdca645/python/cpython/issues/93621 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d16dbcbcb74e50bd2c2519ad67a419c7280761a035b4c0961ee8de636cdca645/python/cpython/issues/93621 |
| og:image:alt | The dis for this function: def f1(cm): with cm: x = 1 x = 2 is this: 11 0 RESUME 0 12 2 LOAD_FAST 0 (cm) 4 BEFORE_WITH 6 POP_TOP 13 8 LOAD_CONST 1 (1) 10 STORE_FAST 1 (x) 12 12 LOAD_CONST 0 (None) ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | iritkatriel |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width