René's URL Explorer Experiment


Title: test_modulefinder always modifies execution environment · Issue #93616 · python/cpython · GitHub

Open Graph Title: test_modulefinder always modifies execution environment · Issue #93616 · python/cpython

X Title: test_modulefinder always modifies execution environment · Issue #93616 · python/cpython

Description: Bug report test_modulefinder creates a temporary directory in its global module scope cpython/Lib/test/test_modulefinder.py Lines 13 to 14 in 22df2e0 TEST_DIR = tempfile.mkdtemp() TEST_PATH = [TEST_DIR, os.path.dirname(tempfile.__file__)...

Open Graph Description: Bug report test_modulefinder creates a temporary directory in its global module scope cpython/Lib/test/test_modulefinder.py Lines 13 to 14 in 22df2e0 TEST_DIR = tempfile.mkdtemp() TEST_PATH = [TEST...

X Description: Bug report test_modulefinder creates a temporary directory in its global module scope cpython/Lib/test/test_modulefinder.py Lines 13 to 14 in 22df2e0 TEST_DIR = tempfile.mkdtemp() TEST_PATH = [TEST...

Opengraph URL: https://github.com/python/cpython/issues/93616

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"test_modulefinder always modifies execution environment","articleBody":"**Bug report**\r\n\r\n``test_modulefinder`` creates a temporary directory in its global module scope\r\n\r\nhttps://github.com/python/cpython/blob/22df2e0322300d25c1255ceb73cacc0ebd96b20e/Lib/test/test_modulefinder.py#L13-L14\r\n\r\nand removes the temporary directory in each test method\r\n\r\nhttps://github.com/python/cpython/blob/22df2e0322300d25c1255ceb73cacc0ebd96b20e/Lib/test/test_modulefinder.py#L349-L350\r\n\r\nIf the test is executed in an environment without test worker processes (e.g. WASI) then the test runner complains about changes to the execution environment:\r\n\r\n```\r\n/python-wasm/cpython/builddir/wasi# wasmtime run --mapdir .::../../ -- python.wasm -m test --fail-env-changed test_modulefinder\r\n0:00:00 Run tests sequentially\r\n0:00:00 [1/1] test_modulefinder\r\nWarning -- files was modified by test_modulefinder\r\nWarning --   Before: ['tmp8avdrxn0/']\r\nWarning --   After:  [] \r\ntest_modulefinder failed (env changed)\r\n\r\n== Tests result: ENV CHANGED ==\r\n\r\n1 test altered the execution environment:\r\n    test_modulefinder\r\n\r\nTotal duration: 292 ms\r\nTests result: ENV CHANGED\r\n```\r\n\r\n``test_modulefinder`` should create the temporary directory in setUp and rmtree it in tearDown methods instead.","author":{"url":"https://github.com/tiran","@type":"Person","name":"tiran"},"datePublished":"2022-06-08T20:30:13.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/93616/cpython/issues/93616"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:1ec41fe4-82a4-7227-d21e-850c05e692d8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB0F2:65407:389B43:4B9F1D:6969AD38
html-safe-nonce4e056c754fa2d113c5232388c03797f6eac3d0e1f2c98cf0f5e55bc6bd430c79
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEYyOjY1NDA3OjM4OUI0Mzo0QjlGMUQ6Njk2OUFEMzgiLCJ2aXNpdG9yX2lkIjoiMjA3MDk2MTUzMTcxNTY5Mzg4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacaecdace033bd226c4d28b8624d9b481507ffeb0b2a06f8240a4aeeff84c4b0e6
hovercard-subject-tagissue:1265269089
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/93616/issue_layout
twitter:imagehttps://opengraph.githubassets.com/398da417f4e164b81630c7efc9fd9022c768fa63b2bf3bb62f671100ce82084d/python/cpython/issues/93616
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/398da417f4e164b81630c7efc9fd9022c768fa63b2bf3bb62f671100ce82084d/python/cpython/issues/93616
og:image:altBug report test_modulefinder creates a temporary directory in its global module scope cpython/Lib/test/test_modulefinder.py Lines 13 to 14 in 22df2e0 TEST_DIR = tempfile.mkdtemp() TEST_PATH = [TEST...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametiran
hostnamegithub.com
expected-hostnamegithub.com
None24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release124667f43168afb6c9c03b7c02eb5b1d2e1be3d9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/93616#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F93616
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F93616
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/93616
Reloadhttps://github.com/python/cpython/issues/93616
Reloadhttps://github.com/python/cpython/issues/93616
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/93616
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/93616
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/93616
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/93616
#93617https://github.com/python/cpython/pull/93617
test_modulefinder always modifies execution environmenthttps://github.com/python/cpython/issues/93616#top
#93617https://github.com/python/cpython/pull/93617
3.11only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.11%22
3.12only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.12%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/tiran
https://github.com/tiran
tiranhttps://github.com/tiran
on Jun 8, 2022https://github.com/python/cpython/issues/93616#issue-1265269089
cpython/Lib/test/test_modulefinder.pyhttps://github.com/python/cpython/blob/22df2e0322300d25c1255ceb73cacc0ebd96b20e/Lib/test/test_modulefinder.py#L13-L14
22df2e0https://github.com/python/cpython/commit/22df2e0322300d25c1255ceb73cacc0ebd96b20e
cpython/Lib/test/test_modulefinder.pyhttps://github.com/python/cpython/blob/22df2e0322300d25c1255ceb73cacc0ebd96b20e/Lib/test/test_modulefinder.py#L349-L350
22df2e0https://github.com/python/cpython/commit/22df2e0322300d25c1255ceb73cacc0ebd96b20e
3.11only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.11%22
3.12only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.12%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.