René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Replace use of `test.test_asyncio.utils.TestCase` with `unittest.IsolatedAsyncioTestCase`","articleBody":"**Feature or enhancement**\r\n\r\nGet rid of ad-hoc implementation of async tests by using all relatively new features of standard `IsolatedAsyncIoTestCase`. For this we need to:\r\n\r\n- replace all occurences of `class ...(test_utils.TestCase):` with `class ...(unittest.IsolatedAsynIoTestCase):`\r\n- remove manually created event loops in favor of the builtin one of `IsolatedAsyncIoTestCase`\r\n- make loop-dependend test cases `async`\r\n- replace multithreading with `asyncio` wherever possible\r\n- remove unused imports\r\n- remove the `TestCase` and classes it uses ([588 -\u003e 346 lines in test_asyncio/utils.py](https://github.com/python/cpython/compare/main...arhadthedev:remove-utilstestcase?expand=1))\r\n\r\n**Pitch**\r\n\r\n- `test_asyncio.utils.TestCase` provides no extra functionality over `IsolatedAsyncioTestCase`. Instead, it takes 200+ lines of code together with two more classes used nowhere else (`TestSelector` and `TestLoop`)\r\n- `TestCase` requires manual scheduling of tasks using `loop.run_until_complete` while `IsolatedAsyncioTestCase` allows `await`\r\n- `TestCase` was introduced on 2014 by c73701de7292b7de0fee5b7f82a610d7515c18a4 while `IsolatedAsynIoTestCase` was introduced 5 years later by 4dd3e3f9bbd320f0dd556688e04db0a6b55a7b52\r\n\r\n**Progress tracking**\r\n\r\n- [ ] find and fix a bug described in https://github.com/python/cpython/pull/98015#issuecomment-1271136419\r\n- [ ] test/test_asyncgen.py\r\n- [ ] test/test_coroutines.py\r\n- [ ] test/test_pdb.py\r\n- [ ] test/test_asyncio/test_base_events.py\r\n- [ ] test/test_asyncio/test_events.py\r\n- [ ] test/test_asyncio/test_futures.py\r\n- [ ] test/test_asyncio/test_pep492.py\r\n- [ ] test/test_asyncio/test_proactor_events.py\r\n- [ ] test/test_asyncio/test_sendfile.py\r\n- [ ] test/test_asyncio/test_sock_lowlevel.py\r\n- [ ] test/test_asyncio/test_ssl.py\r\n- [ ] test/test_asyncio/test_sslproto.py\r\n- [ ] test/test_asyncio/test_streams.py\r\n  - gh-93369\r\n  - gh-97896\r\n  - gh-98015\r\n- [ ] test/test_asyncio/test_subprocess.py\r\n- [ ] test/test_asyncio/test_tasks.py\r\n- [ ] test/test_asyncio/test_unix_events.py\r\n- [ ] test/test_asyncio/test_windows_events.py\r\n- [ ] replace multithreading with asyncio wherever possible\r\n- [ ] remove the `TestCase`\r\n- [ ] move `asyncio.set_event_loop_policy(None)` (a measure agains \"test altered the execution environment\" warning) into `IsolatedAsyncioTestCase`'s shutdown method\r\n\r\n\u003cdetails\u003e\r\n\u003csummary\u003eThere are 83 cases that use test_asyncio.utils.TestCase\u003c/summary\u003e\r\n\r\n- `test/test_asyncio/test_base_events.py:class BaseEventTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_base_events.py:class BaseEventLoopTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_base_events.py:class BaseEventLoopWithSelectorTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_base_events.py:class BaseLoopSockSendfileTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_base_events.py:class TestSelectorUtils(test_utils.TestCase):`\r\n- `test/test_asyncio/test_events.py:                               test_utils.TestCase):`\r\n- `test/test_asyncio/test_events.py:                                 test_utils.TestCase):`\r\n- `test/test_asyncio/test_events.py:                                   test_utils.TestCase):`\r\n- `test/test_asyncio/test_events.py:                                  test_utils.TestCase):`\r\n- `test/test_asyncio/test_events.py:                                 test_utils.TestCase):`\r\n- `test/test_asyncio/test_events.py:                               test_utils.TestCase):`\r\n- `test/test_asyncio/test_events.py:class HandleTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_futures.py:class DuckTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_futures.py:class CFutureTests(BaseFutureTests, test_utils.TestCase):`\r\n- `test/test_asyncio/test_futures.py:class CSubFutureTests(BaseFutureTests, test_utils.TestCase):`\r\n- `test/test_asyncio/test_futures.py:class PyFutureTests(BaseFutureTests, test_utils.TestCase):`\r\n- `test/test_asyncio/test_futures.py:                               test_utils.TestCase):`\r\n- `test/test_asyncio/test_futures.py:                                  test_utils.TestCase):`\r\n- `test/test_asyncio/test_futures.py:                                test_utils.TestCase):`\r\n- `test/test_asyncio/test_futures.py:                               test_utils.TestCase):`\r\n- `test/test_asyncio/test_futures.py:                              test_utils.TestCase):`\r\n- `test/test_asyncio/test_pep492.py:class BaseTest(test_utils.TestCase):`\r\n- `test/test_asyncio/test_proactor_events.py:class ProactorSocketTransportTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_proactor_events.py:class ProactorDatagramTransportTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_proactor_events.py:class BaseProactorEventLoopTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_proactor_events.py:class ProactorEventLoopUnixSockSendfileTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_selector_events.py:class BaseSelectorEventLoopTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_selector_events.py:class SelectorTransportTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_selector_events.py:class SelectorSocketTransportTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_selector_events.py:class SelectorSocketTransportBufferedProtocolTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_selector_events.py:class SelectorDatagramTransportTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_sendfile.py:                               test_utils.TestCase):`\r\n- `test/test_asyncio/test_sendfile.py:                                 test_utils.TestCase):`\r\n- `test/test_asyncio/test_sendfile.py:                                   test_utils.TestCase):`\r\n- `test/test_asyncio/test_sendfile.py:                                  test_utils.TestCase):`\r\n- `test/test_asyncio/test_sendfile.py:                                 test_utils.TestCase):`\r\n- `test/test_asyncio/test_sendfile.py:                               test_utils.TestCase):`\r\n- `test/test_asyncio/test_sock_lowlevel.py:                               test_utils.TestCase):`\r\n- `test/test_asyncio/test_sock_lowlevel.py:                                 test_utils.TestCase):`\r\n- `test/test_asyncio/test_sock_lowlevel.py:                                   test_utils.TestCase):`\r\n- `test/test_asyncio/test_sock_lowlevel.py:                                  test_utils.TestCase):`\r\n- `test/test_asyncio/test_sock_lowlevel.py:                                 test_utils.TestCase):`\r\n- `test/test_asyncio/test_sock_lowlevel.py:                               test_utils.TestCase):`\r\n- `test/test_asyncio/test_ssl.py:class TestSSL(test_utils.TestCase):`\r\n- `test/test_asyncio/test_sslproto.py:class SslProtoHandshakeTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_streams.py:class StreamTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_subprocess.py:class SubprocessTransportTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_subprocess.py:                                         test_utils.TestCase):`\r\n- `test/test_asyncio/test_subprocess.py:                                          test_utils.TestCase):`\r\n- `test/test_asyncio/test_subprocess.py:                                     test_utils.TestCase):`\r\n- `test/test_asyncio/test_subprocess.py:                                     test_utils.TestCase):`\r\n- `test/test_asyncio/test_subprocess.py:                                      test_utils.TestCase):`\r\n- `test/test_asyncio/test_subprocess.py:    class SubprocessProactorTests(SubprocessMixin, test_utils.TestCase):`\r\n- `test/test_asyncio/test_tasks.py:                          test_utils.TestCase):`\r\n- `test/test_asyncio/test_tasks.py:class CTask_CFuture_SubclassTests(BaseTaskTests, test_utils.TestCase):`\r\n- `test/test_asyncio/test_tasks.py:class CTaskSubclass_PyFuture_Tests(BaseTaskTests, test_utils.TestCase):`\r\n- `test/test_asyncio/test_tasks.py:class PyTask_CFutureSubclass_Tests(BaseTaskTests, test_utils.TestCase):`\r\n- `test/test_asyncio/test_tasks.py:class CTask_PyFuture_Tests(BaseTaskTests, test_utils.TestCase):`\r\n- `test/test_asyncio/test_tasks.py:class PyTask_CFuture_Tests(BaseTaskTests, test_utils.TestCase):`\r\n- `test/test_asyncio/test_tasks.py:                            test_utils.TestCase):`\r\n- `test/test_asyncio/test_tasks.py:class PyTask_PyFuture_SubclassTests(BaseTaskTests, test_utils.TestCase):`\r\n- `test/test_asyncio/test_tasks.py:class CTask_Future_Tests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_tasks.py:class PyIntrospectionTests(test_utils.TestCase, BaseTaskIntrospectionTests):`\r\n- `test/test_asyncio/test_tasks.py:class CIntrospectionTests(test_utils.TestCase, BaseTaskIntrospectionTests):`\r\n- `test/test_asyncio/test_tasks.py:class PyCurrentLoopTests(BaseCurrentLoopTests, test_utils.TestCase):`\r\n- `test/test_asyncio/test_tasks.py:class CCurrentLoopTests(BaseCurrentLoopTests, test_utils.TestCase):`\r\n- `test/test_asyncio/test_tasks.py:class GenericTaskTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_tasks.py:class FutureGatherTests(GatherTestsBase, test_utils.TestCase):`\r\n- `test/test_asyncio/test_tasks.py:class CoroutineGatherTests(GatherTestsBase, test_utils.TestCase):`\r\n- `test/test_asyncio/test_tasks.py:class RunCoroutineThreadsafeTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_tasks.py:class SleepTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_tasks.py:class CompatibilityTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_unix_events.py:class SelectorEventLoopSignalTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_unix_events.py:class SelectorEventLoopUnixSocketTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_unix_events.py:class SelectorEventLoopUnixSockSendfileTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_unix_events.py:class UnixReadPipeTransportTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_unix_events.py:class UnixWritePipeTransportTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_unix_events.py:class SafeChildWatcherTests (ChildWatcherTestsMixin, test_utils.TestCase):`\r\n- `test/test_asyncio/test_unix_events.py:class FastChildWatcherTests (ChildWatcherTestsMixin, test_utils.TestCase):`\r\n- `test/test_asyncio/test_windows_events.py:class ProactorLoopCtrlC(test_utils.TestCase):`\r\n- `test/test_asyncio/test_windows_events.py:class ProactorMultithreading(test_utils.TestCase):`\r\n- `test/test_asyncio/test_windows_events.py:class ProactorTests(test_utils.TestCase):`\r\n- `test/test_asyncio/test_windows_events.py:class WinPolicyTests(test_utils.TestCase):`\r\n\u003c/details\u003e\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-98877\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/arhadthedev","@type":"Person","name":"arhadthedev"},"datePublished":"2022-05-30T16:35:28.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/93357/cpython/issues/93357"}