René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Expand logging filter API to allow returning a LogRecord","articleBody":"**Feature or enhancement**\r\n\r\nThe current API for filters is `(record: LogRecord) -\u003e bool` (really truthy/falsy return not necessarily a `bool`).\r\nI would like to propose that we change the API to be `(record: LogRecord) -\u003e bool | LogRecord`.\r\n\r\n**Pitch**\r\n\r\nCurrently logging filters are the only way to hook into the logging system to enrich or otherwise modify log records, but they are limited by the fact that you have to modify a log record in place, thus propagating this change in everywhere, even if you only want to apply this change to a specific handler or logger.\r\n\r\nIf the filterer returns a log record, it is indicating that that the reference to the log record passed in as an argument should be replaced with this log record (which may be the same instance or a completely new instance) _and_ that logging should continue.\r\n\r\nAn example filter might look like:\r\n\r\n```python\r\ndef replace_message(record: logging.LogRecord):\r\n    return logging.LogRecord(\r\n        name=record.name,\r\n        level=record.levelno,\r\n        pathname=record.pathname,\r\n        lineno=record.lineno,\r\n        msg=\"new message!\",\r\n        exc_info=record.exc_info,\r\n        args=(),\r\n    )\r\n```\r\n\r\nYou could then apply this filter to only 1 out of 2 handlers, which would result in one handler always logging `\"new message!\"` and the other being unaffected by the change.\r\n\r\n**Previous discussion**\r\n\r\nhttps://discuss.python.org/t/expand-logging-filter-api-to-allow-returning-a-logrecord/15621\r\n\r\n**Cons of this proposal**\r\n\r\n1. There is no good API for creating or copying a `LogRecord`, so it ends up being a bit verbose to do so.\r\n2. This doesn't really help or apply to filters installed on `logging.Logger` since those are run only for the logger that was called (and hence modifying modifying the `LogRecord` in place is no different from returning a new instance in most real world scenarios).","author":{"url":"https://github.com/adriangb","@type":"Person","name":"adriangb"},"datePublished":"2022-05-10T03:33:54.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/92592/cpython/issues/92592"}