Title: make patchcheck: Allow Tabs in Some Cases · Issue #92266 · python/cpython · GitHub
Open Graph Title: make patchcheck: Allow Tabs in Some Cases · Issue #92266 · python/cpython
X Title: make patchcheck: Allow Tabs in Some Cases · Issue #92266 · python/cpython
Description: Currently Tools/patchcheck/reindent.py1 replaces all tabs with spaces. However, in Tools/c-analyzer/cpython._parser.py there are embedded tab-based tables. Up to now I've basically ignored CI failures (from make patchcheck) in _parser.py...
Open Graph Description: Currently Tools/patchcheck/reindent.py1 replaces all tabs with spaces. However, in Tools/c-analyzer/cpython._parser.py there are embedded tab-based tables. Up to now I've basically ignored CI failu...
X Description: Currently Tools/patchcheck/reindent.py1 replaces all tabs with spaces. However, in Tools/c-analyzer/cpython._parser.py there are embedded tab-based tables. Up to now I've basically ignored CI f...
Opengraph URL: https://github.com/python/cpython/issues/92266
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"make patchcheck: Allow Tabs in Some Cases","articleBody":"Currently Tools/patchcheck/reindent.py[^1] replaces all tabs with spaces. However, in Tools/c-analyzer/cpython._parser.py there are embedded tab-based tables. Up to now I've basically ignored CI failures (from `make patchcheck`) in _parser.py, but I'd rather reindent.py be a little smarter (even if just a whitelist). [^2] Tools/scripts/untabify.py sounds like it may have a similar story.\r\n\r\n[^1]: `reindent.check()` is used by Tools/patchcheck/patchcheck.py (AKA `make patchcheck`).\r\n[^2]: Addressing trailing-tabs-in-str-literals is even more relevant since I enabled the check-c-globals CI check. For example, see https://github.com/python/cpython/pull/102735#issuecomment-1470516458.\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-135983\n* gh-135984\n* gh-136035\n* gh-136036\n* gh-137622\n* gh-139411\n* gh-139466\n* gh-139718\n* gh-139760\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/ericsnowcurrently","@type":"Person","name":"ericsnowcurrently"},"datePublished":"2022-05-03T21:10:09.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/92266/cpython/issues/92266"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f827d46e-d487-5b11-61fc-5407adc8b7d6 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B6A6:21FEDA:92439A:CAAD2E:696A83A3 |
| html-safe-nonce | 977352053639cc79e04cc92aee573170ea07f9173c524153fe9ecf20f5a4e562 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkE2OjIxRkVEQTo5MjQzOUE6Q0FBRDJFOjY5NkE4M0EzIiwidmlzaXRvcl9pZCI6IjY1NjkzNDg1MTYxOTI4Nzk1MjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 6fdf3e0fc2631b54a2bab29f3f93b8788723eeb9711e3a04fc9e9f7b4b091c91 |
| hovercard-subject-tag | issue:1224659196 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/92266/issue_layout |
| twitter:image | https://opengraph.githubassets.com/608a20b96cafdb0e653d54701cbe19338914730fde7fc9df6e9690f2f9d38c87/python/cpython/issues/92266 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/608a20b96cafdb0e653d54701cbe19338914730fde7fc9df6e9690f2f9d38c87/python/cpython/issues/92266 |
| og:image:alt | Currently Tools/patchcheck/reindent.py1 replaces all tabs with spaces. However, in Tools/c-analyzer/cpython._parser.py there are embedded tab-based tables. Up to now I've basically ignored CI failu... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ericsnowcurrently |
| hostname | github.com |
| expected-hostname | github.com |
| None | 913560fa317c3c5a71e34f9b19253c9f09d02b4b958a86c2a56f4c8541116377 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5998c30593994bf2589055aef7b22d368a499367 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width