René's URL Explorer Experiment


Title: make patchcheck: Allow Tabs in Some Cases · Issue #92266 · python/cpython · GitHub

Open Graph Title: make patchcheck: Allow Tabs in Some Cases · Issue #92266 · python/cpython

X Title: make patchcheck: Allow Tabs in Some Cases · Issue #92266 · python/cpython

Description: Currently Tools/patchcheck/reindent.py1 replaces all tabs with spaces. However, in Tools/c-analyzer/cpython._parser.py there are embedded tab-based tables. Up to now I've basically ignored CI failures (from make patchcheck) in _parser.py...

Open Graph Description: Currently Tools/patchcheck/reindent.py1 replaces all tabs with spaces. However, in Tools/c-analyzer/cpython._parser.py there are embedded tab-based tables. Up to now I've basically ignored CI failu...

X Description: Currently Tools/patchcheck/reindent.py1 replaces all tabs with spaces. However, in Tools/c-analyzer/cpython._parser.py there are embedded tab-based tables. Up to now I've basically ignored CI f...

Opengraph URL: https://github.com/python/cpython/issues/92266

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"make patchcheck: Allow Tabs in Some Cases","articleBody":"Currently Tools/patchcheck/reindent.py[^1] replaces all tabs with spaces.  However, in Tools/c-analyzer/cpython._parser.py there are embedded tab-based tables.  Up to now I've basically ignored CI failures (from `make patchcheck`) in _parser.py, but I'd rather reindent.py be a little smarter (even if just a whitelist). [^2]  Tools/scripts/untabify.py sounds like it may have a similar story.\r\n\r\n[^1]: `reindent.check()` is used by Tools/patchcheck/patchcheck.py (AKA `make patchcheck`).\r\n[^2]: Addressing trailing-tabs-in-str-literals is even more relevant since I enabled the check-c-globals CI check.  For example, see https://github.com/python/cpython/pull/102735#issuecomment-1470516458.\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-135983\n* gh-135984\n* gh-136035\n* gh-136036\n* gh-137622\n* gh-139411\n* gh-139466\n* gh-139718\n* gh-139760\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/ericsnowcurrently","@type":"Person","name":"ericsnowcurrently"},"datePublished":"2022-05-03T21:10:09.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/92266/cpython/issues/92266"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:f827d46e-d487-5b11-61fc-5407adc8b7d6
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB6A6:21FEDA:92439A:CAAD2E:696A83A3
html-safe-nonce977352053639cc79e04cc92aee573170ea07f9173c524153fe9ecf20f5a4e562
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkE2OjIxRkVEQTo5MjQzOUE6Q0FBRDJFOjY5NkE4M0EzIiwidmlzaXRvcl9pZCI6IjY1NjkzNDg1MTYxOTI4Nzk1MjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6fdf3e0fc2631b54a2bab29f3f93b8788723eeb9711e3a04fc9e9f7b4b091c91
hovercard-subject-tagissue:1224659196
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/92266/issue_layout
twitter:imagehttps://opengraph.githubassets.com/608a20b96cafdb0e653d54701cbe19338914730fde7fc9df6e9690f2f9d38c87/python/cpython/issues/92266
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/608a20b96cafdb0e653d54701cbe19338914730fde7fc9df6e9690f2f9d38c87/python/cpython/issues/92266
og:image:altCurrently Tools/patchcheck/reindent.py1 replaces all tabs with spaces. However, in Tools/c-analyzer/cpython._parser.py there are embedded tab-based tables. Up to now I've basically ignored CI failu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameericsnowcurrently
hostnamegithub.com
expected-hostnamegithub.com
None913560fa317c3c5a71e34f9b19253c9f09d02b4b958a86c2a56f4c8541116377
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5998c30593994bf2589055aef7b22d368a499367
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/92266#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F92266
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F92266
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/92266
Reloadhttps://github.com/python/cpython/issues/92266
Reloadhttps://github.com/python/cpython/issues/92266
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/92266
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/92266
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/92266
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/92266
make patchcheck: Allow Tabs in Some Caseshttps://github.com/python/cpython/issues/92266#top
buildThe build process and cross-buildhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22build%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com/ericsnowcurrently
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
on May 3, 2022https://github.com/python/cpython/issues/92266#issue-1224659196
1https://github.com/python/cpython/issues/92266#user-content-fn-1-d49eb5228573982be0ee4e0809f94d05
2https://github.com/python/cpython/issues/92266#user-content-fn-2-d49eb5228573982be0ee4e0809f94d05
gh-92266: Replace tabs with four spaces in Python files #135983https://github.com/python/cpython/pull/135983
gh-92266: reindent.py: Add allowlist for files with tabs #135984https://github.com/python/cpython/pull/135984
[3.14] gh-92266: Replace tabs with four spaces in Python files (GH-135983) #136035https://github.com/python/cpython/pull/136035
[3.13] gh-92266: Replace tabs with four spaces in Python files (GH-135983) #136036https://github.com/python/cpython/pull/136036
GH-92266: Remove embedded tabs from c-analyzer/cpython/_parser.py #137622https://github.com/python/cpython/pull/137622
gh-92266: Update pre-commit #139411https://github.com/python/cpython/pull/139411
[3.14] gh-92266: Update pre-commit (GH-139411) #139466https://github.com/python/cpython/pull/139466
[3.14] GH-92266: Remove embedded tabs from c-analyzer/cpython/_parser.py (GH-137622) #139718https://github.com/python/cpython/pull/139718
[3.13] gh-92266: Update pre-commit (GH-139411) #139760https://github.com/python/cpython/pull/139760
https://github.com/python/cpython/issues/92266#user-content-fnref-1-d49eb5228573982be0ee4e0809f94d05
https://github.com/python/cpython/pull/102735#issuecomment-1470516458https://github.com/python/cpython/pull/102735#issuecomment-1470516458
https://github.com/python/cpython/issues/92266#user-content-fnref-2-d49eb5228573982be0ee4e0809f94d05
buildThe build process and cross-buildhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22build%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.