René's URL Explorer Experiment


Title: Zipfile module doesn't replace `os.altsep` in filenames in some cases · Issue #92184 · python/cpython · GitHub

Open Graph Title: Zipfile module doesn't replace `os.altsep` in filenames in some cases · Issue #92184 · python/cpython

X Title: Zipfile module doesn't replace `os.altsep` in filenames in some cases · Issue #92184 · python/cpython

Description: The zipfile module currently doesn't replace os.altsep with / in filename in cases where os.altsep is not None and not "/". I'm not currently aware of any cases where os.altsep is not None or "/", so I don't think this is currently causi...

Open Graph Description: The zipfile module currently doesn't replace os.altsep with / in filename in cases where os.altsep is not None and not "/". I'm not currently aware of any cases where os.altsep is not None or "/", ...

X Description: The zipfile module currently doesn't replace os.altsep with / in filename in cases where os.altsep is not None and not "/". I'm not currently aware of any cases where os.altsep is...

Opengraph URL: https://github.com/python/cpython/issues/92184

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Zipfile module doesn't replace `os.altsep` in filenames in some cases","articleBody":"The zipfile module currently doesn't replace `os.altsep` with `/` in filename in cases where `os.altsep` is not `None` and not `\"/\"`.\r\n\r\nI'm not currently aware of any cases where `os.altsep` is not `None` or `\"/\"`, so I don't think this is currently causing any issues, but it's at least not consistent with [the documentation](https://docs.python.org/3/library/os.html#os.altsep) which states that `os.altsep` is \"An alternative character used by the operating system to separate pathname components\".\r\n\r\nTo reproduce the issue, the code below manually sets `os.sep` and `os.altsep` to be the normal Windows values, then swaps them. This should have no effect on the resulting zip file since the values should both be treated as valid path separators.\r\n\r\n```python\r\nimport io\r\nimport ntpath\r\nimport os\r\nimport zipfile\r\n\r\ndef show_zip():\r\n    zf = zipfile.ZipFile(io.BytesIO(), 'w')\r\n    zf.writestr(\"a/b/\", \"\")\r\n    zf.writestr(\"a/b\\\\\", \"\")\r\n    zf.writestr(\"a\\\\b/\", \"\")\r\n    zf.writestr(\"a\\\\b\\\\\", \"\")\r\n    print([x.filename for x in zf.infolist()])\r\n\r\nos.sep = ntpath.sep\r\nos.altsep = ntpath.altsep\r\nshow_zip()\r\n\r\nos.altsep, os.sep = os.sep, os.altsep\r\nshow_zip()\r\n```\r\n\r\nExpected output:\r\n```\r\n['a/b/', 'a/b/', 'a/b/', 'a/b/']\r\n['a/b/', 'a/b/', 'a/b/', 'a/b/']\r\n```\r\n\r\nActual output:\r\n```\r\n['a/b/', 'a/b/', 'a/b/', 'a/b/']\r\n['a/b/', 'a/b\\\\', 'a\\\\b/', 'a\\\\b\\\\']\r\n```\r\n\r\nEnvironment: `Python 3.11.0a7+ (heads/main:56f9844014, May  2 2022, 15:22:18) [Clang 11.0.0 (clang-1100.0.33.17)] on darwin`\r\n\r\n\u003c!-- gh-linked-prs --\u003e\r\n### Linked PRs\r\n* gh-92185\r\n\u003c!-- /gh-linked-prs --\u003e\r\n","author":{"url":"https://github.com/pR0Ps","@type":"Person","name":"pR0Ps"},"datePublished":"2022-05-02T20:13:51.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/92184/cpython/issues/92184"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:d55dbdff-53f6-dcaf-3fa2-b5099f7ebaf8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB214:2DA0A8:8F6F0C:C0B8C1:6969BE87
html-safe-nonce5dcfad02f02d103c94b5237d3ef28b06585a2f4619cb0e2b16d77408891fa198
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjE0OjJEQTBBODo4RjZGMEM6QzBCOEMxOjY5NjlCRTg3IiwidmlzaXRvcl9pZCI6IjczMDA5MjQxNzI3NTk4NDI0MzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1f749020e9e624189662248780c300fecf33de24db31b7f9c58150a9a205a47b
hovercard-subject-tagissue:1223311561
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/92184/issue_layout
twitter:imagehttps://opengraph.githubassets.com/43ce49025ca808cb60b0347c00c59221a422e470f2dd2d97070011919f396875/python/cpython/issues/92184
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/43ce49025ca808cb60b0347c00c59221a422e470f2dd2d97070011919f396875/python/cpython/issues/92184
og:image:altThe zipfile module currently doesn't replace os.altsep with / in filename in cases where os.altsep is not None and not "/". I'm not currently aware of any cases where os.altsep is not None or "/", ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepR0Ps
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/92184#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F92184
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F92184
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/92184
Reloadhttps://github.com/python/cpython/issues/92184
Reloadhttps://github.com/python/cpython/issues/92184
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/92184
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/92184
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/92184
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/92184
#92185https://github.com/python/cpython/pull/92185
Zipfile module doesn't replace os.altsep in filenames in some caseshttps://github.com/python/cpython/issues/92184#top
#92185https://github.com/python/cpython/pull/92185
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/pR0Ps
https://github.com/pR0Ps
pR0Pshttps://github.com/pR0Ps
on May 2, 2022https://github.com/python/cpython/issues/92184#issue-1223311561
the documentationhttps://docs.python.org/3/library/os.html#os.altsep
GH-92184: Convert os.altsep to '/' in filenames when creating ZipInfo objects #92185https://github.com/python/cpython/pull/92185
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
Zipfile issueshttps://github.com/orgs/python/projects/7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.