René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"speed up urllib.request.getproxies_environment","articleBody":"\r\nin module urllib.request，  function getproxies_environment （https://github.com/python/cpython/blob/main/Lib/urllib/request.py#L2493）\r\n\r\niterate over all environment variables  twice\r\n\r\nI made a test:\r\n1. create 2500 environment variables\r\n2. call and timing getproxies_environment()\r\n3. the result is: getproxies_environment() take more than 50ms, which is a big overhead \r\n\r\nso if there are many environment variables(like 10 thousands) in a machine,  packages depend on function urllib.request.getproxies_environment (like requests does) shall be very slow\r\n\r\nis 10 thousands environment variables reasonable？\r\n\r\nyes it is, for example, in k8s cluster，kubelete may add a set of environment variables all Services(could be 10 thousands even 100 thousands),  in purpose of service discovery \r\n\r\nso would it be ok that getproxies_environment don't iterate over all environment  variables? \r\n\r\n\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-108771\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/bohea","@type":"Person","name":"bohea"},"datePublished":"2022-04-14T15:30:17.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/91539/cpython/issues/91539"}