René's URL Explorer Experiment


Title: free-threaded: setiter_iternext releases the set once per racing thread · Issue #160573 · python/cpython · GitHub

Open Graph Title: free-threaded: setiter_iternext releases the set once per racing thread · Issue #160573 · python/cpython

X Title: free-threaded: setiter_iternext releases the set once per racing thread · Issue #160573 · python/cpython

Description: setiter_iternext reads the set before taking the critical section and then clears it outside the critical section, so every thread that reaches the exhausted branch decrements the same set. Objects/setobject.c:1098 reads PySetObject *so ...

Open Graph Description: setiter_iternext reads the set before taking the critical section and then clears it outside the critical section, so every thread that reaches the exhausted branch decrements the same set. Objects...

X Description: setiter_iternext reads the set before taking the critical section and then clears it outside the critical section, so every thread that reaches the exhausted branch decrements the same set. Objects...

Opengraph URL: https://github.com/python/cpython/issues/160573

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"free-threaded: setiter_iternext releases the set once per racing thread","articleBody":"`setiter_iternext` reads the set before taking the critical section and then clears it outside the critical section, so every thread that reaches the exhausted branch decrements the same set.\n\n- `Objects/setobject.c:1098` reads `PySetObject *so = si->si_set;` unlocked.\n- `1100` `if (so == NULL) return NULL;` lets every racing thread through, because `si_set` is still set at that point.\n- `1113-1124` the critical section covers only the table scan.\n- `1126-1129` clears `si->si_set` and calls `Py_DECREF(so)` after `Py_END_CRITICAL_SECTION()`.\n\nEight threads that arrive together each hold a non-NULL `so` and each run one decrement, so the set loses seven references it should not.\n\nReproduction on an unmodified Py_DEBUG free-threading build (`3.16.0a1+dev free-threading build`, main at 53b0004):\n\n```python\nimport sys, threading\nN = 300000\ns = set(range(N))\nfor i in range(1, N):\n    s.discard(i)          # one element, 299,999 dummy entries\nkeep = [s] * 1000         # extra decrefs must not free the set\nbase = sys.getrefcount(s)\nit = iter(s); next(it)\nbarrier = threading.Barrier(8)\ndef worker():\n    barrier.wait()\n    try: next(it)\n    except StopIteration: pass\nfor r in range(3):\n    ts = [threading.Thread(target=worker) for _ in range(8)]\n    [t.start() for t in ts]; [t.join() for t in ts]\n    print(r, base, sys.getrefcount(s))\n```\n\nOutput:\n\n```\n0 1002 996\n1 1002 996\n2 1002 996\nPython/gc_free_threading.c:1118: validate_gc_objects: Assertion \"gc_get_refs(op) >= 0\" failed: refcount is too small\nobject address  : 0x20002375e10\nobject refcount : 995\nobject type name: set\nobject repr     : {0}\n\nFatal Python error: _PyObject_AssertFailed: _PyObject_AssertFailed\nPython runtime state: finalizing (tstate=0x00005f29df1515f0)\n```\n\nexit status 134.\n\nThis is a sample from one run. The final count lands at 995 or 996 depending on how many of the eight threads lose a reference (six or seven); the abort itself is stable across runs. Rounds 1 and 2 are flat because `si_set` is already NULL by then. The process aborts while finalizing, and the object it complains about is the set itself.\n\nThe large table is what makes the window wide enough to hit. The scan after the unlocked read takes long enough for all eight threads to pass the `so == NULL` check. With a one-element set the same eight-thread barrier loop ran 31,020 rounds on the same build with no hit.\n\nThis has the same shape as the dict iterator in gh-154130. #144356 covers the `setiter_len` length hint only, and I did not find a report for the `iternext` path.\n\nClearing `si->si_set` inside the critical section at 1113-1124 and decref'ing after `Py_END_CRITICAL_SECTION()` would make the release happen once. Treating `si_set` like `di_dict`, with `_Py_XGetRef` and an atomic exchange, is the other route.\n\nI have the harness that produced this (`repros/set_iter_double_release.py`, with an instrumented build that counts second releases) if it is useful.\n\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-160619\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/scrieve","@type":"Person","name":"scrieve"},"datePublished":"2026-10-24T06:29:42Z","url":"https://github.com/python/cpython/issues/160573"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:cfee8dd1-76c8-02bb-9a52-e480b594a595
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB4EC:31E99C:34F43B2:469E281:6B02025D
html-safe-nonce53a0b851118235efe8df9927191e72ad373200c5b7f57f06a1223901daf07e1d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEVDOjMxRTk5QzozNEY0M0IyOjQ2OUUyODE6NkIwMjAyNUQiLCJ2aXNpdG9yX2lkIjoiNzI1MzU4MzkxMzY3MzY4NzY0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace7d7d96b60654dec5111760be351ec4b5fda2c37e01db040c653e675347e9a27
hovercard-subject-tagissue:6010147262
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/160573/issue_layout
twitter:imagehttps://opengraph.githubassets.com/dbcacd6627f3b5594dfc1aac0ecd83c93f98ba4b47ec2eacf7a11294dfa11730/python/cpython/issues/160573
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dbcacd6627f3b5594dfc1aac0ecd83c93f98ba4b47ec2eacf7a11294dfa11730/python/cpython/issues/160573
og:image:altsetiter_iternext reads the set before taking the critical section and then clears it outside the critical section, so every thread that reaches the exhausted branch decrements the same set. Objects...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamescrieve
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/160573#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F160573
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F160573
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/160573
Reloadhttps://github.com/python/cpython/issues/160573
Reloadhttps://github.com/python/cpython/issues/160573
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/160573
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/160573
free-threaded: setiter_iternext releases the set once per racing threadhttps://github.com/python/cpython/issues/160573#top
topic-free-threadinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-free-threading%22
type-crashA hard crash of the interpreter, possibly with a core dumphttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-crash%22
https://github.com/scrieve
scrievehttps://github.com/scrieve
on Oct 24, 2026https://github.com/python/cpython/issues/160573#issue-6010147262
gh-154130https://github.com/python/cpython/issues/154130
#144356https://github.com/python/cpython/issues/144356
gh-160573: Drop the set once when a shared iterator is exhausted #160619https://github.com/python/cpython/pull/160619
https://github.com/scrieve
scrievehttps://github.com/scrieve
on Oct 24, 2026https://github.com/python/cpython/issues/160573#issuecomment-6382673417
Data race in set iterator length_hint under no-gil #144356https://github.com/python/cpython/issues/144356
gh-154130https://github.com/python/cpython/issues/154130
aiskhttps://github.com/aisk
type-crashA hard crash of the interpreter, possibly with a core dumphttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-crash%22
topic-free-threadinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-free-threading%22
on Oct 24, 2026https://github.com/python/cpython/issues/160573#event-34125284218
kumaraditya303https://github.com/kumaraditya303
on Nov 20, 2026https://github.com/python/cpython/issues/160573#event-36769968714
Merge branch 'main' into pythongh-160573-setiter-releasehttps://github.com/scrieve/cpython/commit/7e0852f3a9aa95a95f57cb1c43206f332cdac102
pythongh-160573https://github.com/python/cpython/issues/160573
7e0852fhttps://github.com/scrieve/cpython/commit/7e0852f3a9aa95a95f57cb1c43206f332cdac102
gh-160573: Drop the set once when a shared iterator is exhausted (#16…https://github.com/python/cpython/commit/1782f62e8f97b4c333c917adaae6a68f7ddec964
gh-160573https://github.com/python/cpython/issues/160573
#16…https://github.com/python/cpython/pull/160619
1782f62https://github.com/python/cpython/commit/1782f62e8f97b4c333c917adaae6a68f7ddec964
kumaraditya303https://github.com/kumaraditya303
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 20, 2026https://github.com/python/cpython/issues/160573#event-36782667922
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/160573
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/160573
topic-free-threadinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-free-threading%22
type-crashA hard crash of the interpreter, possibly with a core dumphttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-crash%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.