Title: `os.path.realpath()` on Windows misresolves a broken symlink reached through a directory symlink · Issue #160506 · python/cpython · GitHub
Open Graph Title: `os.path.realpath()` on Windows misresolves a broken symlink reached through a directory symlink · Issue #160506 · python/cpython
X Title: `os.path.realpath()` on Windows misresolves a broken symlink reached through a directory symlink · Issue #160506 · python/cpython
Description: Bug report Bug description: On Windows, os.path.realpath() returns the wrong path for a broken relative symlink when the path used to reach it goes through a symlink to a directory. ntpath._readlink_deep() joins the link target to dirnam...
Open Graph Description: Bug report Bug description: On Windows, os.path.realpath() returns the wrong path for a broken relative symlink when the path used to reach it goes through a symlink to a directory. ntpath._readlin...
X Description: Bug report Bug description: On Windows, os.path.realpath() returns the wrong path for a broken relative symlink when the path used to reach it goes through a symlink to a directory. ntpath._readlin...
Opengraph URL: https://github.com/python/cpython/issues/160506
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`os.path.realpath()` on Windows misresolves a broken symlink reached through a directory symlink","articleBody":"# Bug report\n\n### Bug description:\n\nOn Windows, `os.path.realpath()` returns the wrong path for a broken relative symlink when the path used to reach it goes through a symlink to a directory. `ntpath._readlink_deep()` joins the link target to `dirname()` of the path as given, so a `..` in the target removes the directory link's name instead of going up from the directory that contains the link. The join dates from bpo-38453 (GH-16967).\n\n`tarfile`'s `data` and `tar` extraction filters use this result to decide where a member will be written. Whoever supplies the archive can make `extractall()` create a new file outside the destination directory, in a directory that already exists, when the extracting process is able to create symlinks.\n\n```python\n# Windows, with permission to create symlinks\nimport os\nos.makedirs(r\"C:\\work\\out\")\nos.symlink(\".\", r\"C:\\work\\out\\alias\", target_is_directory=True)\nos.symlink(r\"..\\outside\\new.txt\", r\"C:\\work\\out\\link\")\nprint(os.path.realpath(r\"C:\\work\\out\\link\"))\nprint(os.path.realpath(r\"C:\\work\\out\\alias\\link\"))\n```\n\nBoth names are the same link, so both lines should be `C:\\work\\outside\\new.txt`; the second is `C:\\work\\out\\outside\\new.txt`. Opening either name for writing creates `C:\\work\\outside\\new.txt`.\n\nAn archive with the members `alias -> .`, `alias/link -> ../outside/new.txt` and a regular file `alias/link` is extracted by `extractall(r\"C:\\work\\out\", filter=\"data\")` without error and the file's content ends up in `C:\\work\\outside\\new.txt`. The same archive with the regular file named `link` raises `OutsideDestinationError`.\n\nI have not run this on Windows. The output above comes from running the Windows branch of `Lib/ntpath.py` and `Lib/tarfile.py` from main on Linux over stand-ins for the `nt` functions, and from reading the code. `test_realpath_broken_symlinks` in `test_ntpath` already asserts the textual join (`broken2`, `broken3`). gh-88102, gh-85035 and gh-110495 are related `realpath()` issues but do not cover this case.\n\n### CPython versions tested on:\n\nCPython main branch\n\n### Operating systems tested on:\n\nOther\n\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-160507\n* gh-161026\n* gh-161027\n* gh-161028\n* gh-161029\n* gh-161030\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/gpshead","@type":"Person","name":"gpshead"},"datePublished":"2026-10-23T21:18:34Z","url":"https://github.com/python/cpython/issues/160506"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:4dc0adac-2eae-1175-d2b4-debb2fa8b354 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B6AC:2E7EBB:3D9C592:4DFC187:6B020161 |
| html-safe-nonce | abffe78250774f96639f24a7f87e87db01fc15fac3b54aa4134e926cc1a2680d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkFDOjJFN0VCQjozRDlDNTkyOjRERkMxODc6NkIwMjAxNjEiLCJ2aXNpdG9yX2lkIjoiNTQ1OTE0MDY2MzIzNDkyMDgwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 188704168e19ba8c102daafa41af0ec804441a3c9f87afe09fdc7f12309c5d1c |
| hovercard-subject-tag | issue:6005595080 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/160506/issue_layout |
| twitter:image | https://opengraph.githubassets.com/98a29b746ab1610cec330afd2ba05d02952288cc8c51327ceaf62ad20f131b07/python/cpython/issues/160506 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/98a29b746ab1610cec330afd2ba05d02952288cc8c51327ceaf62ad20f131b07/python/cpython/issues/160506 |
| og:image:alt | Bug report Bug description: On Windows, os.path.realpath() returns the wrong path for a broken relative symlink when the path used to reach it goes through a symlink to a directory. ntpath._readlin... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gpshead |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width