René's URL Explorer Experiment


Title: test_str: the UCS4 adaptive search path is never exercised · Issue #160501 · python/cpython · GitHub

Open Graph Title: test_str: the UCS4 adaptive search path is never exercised · Issue #160501 · python/cpython

X Title: test_str: the UCS4 adaptive search path is never exercised · Issue #160501 · python/cpython

Description: Summary Objects/stringlib/fastsearch.h compiles adaptive_find once per character width. The UCS4 copy never ran under the entire test suite, because the only test that reaches the adaptive path, string_tests.BaseTest.test_adaptive_find, ...

Open Graph Description: Summary Objects/stringlib/fastsearch.h compiles adaptive_find once per character width. The UCS4 copy never ran under the entire test suite, because the only test that reaches the adaptive path, st...

X Description: Summary Objects/stringlib/fastsearch.h compiles adaptive_find once per character width. The UCS4 copy never ran under the entire test suite, because the only test that reaches the adaptive path, st...

Opengraph URL: https://github.com/python/cpython/issues/160501

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"test_str: the UCS4 adaptive search path is never exercised","articleBody":"## Summary\n\n`Objects/stringlib/fastsearch.h` compiles `adaptive_find` once per character\nwidth. The UCS4 copy never ran under the entire test suite, because the only test\nthat reaches the adaptive path, `string_tests.BaseTest.test_adaptive_find`, uses\nASCII strings.\n\n## Evidence\n\nCoverage from a `--coverage` build of main running the full suite\n(`./python -m test -j4`, 552 files, 52,070 tests):\n\n```text\nFunction 'ucs4lib_adaptive_find'   Lines executed:0.00% of 39\nFunction 'ucs2lib_adaptive_find'   Lines executed:66.67% of 39\nFunction 'ucs1lib_adaptive_find'   Lines executed:71.79% of 39\nFunction 'asciilib_adaptive_find'  Lines executed:79.49% of 39\n```\n\n## Why the existing test misses it\n\nThe adaptive branch is taken only when, in `Objects/stringlib/fastsearch.h:800`:\n\n- the haystack is at least 2500 characters,\n- the needle is at least 100 characters (or the haystack at least 30000),\n- the needle is at least a third of the haystack.\n\n`test_adaptive_find` meets all three, but with `'a'` and `'b'`, so the code that\nruns is the ASCII or UCS1 instantiation. Nothing in the suite builds a haystack\nthat wide-and-long out of non-BMP characters, so the UCS4 instantiation stays\ncold.\n\n## Proposal\n\nAdd a test next to `test_find` in `Lib/test/test_str.py` that repeats the same\nshape with `'\\U0001d11e'` and `'\\U0001d11f'`. With that test present,\n`ucs4lib_adaptive_find` goes from 0.00% to 89.74% of 39 lines, and the remaining\nbranches are the count and reverse-search modes, which are separate entry points.\n\nThis is a test-only change, so it does not alter behaviour. I have it ready and\nwill open a PR against this issue.\n\n### CPython versions tested on\n\nCPython main branch (3.16.0a1+)\n\n### Operating systems tested on\n\nLinux\n\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-160502\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/scrieve","@type":"Person","name":"scrieve"},"datePublished":"2026-10-23T20:47:25Z","url":"https://github.com/python/cpython/issues/160501"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:0296b4c9-80ab-b3a5-1e40-8fda75e8195a
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9AD6:1F82:3CB112:4F59B3:6B023F36
html-safe-nonce3d16303c2f385ab33d2c03fcf6b1c5193b2cb5e53eb92f118e89cc4b062901e6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUQ2OjFGODI6M0NCMTEyOjRGNTlCMzo2QjAyM0YzNiIsInZpc2l0b3JfaWQiOiI2MzEzMTY4NDkxNzAwNjk4OTM0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac35ffc1ba6f3e96666c371db50fa33570f06a6cb17ea70a7b594ac83377e8652b
hovercard-subject-tagissue:6005212469
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/160501/issue_layout
twitter:imagehttps://opengraph.githubassets.com/642d6585a4d412a4537eb542d506a5f6ae1fda4746bfda6c2ae173749abf656b/python/cpython/issues/160501
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/642d6585a4d412a4537eb542d506a5f6ae1fda4746bfda6c2ae173749abf656b/python/cpython/issues/160501
og:image:altSummary Objects/stringlib/fastsearch.h compiles adaptive_find once per character width. The UCS4 copy never ran under the entire test suite, because the only test that reaches the adaptive path, st...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamescrieve
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/160501#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F160501
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F160501
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/160501
Reloadhttps://github.com/python/cpython/issues/160501
Reloadhttps://github.com/python/cpython/issues/160501
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/160501
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/160501
test_str: the UCS4 adaptive search path is never exercisedhttps://github.com/python/cpython/issues/160501#top
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
https://github.com/scrieve
scrievehttps://github.com/scrieve
on Oct 23, 2026https://github.com/python/cpython/issues/160501#issue-6005212469
gh-160501: Test adaptive_find in fastsearch.h for all string kinds #160502https://github.com/python/cpython/pull/160502
picnixzhttps://github.com/picnixz
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
on Oct 23, 2026https://github.com/python/cpython/issues/160501#event-34090807278
scrievehttps://github.com/scrieve
on Oct 28, 2026https://github.com/python/cpython/issues/160501#event-34449352426
pythongh-160501: Cover the UCS4 adaptive search path in test_strhttps://github.com/scrieve/cpython/commit/99dda960ef1e4d2d265c2529a6f4dd36a553e18b
pythongh-160501https://github.com/python/cpython/issues/160501
99dda96https://github.com/scrieve/cpython/commit/99dda960ef1e4d2d265c2529a6f4dd36a553e18b
pythongh-160501: Cover the UCS4 adaptive search path in test_strhttps://github.com/scrieve/cpython/commit/8bc75f0d7e290161971bea32db773971af592d3f
pythongh-160501https://github.com/python/cpython/issues/160501
8bc75f0https://github.com/scrieve/cpython/commit/8bc75f0d7e290161971bea32db773971af592d3f
pythongh-160501: Cover the UCS4 adaptive search path in test_strhttps://github.com/scrieve/cpython/commit/477a465ba08c2517cf8ca495a452d20e2c9d52d8
pythongh-160501https://github.com/python/cpython/issues/160501
477a465https://github.com/scrieve/cpython/commit/477a465ba08c2517cf8ca495a452d20e2c9d52d8
pythongh-160501: Wrap the UCS4 adaptive search cases in subTesthttps://github.com/scrieve/cpython/commit/fc31458dafababfd2b32eea4e9f21a689fecdfef
pythongh-160501https://github.com/python/cpython/issues/160501
fc31458https://github.com/scrieve/cpython/commit/fc31458dafababfd2b32eea4e9f21a689fecdfef
StanFromIrelandhttps://github.com/StanFromIreland
on Nov 10, 2026https://github.com/python/cpython/issues/160501#event-35732037183
gh-160501: Test `adaptive_find` in `fastsearch.h` for all string kinds (https://github.com/python/cpython/commit/fe1c75e2efa7220141b454f356e3b1879bddafa8
gh-160501https://github.com/python/cpython/issues/160501
fe1c75ehttps://github.com/python/cpython/commit/fe1c75e2efa7220141b454f356e3b1879bddafa8
StanFromIrelandhttps://github.com/StanFromIreland
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 10, 2026https://github.com/python/cpython/issues/160501#event-35732047755
orsenthilhttps://github.com/orsenthil
on Nov 12, 2026https://github.com/python/cpython/issues/160501#event-35872105918
pythongh-160501: Test `adaptive_find` in `fastsearch.h` for all strin…https://github.com/orsenthil/cpython/commit/7e0823c287900e8232052d63f8ad382154b939dd
pythongh-160501https://github.com/python/cpython/issues/160501
7e0823chttps://github.com/orsenthil/cpython/commit/7e0823c287900e8232052d63f8ad382154b939dd
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/160501
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/160501
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.