René's URL Explorer Experiment


Title: test_sampling_with_collapsed_export fails when the profiler records an unreadable frame · Issue #160334 · python/cpython · GitHub

Open Graph Title: test_sampling_with_collapsed_export fails when the profiler records an unreadable frame · Issue #160334 · python/cpython

X Title: test_sampling_with_collapsed_export fails when the profiler records an unreadable frame · Issue #160334 · python/cpython

Description: Bug report Bug description: test_sampling_with_collapsed_export failed in the ASan job of my PR gh-160296 (the change there is in a multiprocessing test and is unrelated): FAIL: test_sampling_with_collapsed_export (test.test_profiling.te...

Open Graph Description: Bug report Bug description: test_sampling_with_collapsed_export failed in the ASan job of my PR gh-160296 (the change there is in a multiprocessing test and is unrelated): FAIL: test_sampling_with_...

X Description: Bug report Bug description: test_sampling_with_collapsed_export failed in the ASan job of my PR gh-160296 (the change there is in a multiprocessing test and is unrelated): FAIL: test_sampling_with_...

Opengraph URL: https://github.com/python/cpython/issues/160334

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"test_sampling_with_collapsed_export fails when the profiler records an unreadable frame","articleBody":"# Bug report\n\n### Bug description:\n\n`test_sampling_with_collapsed_export` failed in the ASan job of my PR gh-160296 (the change there is in a multiprocessing test and is unrelated):\n\n```\nFAIL: test_sampling_with_collapsed_export (test.test_profiling.test_sampling_profiler.test_integration.TestSampleProfilerIntegration.test_sampling_with_collapsed_export)\n----------------------------------------------------------------------\nTraceback (most recent call last):\n  File \"/home/runner/work/cpython/cpython/Lib/test/test_profiling/test_sampling_profiler/test_integration.py\", line 512, in test_sampling_with_collapsed_export\n    self.assertIn(\":\", part)\n    ~~~~~~~~~~~~~^^^^^^^^^^^\nAssertionError: ':' not found in '\u003cunreadable frame>'\n```\n\nhttps://github.com/python/cpython/actions/runs/39832455069/job/120012213367\n\nSince gh-154194, `_remote_debugging` returns a degraded frame (file `\"~\"`, no location, function `\"\u003cunreadable frame>\"`) when it cannot read a code object, instead of failing the sample. `CollapsedStackCollector` turns the `None` location into line 0, and `export()` writes frames with file `\"~\"` and line 0 as just the function name, so the collapsed line contains `\u003cunreadable frame>` with no colon. The test expects every part to look like `file:func:line`, so it fails whenever a sample hits an unreadable frame. I have only seen it on the ASan build so far.\n\ngh-154195 updated `test_binary_format.py` for the new frame, but not this test.\n\nReproducer, without a target process:\n\n```python\nimport os\nimport tempfile\nfrom profiling.sampling.stack_collector import CollapsedStackCollector\n\ncollector = CollapsedStackCollector(1000)\n# The first (innermost) frame is what _remote_debugging returns\n# when it cannot read a code object (gh-154194).\nframes = [\n    (\"~\", None, \"\u003cunreadable frame>\", None),\n    (\"/tmp/script.py\", (10, 10, 0, 1), \"main\", None),\n]\ncollector.process_frames(frames, thread_id=1)\n\nfd, path = tempfile.mkstemp(suffix=\".txt\")\nos.close(fd)\ncollector.export(path)\nwith open(path) as f:\n    line = f.read().strip()\nos.unlink(path)\n\nprint(line)\nstack_trace = line.rsplit(\" \", 1)[0]\nfor part in stack_trace.split(\";\"):\n    print(repr(part), \":\" in part)\n```\n\nOutput:\n\n```\nCollapsed stack output written to /tmp/tmp....txt\ntid:1;script.py:main:10;\u003cunreadable frame> 1\n'tid:1' True\n'script.py:main:10' True\n'\u003cunreadable frame>' False\n```\n\n`\u003cGC>` frames (on by default in `sample()`) take the same `\"~\"` branch in `export()`, so they would fail this assertion too. The test could accept these special `\u003c...>` frames instead of requiring a colon. I can open a PR if that approach is fine.\n\nThe same test and the gh-154194 change are also in 3.15.\n\n### CPython versions tested on:\n\nCPython main branch\n\n### Operating systems tested on:\n\nLinux, macOS\n\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-161515\n* gh-161686\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/devdavidejesus","@type":"Person","name":"devdavidejesus"},"datePublished":"2026-10-22T19:56:59Z","url":"https://github.com/python/cpython/issues/160334"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:7e9cfd93-c3d8-52cb-f45b-cce1c022cfb8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idEBD2:2A98A:66243F:8090DB:6B021B39
html-safe-nonce2cc08b3f3249c4b30adfcceaade33c439dc341fd08f268cc1c067ed46965ab3b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkQyOjJBOThBOjY2MjQzRjo4MDkwREI6NkIwMjFCMzkiLCJ2aXNpdG9yX2lkIjoiMzUxMTMwMDI2MzUyMjczNjk1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac31bc708f85cd8d835953710288ebe4c58282f358f02c538e385838257da86f59
hovercard-subject-tagissue:5986475764
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/160334/issue_layout
twitter:imagehttps://opengraph.githubassets.com/7b39a9f7c502607d3ca10eca86092ad9d5526655bbaef7d59436bc4aafb9c1df/python/cpython/issues/160334
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7b39a9f7c502607d3ca10eca86092ad9d5526655bbaef7d59436bc4aafb9c1df/python/cpython/issues/160334
og:image:altBug report Bug description: test_sampling_with_collapsed_export failed in the ASan job of my PR gh-160296 (the change there is in a multiprocessing test and is unrelated): FAIL: test_sampling_with_...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedevdavidejesus
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/160334#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F160334
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F160334
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/160334
Reloadhttps://github.com/python/cpython/issues/160334
Reloadhttps://github.com/python/cpython/issues/160334
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/160334
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/160334
#161515https://github.com/python/cpython/pull/161515
test_sampling_with_collapsed_export fails when the profiler records an unreadable framehttps://github.com/python/cpython/issues/160334#top
#161515https://github.com/python/cpython/pull/161515
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
topic-profilinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-profiling%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/devdavidejesus
devdavidejesushttps://github.com/devdavidejesus
on Oct 22, 2026https://github.com/python/cpython/issues/160334#issue-5986475764
gh-160296https://github.com/python/cpython/pull/160296
https://github.com/python/cpython/actions/runs/39832455069/job/120012213367https://github.com/python/cpython/actions/runs/39832455069/job/120012213367
gh-154194https://github.com/python/cpython/issues/154194
gh-154195https://github.com/python/cpython/pull/154195
gh-154194https://github.com/python/cpython/issues/154194
gh-160334: Accept special frames in collapsed profiling test #161515https://github.com/python/cpython/pull/161515
[3.15] gh-160334: Accept special frames in collapsed profiling test (GH-161515) #161686https://github.com/python/cpython/pull/161686
NekoAsakurahttps://github.com/NekoAsakura
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
topic-profilinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-profiling%22
on Oct 22, 2026https://github.com/python/cpython/issues/160334#event-33989505480
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
on Oct 23, 2026https://github.com/python/cpython/issues/160334#issuecomment-6375401881
@pablogsalhttps://github.com/pablogsal
@ivonastojanovichttps://github.com/ivonastojanovic
GriffinCanCodehttps://github.com/GriffinCanCode
on Oct 29, 2026https://github.com/python/cpython/issues/160334#event-34548708738
pythongh-160864: Retry CI after known sampling flakehttps://github.com/GriffinCanCode/cpython/commit/785af1a8d64c71309f77e4278f5dea2da8a0f92b
pythongh-160864https://github.com/python/cpython/issues/160864
785af1ahttps://github.com/GriffinCanCode/cpython/commit/785af1a8d64c71309f77e4278f5dea2da8a0f92b
raman118https://github.com/raman118
on Nov 6, 2026https://github.com/python/cpython/issues/160334#event-35386699876
pythongh-160334: Add NEWS entryhttps://github.com/raman118/cpython/commit/b5f7aaff0b8c267a4f9a89871b7ee92ce637d38c
pythongh-160334https://github.com/python/cpython/issues/160334
b5f7aafhttps://github.com/raman118/cpython/commit/b5f7aaff0b8c267a4f9a89871b7ee92ce637d38c
Merge branch 'main' into pythongh-160334-collapsed-unreadable-framehttps://github.com/raman118/cpython/commit/f0df47c295967ed5996703a961fd332426ba676c
pythongh-160334https://github.com/python/cpython/issues/160334
f0df47chttps://github.com/raman118/cpython/commit/f0df47c295967ed5996703a961fd332426ba676c
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
on Nov 9, 2026https://github.com/python/cpython/issues/160334#issuecomment-6744460271
https://github.com/devdavidejesus
devdavidejesushttps://github.com/devdavidejesus
on Nov 9, 2026https://github.com/python/cpython/issues/160334#issuecomment-6744842557
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
on Nov 9, 2026https://github.com/python/cpython/issues/160334#issuecomment-6745163356
https://github.com/devdavidejesus
devdavidejesushttps://github.com/devdavidejesus
on Nov 9, 2026https://github.com/python/cpython/issues/160334#issuecomment-6745290318
@raman118https://github.com/raman118
vstinnerhttps://github.com/vstinner
on Nov 9, 2026https://github.com/python/cpython/issues/160334#event-35589750789
gh-160334: Accept special frames in collapsed profiling test (#161515)https://github.com/python/cpython/commit/cb2eeed01697bb1a6b29e6dc582e7b172d158b1e
gh-160334https://github.com/python/cpython/issues/160334
#161515https://github.com/python/cpython/pull/161515
cb2eeedhttps://github.com/python/cpython/commit/cb2eeed01697bb1a6b29e6dc582e7b172d158b1e
vstinnerhttps://github.com/vstinner
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#161515https://github.com/python/cpython/pull/161515
on Nov 9, 2026https://github.com/python/cpython/issues/160334#event-35589751420
vstinnerhttps://github.com/vstinner
on Nov 9, 2026https://github.com/python/cpython/issues/160334#event-35593438373
[3.15] gh-160334: Accept special frames in collapsed profiling test (G…https://github.com/python/cpython/commit/f2ad76f95d3c91d94e2383b1b7a1360944f5163a
gh-160334https://github.com/python/cpython/issues/160334
G…https://github.com/python/cpython/pull/161515
f2ad76fhttps://github.com/python/cpython/commit/f2ad76f95d3c91d94e2383b1b7a1360944f5163a
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/160334
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/160334
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
topic-profilinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-profiling%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.