René's URL Explorer Experiment


Title: importlib: later import hangs forever after a RecursionError in a small-stack thread leaves a module lock held · Issue #159652 · python/cpython · GitHub

Open Graph Title: importlib: later import hangs forever after a RecursionError in a small-stack thread leaves a module lock held · Issue #159652 · python/cpython

X Title: importlib: later import hangs forever after a RecursionError in a small-stack thread leaves a module lock held · Issue #159652 · python/cpython

Description: If an import in a thread with a small stack fails with RecursionError and the exception is kept alive, the module lock it held is never released, and a later import of the same module in another thread blocks forever in _ModuleLock.acqui...

Open Graph Description: If an import in a thread with a small stack fails with RecursionError and the exception is kept alive, the module lock it held is never released, and a later import of the same module in another th...

X Description: If an import in a thread with a small stack fails with RecursionError and the exception is kept alive, the module lock it held is never released, and a later import of the same module in another th...

Opengraph URL: https://github.com/python/cpython/issues/159652

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"importlib: later import hangs forever after a RecursionError in a small-stack thread leaves a module lock held","articleBody":"If an import in a thread with a small stack fails with `RecursionError` and the exception is kept alive, the module lock it held is never released, and a later import of the same module in another thread blocks forever in `_ModuleLock.acquire`.\n\n```python\nimport threading\nthreading.stack_size(131072)\nerrors = []\ndef worker():\n    try:\n        import _colorize\n    except RecursionError as e:\n        errors.append(e)\nt = threading.Thread(target=worker)\nt.start(); t.join()\nprint(errors, flush=True)\nimport collections.abc\nprint(\"done\")\n```\n\n```\ntimeout 20 python reduced.py\n```\n\nRelease build:\n\n```\n[RecursionError('Stack overflow (used 99 kB)')]\n```\n\nIt then hangs and is killed by `timeout` (exit 124); `done` is never printed. In a variant that ends with an uncaught exception instead, so that the import that hangs is `import collections.abc` at line 3 of `Lib/traceback.py`, a faulthandler dump at 3646ea571f3d shows the main thread in `_ModuleLock.acquire` (`\u003cfrozen importlib._bootstrap>` line 359), called from `__enter__` (line 452) and `_find_and_load`.\n\nI expected `import collections.abc` to succeed, since the failed import should have released its locks. Without `errors.append(e)` the lock objects are garbage collected and nothing hangs.\n\nFound at commit 3646ea571f3d8290806a3029d555b179f8be1539; still reproduces at e5ef47e94f7c9d970ad98e2c33870ccc3b04dc5c (the release build hangs the same way). The checking build (assertions and ASAN) does not hang here: at this stack size it aborts first with ``Parser/pegen.h:120: _PyPegen_stack_exhausted: Assertion `!_Py_ReachedRecursionLimitWithMargin(p->tstate, 1)' failed`` (rc 134). The stack size that triggers the hang depends on the build; on the release build I saw it for sizes from about 124928 to 188416.\n\nThis looks like `_HierarchicalLockManager.__enter__` in `Lib/importlib/_bootstrap.py`: a lock taken by `lock.acquire()` is only appended to `self._locks` afterwards, so a `RecursionError` in that window (or in the cleanup `release()` calls) leaves it owned by the dead thread. I checked the leak itself (after the thread exits, `importlib._bootstrap._module_locks` still holds the `collections.abc` lock, owned by the dead thread); the exact line is a guess. PRs #153575 and #157413 change parser recursion depth and may be related; I did not test them, as their diffs do not apply on the latest commit.\n\nI can send a patch if that helps.\n\nFound with an LLM-based testing tool; I used Claude to reduce it and look for the cause.\n\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-159660\n* gh-160779\n* gh-160780\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/waroad","@type":"Person","name":"waroad"},"datePublished":"2026-10-17T20:37:21Z","url":"https://github.com/python/cpython/issues/159652"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:d06ced0f-1daf-fee4-0c1d-e8bed330d295
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDCFE:29AEE8:364EA07:484DE43:6B020856
html-safe-nonce7c792ca3d85bcb825819597767fb1e9e8960c16062d5c248239ece31bec69ccc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0ZFOjI5QUVFODozNjRFQTA3OjQ4NERFNDM6NkIwMjA4NTYiLCJ2aXNpdG9yX2lkIjoiNDkxODQxOTY2MDk0NjQwOTU1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac983fb1349cb8581c792f7033077cd7cc56c9b57eff4e6685611de8a6df1d1266
hovercard-subject-tagissue:5902845821
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/159652/issue_layout
twitter:imagehttps://opengraph.githubassets.com/58051e7e8d91694f289aa40025a05a6859c7b1ceae34c85b6a2f200a664b7677/python/cpython/issues/159652
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/58051e7e8d91694f289aa40025a05a6859c7b1ceae34c85b6a2f200a664b7677/python/cpython/issues/159652
og:image:altIf an import in a thread with a small stack fails with RecursionError and the exception is kept alive, the module lock it held is never released, and a later import of the same module in another th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewaroad
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/159652#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F159652
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F159652
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/159652
Reloadhttps://github.com/python/cpython/issues/159652
Reloadhttps://github.com/python/cpython/issues/159652
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/159652
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/159652
importlib: later import hangs forever after a RecursionError in a small-stack thread leaves a module lock heldhttps://github.com/python/cpython/issues/159652#top
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
topic-importlibhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-importlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/waroad
waroadhttps://github.com/waroad
on Oct 17, 2026https://github.com/python/cpython/issues/159652#issue-5902845821
3646ea5https://github.com/python/cpython/commit/3646ea571f3d8290806a3029d555b179f8be1539
3646ea5https://github.com/python/cpython/commit/3646ea571f3d8290806a3029d555b179f8be1539
e5ef47ehttps://github.com/python/cpython/commit/e5ef47e94f7c9d970ad98e2c33870ccc3b04dc5c
#153575https://github.com/python/cpython/pull/153575
#157413https://github.com/python/cpython/pull/157413
gh-159652: Fix import lock leak when the C stack is nearly exhausted #159660https://github.com/python/cpython/pull/159660
[3.15] gh-159652: Fix import lock leak when the C stack is nearly exhausted (GH-159660) #160779https://github.com/python/cpython/pull/160779
[3.14] gh-159652: Fix import lock leak when the C stack is nearly exhausted (GH-159660) #160780https://github.com/python/cpython/pull/160780
picnixzhttps://github.com/picnixz
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
topic-importlibhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-importlib%22
on Oct 17, 2026https://github.com/python/cpython/issues/159652#event-33540183032
cjames23https://github.com/cjames23
on Oct 18, 2026https://github.com/python/cpython/issues/159652#event-33561472374
pythongh-159652: Fix import lock leak when the C stack is nearly exha…https://github.com/cjames23/cpython/commit/0d0da4ae9f752b1cb5774c89031cde0ccc82ac62
pythongh-159652https://github.com/python/cpython/issues/159652
0d0da4ahttps://github.com/cjames23/cpython/commit/0d0da4ae9f752b1cb5774c89031cde0ccc82ac62
kevinprimeraquecreo-stackhttps://github.com/kevinprimeraquecreo-stack
Project_VKhttps://github.com/users/kevinprimeraquecreo-stack/projects/1
Project_VKhttps://github.com/users/kevinprimeraquecreo-stack/projects/1
on Oct 18, 2026https://github.com/python/cpython/issues/159652#event-33592184977
github-project-automationhttps://github.com/apps/github-project-automation
Project_VKhttps://github.com/users/kevinprimeraquecreo-stack/projects/1
on Oct 18, 2026https://github.com/python/cpython/issues/159652
cjames23https://github.com/cjames23
on Oct 18, 2026https://github.com/python/cpython/issues/159652#event-33593120592
Merge branch 'main' into pythongh-159652-import-lock-stackhttps://github.com/cjames23/cpython/commit/3efad1517afe08624d4d375868177366432c178b
pythongh-159652https://github.com/python/cpython/issues/159652
3efad15https://github.com/cjames23/cpython/commit/3efad1517afe08624d4d375868177366432c178b
brettcannonhttps://github.com/brettcannon
on Oct 27, 2026https://github.com/python/cpython/issues/159652#event-34415547905
gh-159652: Fix import lock leak when the C stack is nearly exhausted (G…https://github.com/python/cpython/commit/926b0bf3110bf86550ef248cf911e24fc123ec64
gh-159652https://github.com/python/cpython/issues/159652
G…https://github.com/python/cpython/pull/159660
926b0bfhttps://github.com/python/cpython/commit/926b0bf3110bf86550ef248cf911e24fc123ec64
[3.14] gh-159652: Fix import lock leak when the C stack is nearly exh…https://github.com/python/cpython/commit/48b1e6026b7853913e60c2bc917c6c1ea6307d75
gh-159652https://github.com/python/cpython/issues/159652
48b1e60https://github.com/python/cpython/commit/48b1e6026b7853913e60c2bc917c6c1ea6307d75
[3.15] gh-159652: Fix import lock leak when the C stack is nearly exh…https://github.com/python/cpython/commit/e60e7bdc92a493338aa89599099df5e9d39bc078
gh-159652https://github.com/python/cpython/issues/159652
e60e7bdhttps://github.com/python/cpython/commit/e60e7bdc92a493338aa89599099df5e9d39bc078
hugovkhttps://github.com/hugovk
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 28, 2026https://github.com/python/cpython/issues/159652#event-34473376550
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/159652
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/159652
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
topic-importlibhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-importlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.