René's URL Explorer Experiment


Title: `marshal.dumps()` crashes when a set is modified while it is being marshalled · Issue #159185 · python/cpython · GitHub

Open Graph Title: `marshal.dumps()` crashes when a set is modified while it is being marshalled · Issue #159185 · python/cpython

X Title: `marshal.dumps()` crashes when a set is modified while it is being marshalled · Issue #159185 · python/cpython

Description: Crash report To sort the elements of a set, w_complex_object() reads the size of the set, allocates a list of that size, then marshals each element on its own in a loop. Marshalling an element can run Python code (an element's __buffer__...

Open Graph Description: Crash report To sort the elements of a set, w_complex_object() reads the size of the set, allocates a list of that size, then marshals each element on its own in a loop. Marshalling an element can ...

X Description: Crash report To sort the elements of a set, w_complex_object() reads the size of the set, allocates a list of that size, then marshals each element on its own in a loop. Marshalling an element can ...

Opengraph URL: https://github.com/python/cpython/issues/159185

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`marshal.dumps()` crashes when a set is modified while it is being marshalled","articleBody":"### Crash report\n\nTo sort the elements of a set, `w_complex_object()` reads the size of the\nset, allocates a list of that size, then marshals each element on its own\nin a loop.  Marshalling an element can run Python code (an element's\n`__buffer__`, an audit hook), and that code can change the set.  If the set\ngrows, the loop writes past the end of the list.  If it shrinks, the list\nis left with NULL items and is then sorted.\n\n```python\nimport marshal, sys\n\nclass Item:\n    def __hash__(self):\n        return 0\n    def __buffer__(self, flags):\n        if sys.argv[1] == 'grow':\n            s.update(range(1000, 1400))\n        else:\n            s.difference_update(range(1, 60))\n        return memoryview(b'abc')\n\ns = {Item()}\ns.update(range(1, 60))\nmarshal.dumps(s)\n```\n\nOn main:\n\n- `shrink`, release build: segmentation fault.\n- `grow`, release build: no error; writes past the list allocation.\n- `grow`, debug build:\n  `PyList_SET_ITEM: Assertion 'index \u003c list->allocated' failed.`\n\nOn the free-threaded build another thread changing the set between the size\nread and the critical section has the same effect.\n\n### Proposed fix\n\nStop the loop at the size that was read, and raise\n`RuntimeError(\"set changed size during iteration\")` if the number of\nelements seen differs from it, as iterating a set does.\n\n---\n\nDiscovered using Claude while doing a deep dive on pyc compilation determinism.\n\n### CPython versions tested on:\n\nCPython main branch\n\n### Operating systems tested on:\n\n_No response_\n\n### Output from running 'python -VV' on the command line:\n\n_No response_\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-159195\n* gh-159199\n* gh-159200\n* gh-159201\n* gh-159202\n* gh-159203\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/gpshead","@type":"Person","name":"gpshead"},"datePublished":"2026-10-11T17:37:37Z","url":"https://github.com/python/cpython/issues/159185"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:f9388def-89b1-7294-aac6-4f54b0d28b09
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDD3E:17FB7:313BF7F:3E76A25:6B02013E
html-safe-nonce5feface213ae36a741f11bdc1fca20cdf5fb1ec0246cb8b9516c7126aef8ab9a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDNFOjE3RkI3OjMxM0JGN0Y6M0U3NkEyNTo2QjAyMDEzRSIsInZpc2l0b3JfaWQiOiI2ODQ3MTkwODI2NzcxMTUzMjE0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2e342b4175aabb2fdc6deff85bfbb02a3e671b1b2fc0accb881a2bd2424ca1cf
hovercard-subject-tagissue:5803499548
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/159185/issue_layout
twitter:imagehttps://opengraph.githubassets.com/390d90c60c79afe45bc88e31a23246151368e8e818e8bdcb26d0c10ab255da75/python/cpython/issues/159185
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/390d90c60c79afe45bc88e31a23246151368e8e818e8bdcb26d0c10ab255da75/python/cpython/issues/159185
og:image:altCrash report To sort the elements of a set, w_complex_object() reads the size of the set, allocates a list of that size, then marshals each element on its own in a loop. Marshalling an element can ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegpshead
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/159185#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F159185
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F159185
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/159185
Reloadhttps://github.com/python/cpython/issues/159185
Reloadhttps://github.com/python/cpython/issues/159185
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/159185
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/159185
marshal.dumps() crashes when a set is modified while it is being marshalledhttps://github.com/python/cpython/issues/159185#top
https://github.com/gpshead
3.14bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.14%22
3.15bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.15%22
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
type-crashA hard crash of the interpreter, possibly with a core dumphttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-crash%22
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
on Oct 11, 2026https://github.com/python/cpython/issues/159185#issue-5803499548
gh-159185: Fix marshalling of a set modified while its elements are marshalled #159195https://github.com/python/cpython/pull/159195
[3.15] gh-159185: Fix marshalling of a set modified while its elements are marshalled (GH-159195) #159199https://github.com/python/cpython/pull/159199
[3.14] gh-159185: Fix marshalling of a set modified while its elements are marshalled (GH-159195) #159200https://github.com/python/cpython/pull/159200
gh-159185: Document that PyMarshal_WriteObjectToFile can silently truncate before 3.16 #159201https://github.com/python/cpython/pull/159201
[3.15] gh-159185: Document that PyMarshal_WriteObjectToFile can silently truncate before 3.16 (GH-159201) #159202https://github.com/python/cpython/pull/159202
[3.14] gh-159185: Document that PyMarshal_WriteObjectToFile can silently truncate before 3.16 (GH-159201) #159203https://github.com/python/cpython/pull/159203
gpsheadhttps://github.com/gpshead
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-crashA hard crash of the interpreter, possibly with a core dumphttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-crash%22
on Oct 11, 2026https://github.com/python/cpython/issues/159185#event-32996169093
gpsheadhttps://github.com/gpshead
on Oct 11, 2026https://github.com/python/cpython/issues/159185#event-32996889131
StanFromIrelandhttps://github.com/StanFromIreland
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
on Oct 11, 2026https://github.com/python/cpython/issues/159185#event-32997208535
gpsheadhttps://github.com/gpshead
on Oct 11, 2026https://github.com/python/cpython/issues/159185#event-33003855813
gh-159185: Fix marshalling of a set modified while its elements are m…https://github.com/python/cpython/commit/cd71799c47802f87e1469cc97cc99f5ce6cea27c
gh-159185https://github.com/python/cpython/issues/159185
cd71799https://github.com/python/cpython/commit/cd71799c47802f87e1469cc97cc99f5ce6cea27c
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
on Oct 11, 2026https://github.com/python/cpython/issues/159185#issuecomment-6113941925
gh-156942https://github.com/python/cpython/issues/156942
gh-155907https://github.com/python/cpython/issues/155907
gpsheadhttps://github.com/gpshead
3.14bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.14%22
3.15bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.15%22
on Oct 11, 2026https://github.com/python/cpython/issues/159185#event-33004450833
gpsheadhttps://github.com/gpshead
on Oct 11, 2026https://github.com/python/cpython/issues/159185#event-33005326858
gh-159185: Document that PyMarshal_WriteObjectToFile can silently tru…https://github.com/python/cpython/commit/b3714a5fb7a3aadd72134ee0710b22519c1df09a
gh-159185https://github.com/python/cpython/issues/159185
b3714a5https://github.com/python/cpython/commit/b3714a5fb7a3aadd72134ee0710b22519c1df09a
[3.14] gh-159185: Fix marshalling of a set modified while its element…https://github.com/python/cpython/commit/09e1e663c98cfabe9843ea41e7b85da206e75eda
gh-159185https://github.com/python/cpython/issues/159185
09e1e66https://github.com/python/cpython/commit/09e1e663c98cfabe9843ea41e7b85da206e75eda
[3.15] gh-159185: Fix marshalling of a set modified while its element…https://github.com/python/cpython/commit/4c2433f310b19460b6b69ceb05100a07c3154fc1
gh-159185https://github.com/python/cpython/issues/159185
4c2433fhttps://github.com/python/cpython/commit/4c2433f310b19460b6b69ceb05100a07c3154fc1
[3.15] gh-159185: Document that PyMarshal_WriteObjectToFile can silen…https://github.com/python/cpython/commit/9ad86052ece309e34e496829ba8588f6e6d69ba0
gh-159185https://github.com/python/cpython/issues/159185
9ad8605https://github.com/python/cpython/commit/9ad86052ece309e34e496829ba8588f6e6d69ba0
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
on Oct 11, 2026https://github.com/python/cpython/issues/159185#issuecomment-6114272607
gpsheadhttps://github.com/gpshead
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 11, 2026https://github.com/python/cpython/issues/159185#event-33005588818
gpsheadhttps://github.com/gpshead
on Oct 11, 2026https://github.com/python/cpython/issues/159185#event-33005604698
[3.14] gh-159185: Document that PyMarshal_WriteObjectToFile can silen…https://github.com/python/cpython/commit/f8a48fb3dfe7413ae39d39c82a8b6f1ef1d0dfef
gh-159185https://github.com/python/cpython/issues/159185
f8a48fbhttps://github.com/python/cpython/commit/f8a48fb3dfe7413ae39d39c82a8b6f1ef1d0dfef
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/159185
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/159185
gpsheadhttps://github.com/gpshead
3.14bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.14%22
3.15bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.15%22
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
type-crashA hard crash of the interpreter, possibly with a core dumphttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-crash%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.