René's URL Explorer Experiment


Title: profiling.sampling incorrectly handles base_frame and native frame as the first frame · Issue #157605 · python/cpython · GitHub

Open Graph Title: profiling.sampling incorrectly handles base_frame and native frame as the first frame · Issue #157605 · python/cpython

X Title: profiling.sampling incorrectly handles base_frame and native frame as the first frame · Issue #157605 · python/cpython

Description: Bug description profiling.sampling does not correctly handle some frame chains whose first frame is not a Python frame. There are two cases: The first frame is base_frame A native thread can retain a Python thread state while waiting in ...

Open Graph Description: Bug description profiling.sampling does not correctly handle some frame chains whose first frame is not a Python frame. There are two cases: The first frame is base_frame A native thread can retain...

X Description: Bug description profiling.sampling does not correctly handle some frame chains whose first frame is not a Python frame. There are two cases: The first frame is base_frame A native thread can retain...

Opengraph URL: https://github.com/python/cpython/issues/157605

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"profiling.sampling incorrectly handles base_frame and native frame as the first frame","articleBody":"## Bug description\n\n`profiling.sampling` does not correctly handle some frame chains whose first frame is not a Python frame.\n\nThere are two cases:\n\n1. **The first frame is `base_frame`**\n\n   A native thread can retain a Python thread state while waiting in C code, with no Python functions executing. Its frame chain contains only the `base_frame` sentinel.\n\n   The sampler skips this sentinel and then raises:\n\n   `RuntimeError: Failed to parse initial frame in chain`\n\n2. **The first frame is a native frame**\n\n   When the first frame in the chain is a native frame, the sampler does not correctly handle it as the initial frame and may report the frame chain as invalid instead of adding a `\u003cnative>` frame.\n\nIn both cases, the failure can cause the entire sampling call to fail, so valid Python stacks from other threads are also lost.\n\n## Reproduction\n\n### Case 1: `base_frame` as the first frame\n\nCreate a pthread that registers and detaches a Python thread state:\n\n```c\nPyGILState_STATE state = PyGILState_Ensure();\nPyThreadState *saved = PyEval_SaveThread();\n\n/* Wait on a pthread condition variable while the parent samples. */\n\n/* Cleanup after sampling. */\nPyEval_RestoreThread(saved);\nPyGILState_Release(state);\n```\n\nKeep the main thread inside a Python function and sample the child process from its parent:\n\n```python\nunwinder = _remote_debugging.RemoteUnwinder(\n    pid, all_threads=True, cache_frames=False,\n)\nunwinder.get_stack_trace()\n```\n\n[tachyon-empty-native-repro.zip](https://github.com/user-attachments/files/32418460/tachyon-empty-native-repro.zip)\n\n- Reproduces with frame caching both enabled and disabled.\n\n### Case 2: Native frame as the first frame\n\nConstruct a frame chain whose current frame is a native frame and whose `previous` frame leads to `base_frame`.\n\nWhen native-frame collection is enabled, sampling this thread currently fails to correctly handle the native frame as the first frame.\n\n## Expected behavior\n\nThe sampler should correctly handle both cases:\n\n1. If the first frame is `base_frame`, treat it as a valid empty Python stack.\n2. If the first frame is a native frame, add a `\u003cnative>` frame to the returned stack and continue walking the frame chain.\n\nA special frame state in one thread should not cause the entire sampling operation to fail or prevent valid stacks from other threads from being returned.\n\n## Suspected cause\n\n`process_frame_chain()` does not correctly handle cases where the first frame does not contain a parseable Python frame, including `base_frame` and native frames.\n\nThese cases can be incorrectly treated as a broken initial frame chain.\n\n## Environment\n\nLinux, CPython 3.15.0rc2+dev free-threaded build and current `main`.\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-157817\n* gh-161784\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/liuzhijie-0614","@type":"Person","name":"liuzhijie-0614"},"datePublished":"2026-09-16T03:07:14Z","url":"https://github.com/python/cpython/issues/157605"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:910cc43d-fa70-0290-4b10-6bf4f851e016
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDCE2:14EB6E:1A2593B:22567F2:6B0211D6
html-safe-nonce6decd9a796d7b37fe1cad2f59909dac29406ae9aa0b74c7925fd169eeb518d75
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0UyOjE0RUI2RToxQTI1OTNCOjIyNTY3RjI6NkIwMjExRDYiLCJ2aXNpdG9yX2lkIjoiMTA2NDQ4NTgzMTk3MDAwMTM2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac93652b4c3167810d74900c78c252e6abbd0c50e8d533169b1a8789a738f3da96
hovercard-subject-tagissue:5469752374
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/157605/issue_layout
twitter:imagehttps://opengraph.githubassets.com/0a61f249b69075842159b122f1127fa1e65cc51ed2d85db0841a48d039d0d60e/python/cpython/issues/157605
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0a61f249b69075842159b122f1127fa1e65cc51ed2d85db0841a48d039d0d60e/python/cpython/issues/157605
og:image:altBug description profiling.sampling does not correctly handle some frame chains whose first frame is not a Python frame. There are two cases: The first frame is base_frame A native thread can retain...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameliuzhijie-0614
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/157605#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F157605
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F157605
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/157605
Reloadhttps://github.com/python/cpython/issues/157605
Reloadhttps://github.com/python/cpython/issues/157605
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/157605
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/157605
profiling.sampling incorrectly handles base_frame and native frame as the first framehttps://github.com/python/cpython/issues/157605#top
extension-modulesC modules in the Modules dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22extension-modules%22
topic-profilinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-profiling%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/liuzhijie-0614
liuzhijie-0614https://github.com/liuzhijie-0614
on Sep 16, 2026https://github.com/python/cpython/issues/157605#issue-5469752374
tachyon-empty-native-repro.ziphttps://github.com/user-attachments/files/32418460/tachyon-empty-native-repro.zip
gh-157605: Accept empty native-thread stacks when sampling #157817https://github.com/python/cpython/pull/157817
[3.15] gh-157605: Accept empty native-thread stacks when sampling #161784https://github.com/python/cpython/pull/161784
aiskhttps://github.com/aisk
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
extension-modulesC modules in the Modules dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22extension-modules%22
topic-profilinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-profiling%22
on Sep 16, 2026https://github.com/python/cpython/issues/157605#event-31225637939
aidaodedjlhttps://github.com/aidaodedjl
on Sep 17, 2026https://github.com/python/cpython/issues/157605#event-31295682657
pythongh-157605: Fix regression test include dirs for out-of-tree buildshttps://github.com/aidaodedjl/cpython/commit/1a923f1bb9c40a0f7853928334b9fd290ae988b1
pythongh-157605https://github.com/python/cpython/issues/157605
1a923f1https://github.com/aidaodedjl/cpython/commit/1a923f1bb9c40a0f7853928334b9fd290ae988b1
pythongh-157605: Handle a native first frame like a mid-chain native …https://github.com/aidaodedjl/cpython/commit/c39b4bcb6a98d454dfa02017c05ff78abdc07e70
pythongh-157605https://github.com/python/cpython/issues/157605
c39b4bchttps://github.com/aidaodedjl/cpython/commit/c39b4bcb6a98d454dfa02017c05ff78abdc07e70
pythongh-157605: Cover native-first frames with a regression testhttps://github.com/aidaodedjl/cpython/commit/ddcd747a48752c80a1390bf2550c5cb28cfefeaa
pythongh-157605https://github.com/python/cpython/issues/157605
ddcd747https://github.com/aidaodedjl/cpython/commit/ddcd747a48752c80a1390bf2550c5cb28cfefeaa
pythongh-157605: Discriminate code-less frames by owner fieldhttps://github.com/aidaodedjl/cpython/commit/c3a001665556332fce5faf44c158a700ddb03621
pythongh-157605https://github.com/python/cpython/issues/157605
c3a0016https://github.com/aidaodedjl/cpython/commit/c3a001665556332fce5faf44c158a700ddb03621
pythongh-157605: Skip dropped frames and keep walking the live caller…https://github.com/aidaodedjl/cpython/commit/2c58f5715e89909ecc27863e5c38f083f6d95067
pythongh-157605https://github.com/python/cpython/issues/157605
2c58f57https://github.com/aidaodedjl/cpython/commit/2c58f5715e89909ecc27863e5c38f083f6d95067
liuzhijie-0614https://github.com/liuzhijie-0614
on Sep 19, 2026https://github.com/python/cpython/issues/157605#event-31449639339
https://github.com/liuzhijie-0614
liuzhijie-0614https://github.com/liuzhijie-0614
on Sep 19, 2026https://github.com/python/cpython/issues/157605#issuecomment-5743208903
gh-157657https://github.com/python/cpython/pull/157657
@pablogsalhttps://github.com/pablogsal
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
on Sep 19, 2026https://github.com/python/cpython/issues/157605#issuecomment-5743266794
#157657https://github.com/python/cpython/pull/157657
https://devguide.python.org/getting-started/ai-tools/https://devguide.python.org/getting-started/ai-tools/
https://github.com/liuzhijie-0614
liuzhijie-0614https://github.com/liuzhijie-0614
on Sep 19, 2026https://github.com/python/cpython/issues/157605#issuecomment-5743300663
#157657https://github.com/python/cpython/pull/157657
https://devguide.python.org/getting-started/ai-tools/https://devguide.python.org/getting-started/ai-tools/
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
on Sep 19, 2026https://github.com/python/cpython/issues/157605#issuecomment-5743315003
#157657https://github.com/python/cpython/pull/157657
devguide.python.org/getting-started/ai-toolshttps://devguide.python.org/getting-started/ai-tools/
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
on Sep 19, 2026https://github.com/python/cpython/issues/157605#issuecomment-5743343561
https://github.com/liuzhijie-0614
liuzhijie-0614https://github.com/liuzhijie-0614
on Sep 19, 2026https://github.com/python/cpython/issues/157605#issuecomment-5743377397
tachyon-empty-native-repro.ziphttps://github.com/user-attachments/files/32418371/tachyon-empty-native-repro.zip
pablogsalhttps://github.com/pablogsal
on Sep 19, 2026https://github.com/python/cpython/issues/157605#event-31454589996
pythongh-157605: Accept empty native-thread stacks when samplinghttps://github.com/pablogsal/cpython/commit/2c982a227e1afd157fd6503e8a9175235a92be7d
pythongh-157605https://github.com/python/cpython/issues/157605
2c982a2https://github.com/pablogsal/cpython/commit/2c982a227e1afd157fd6503e8a9175235a92be7d
https://github.com/liuzhijie-0614
liuzhijie-0614https://github.com/liuzhijie-0614
on Sep 20, 2026https://github.com/python/cpython/issues/157605#issuecomment-5747233306
@pablogsalhttps://github.com/pablogsal
flamegraph.htmlhttps://github.com/user-attachments/files/32428391/flamegraph.html
https://github.com/liuzhijie-0614
liuzhijie-0614https://github.com/liuzhijie-0614
on Sep 20, 2026https://github.com/python/cpython/issues/157605#issuecomment-5748472418
pablogsalhttps://github.com/pablogsal
on Sep 22, 2026https://github.com/python/cpython/issues/157605#event-31628431550
pythongh-157605: Accept empty native-thread stacks when samplinghttps://github.com/pablogsal/cpython/commit/fa197507318948294e1a1c2feb3fe06c2c5e6c00
pythongh-157605https://github.com/python/cpython/issues/157605
fa19750https://github.com/pablogsal/cpython/commit/fa197507318948294e1a1c2feb3fe06c2c5e6c00
pythongh-157605: Accept empty native-thread stacks when samplinghttps://github.com/pablogsal/cpython/commit/8aec82f55795125937b9c1fa24fb343a2c379ec5
pythongh-157605https://github.com/python/cpython/issues/157605
8aec82fhttps://github.com/pablogsal/cpython/commit/8aec82f55795125937b9c1fa24fb343a2c379ec5
pythongh-157605: Distinguish C frames from cleared Python frameshttps://github.com/pablogsal/cpython/commit/d26597389c1e5fa48453ec7ea5f70c1f5661d022
pythongh-157605https://github.com/python/cpython/issues/157605
d265973https://github.com/pablogsal/cpython/commit/d26597389c1e5fa48453ec7ea5f70c1f5661d022
pythongh-157605: Distinguish C frames from cleared Python frameshttps://github.com/pablogsal/cpython/commit/6cc82bb8389cef99def5f0762566976fa192e255
pythongh-157605https://github.com/python/cpython/issues/157605
6cc82bbhttps://github.com/pablogsal/cpython/commit/6cc82bb8389cef99def5f0762566976fa192e255
pythongh-157605: Distinguish C frames from cleared Python frameshttps://github.com/pablogsal/cpython/commit/e37e929b8347bd0bd5fc7f83f9077d6eb68fd0bc
pythongh-157605https://github.com/python/cpython/issues/157605
e37e929https://github.com/pablogsal/cpython/commit/e37e929b8347bd0bd5fc7f83f9077d6eb68fd0bc
gh-157605: Accept empty native-thread stacks when samplinghttps://github.com/python/cpython/commit/80f9aa0b18d96509eec3950a8db4324d5f6dc3a5
gh-157605https://github.com/python/cpython/issues/157605
80f9aa0https://github.com/python/cpython/commit/80f9aa0b18d96509eec3950a8db4324d5f6dc3a5
liuzhijie-0614https://github.com/liuzhijie-0614
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 1, 2026https://github.com/python/cpython/issues/157605#event-32224090043
https://github.com/brondsem
brondsemhttps://github.com/brondsem
on Nov 10, 2026https://github.com/python/cpython/issues/157605#issuecomment-6775373214
80f9aa0https://github.com/python/cpython/commit/80f9aa0b18d96509eec3950a8db4324d5f6dc3a5
pablogsalhttps://github.com/pablogsal
on Nov 20, 2026https://github.com/python/cpython/issues/157605#event-36773157726
pythongh-157605: Accept empty native-thread stacks when samplinghttps://github.com/miss-islington/cpython/commit/ac9e996c52e25afe11a73cca41fe083cc60c58c0
pythongh-157605https://github.com/python/cpython/issues/157605
ac9e996https://github.com/miss-islington/cpython/commit/ac9e996c52e25afe11a73cca41fe083cc60c58c0
[3.15] gh-157605: Accept empty native-thread stacks when sampling (#1…https://github.com/python/cpython/commit/35710a5cac0f953f77aae5d0002d00110b47b568
gh-157605https://github.com/python/cpython/issues/157605
#1…https://github.com/python/cpython/pull/161784
35710a5https://github.com/python/cpython/commit/35710a5cac0f953f77aae5d0002d00110b47b568
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/157605
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/157605
extension-modulesC modules in the Modules dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22extension-modules%22
topic-profilinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-profiling%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.