René's URL Explorer Experiment


Title: marshal replaces the exception raised while writing with a generic ValueError · Issue #156942 · python/cpython · GitHub

Open Graph Title: marshal replaces the exception raised while writing with a generic ValueError · Issue #156942 · python/cpython

X Title: marshal replaces the exception raised while writing with a generic ValueError · Issue #156942 · python/cpython

Description: Bug report The marshal writer does not raise an exception where the error occurs: it records an error code in WFILE.error and converts it into an exception at the end, in w_set_exception(). If an exception was already raised, it is repla...

Open Graph Description: Bug report The marshal writer does not raise an exception where the error occurs: it records an error code in WFILE.error and converts it into an exception at the end, in w_set_exception(). If an e...

X Description: Bug report The marshal writer does not raise an exception where the error occurs: it records an error code in WFILE.error and converts it into an exception at the end, in w_set_exception(). If an e...

Opengraph URL: https://github.com/python/cpython/issues/156942

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"marshal replaces the exception raised while writing with a generic ValueError","articleBody":"# Bug report\n\nThe marshal writer does not raise an exception where the error occurs: it records an error code in `WFILE.error` and converts it into an exception at the end, in `w_set_exception()`. If an exception was already raised, it is replaced with a generic one, and not even chained:\n\n```pycon\n>>> t = ([],)\n>>> t[0].append(t)\n>>> marshal.dumps(t)\nValueError: unmarshallable object\n```\n\nThe message raised in `w_ref()` is `cannot marshal recursion tuple objects`. Also lost are `BufferError` for a non-contiguous buffer, the exception raised while marshalling a set item, and `MemoryError` from `PyUnicode_AsEncodedString()` or `PyLong_Export()`. A failure of `PyList_Sort()`, which sorts set items, is reported as `MemoryError`, although the sorting fails with `TypeError`.\n\nFinally, `ValueError(\"unmarshallable object\")` is used for all unsupported values, including those which are only unsupported in the requested version.\n\nI propose to raise the exception where the error is detected, and keep in `WFILE` only a flag saying that an exception has been raised. This removes `w_set_exception()` and all error codes except one, propagates the original exception, and allows more specific messages:\n\n```pycon\n>>> marshal.dumps(marshal)\nValueError: cannot marshal module objects\n>>> marshal.dumps(slice(1), 4)\nValueError: marshalling slice objects requires version 5 or higher\n```\n\nValues which are too large get `object too large to marshal` and `int too large to marshal`. `\"unmarshallable object\"` disappears, so the code which matches it needs to be updated.\n\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-156944\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/serhiy-storchaka","@type":"Person","name":"serhiy-storchaka"},"datePublished":"2026-09-04T14:44:54Z","url":"https://github.com/python/cpython/issues/156942"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:49d8edce-303b-1082-29b1-b0091b3d3c52
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id82D2:1FE434:17FE4B1:1FA638F:6B0209D7
html-safe-nonce145854eab7c2304a87952ca8a97ba14df11c27c82f1893b33cf8fc4bcf77deaf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkQyOjFGRTQzNDoxN0ZFNEIxOjFGQTYzOEY6NkIwMjA5RDciLCJ2aXNpdG9yX2lkIjoiNjMxNjcyNjc5OTA5MDk3NzIzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace3ceea939cdc79c52a8c026a0bef052309690a0e035302cb4383c9f17be0c903
hovercard-subject-tagissue:5349489884
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/156942/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d92634636395bcfc5959c0dea08144e0416f1286e17810ae86c543e49ba05d20/python/cpython/issues/156942
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d92634636395bcfc5959c0dea08144e0416f1286e17810ae86c543e49ba05d20/python/cpython/issues/156942
og:image:altBug report The marshal writer does not raise an exception where the error occurs: it records an error code in WFILE.error and converts it into an exception at the end, in w_set_exception(). If an e...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameserhiy-storchaka
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/156942#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F156942
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F156942
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/156942
Reloadhttps://github.com/python/cpython/issues/156942
Reloadhttps://github.com/python/cpython/issues/156942
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/156942
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/156942
marshal replaces the exception raised while writing with a generic ValueErrorhttps://github.com/python/cpython/issues/156942#top
3.16new features, bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.16%22
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
on Sep 4, 2026https://github.com/python/cpython/issues/156942#issue-5349489884
gh-156942: Raise the exception where the marshalling error is detected #156944https://github.com/python/cpython/pull/156944
serhiy-storchakahttps://github.com/serhiy-storchaka
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
3.16new features, bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.16%22
on Sep 4, 2026https://github.com/python/cpython/issues/156942#event-30561405920
picnixzhttps://github.com/picnixz
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
on Sep 6, 2026https://github.com/python/cpython/issues/156942#event-30642600345
serhiy-storchakahttps://github.com/serhiy-storchaka
on Sep 18, 2026https://github.com/python/cpython/issues/156942#event-31405545220
gh-156942: Raise the exception where the marshalling error is detected (https://github.com/python/cpython/commit/76f22f9cf2f8a822f1c428ffdcb060b914e66b67
gh-156942https://github.com/python/cpython/issues/156942
76f22f9https://github.com/python/cpython/commit/76f22f9cf2f8a822f1c428ffdcb060b914e66b67
serhiy-storchakahttps://github.com/serhiy-storchaka
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 18, 2026https://github.com/python/cpython/issues/156942#event-31408126910
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/156942
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/156942
3.16new features, bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.16%22
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.