Title: Improve performance of inherited mapping assignment slot calls · Issue #156250 · python/cpython · GitHub
Open Graph Title: Improve performance of inherited mapping assignment slot calls · Issue #156250 · python/cpython
X Title: Improve performance of inherited mapping assignment slot calls · Issue #156250 · python/cpython
Description: Feature or enhancement Proposal: __setitem__ and __delitem__ share the mp_ass_subscript slot. If a Python subclass of a C mapping overrides only one of them, slot_mp_ass_subscript() is used for both operations. For example, collections.C...
Open Graph Description: Feature or enhancement Proposal: __setitem__ and __delitem__ share the mp_ass_subscript slot. If a Python subclass of a C mapping overrides only one of them, slot_mp_ass_subscript() is used for bot...
X Description: Feature or enhancement Proposal: __setitem__ and __delitem__ share the mp_ass_subscript slot. If a Python subclass of a C mapping overrides only one of them, slot_mp_ass_subscript() is used for bot...
Opengraph URL: https://github.com/python/cpython/issues/156250
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Improve performance of inherited mapping assignment slot calls","articleBody":"# Feature or enhancement\n\n### Proposal:\n\n`__setitem__` and `__delitem__` share the `mp_ass_subscript` slot. If a Python subclass of a C mapping overrides only one of them, `slot_mp_ass_subscript()` is used for both operations.\n\nFor example, `collections.Counter` overrides `__delitem__` but inherits `dict.__setitem__`. Assigning an item looks up the inherited `wrapper_descriptor` and calls it through the generic `tp_call` path. Since `PyWrapperDescr_Type` does not support vectorcall, `_PyObject_MakeTpCall()` and `wrapperdescr_call()` each create a temporary argument tuple before reaching `dict`'s C slot.\n\nReproducer:\n\n```python\nfrom collections import Counter\nfrom time import perf_counter_ns\n\nobj = Counter()\n\nstart = perf_counter_ns()\nfor index in range(20_000_000):\n obj[0] = index\n\nprint((perf_counter_ns() - start) / 1_000_000)\n```\n\nOn macOS 15.7.1 arm64 with a release build of main (`d856402e7176e5a03c5c578f0efc1be968be3257`), using two warmups and nine alternating-order samples:\n\n```text\nmain: 1402.07 ms median (1376.93–1445.12 ms)\nprototype: 859.97 ms median (846.24–902.74 ms)\n```\n\nThe prototype calls the inherited C slot directly when lookup returns the expected unbound mapping slot wrapper, and otherwise keeps the existing call path. This reduced the benchmark time by 38.66%.\n\nThe relevant call-path files are unchanged at `b062727097e997bcb900e11503d3248daac903da`.\n\n### Has this already been discussed elsewhere?\n\nThis is a minor feature, which does not need previous discussion elsewhere\n\n### Links to previous discussion of this feature:\n\n_No response_\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-156258\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/koxudaxi","@type":"Person","name":"koxudaxi"},"datePublished":"2026-08-23T04:14:36Z","url":"https://github.com/python/cpython/issues/156250"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:ae51b766-84f4-7f5b-6192-1189fbfba32b |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | ED1E:A71F9:2D88058:39A9344:6B01EF09 |
| html-safe-nonce | 4d4c6dfc478472809372133325118c20595e7fc61f698097c728d7a162a1d10b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDFFOkE3MUY5OjJEODgwNTg6MzlBOTM0NDo2QjAxRUYwOSIsInZpc2l0b3JfaWQiOiI3NjA4MjQ5NTQ0MDM5NTkxNjg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 86397012c007dbac4b58240cc97ff33c617f2059206f493ccb5db2194aa9b42a |
| hovercard-subject-tag | issue:5225265193 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/156250/issue_layout |
| twitter:image | https://opengraph.githubassets.com/fe870443cc10799758379e5d35dd41ff1472f2089270c82a4a0aac4b2e0eddc4/python/cpython/issues/156250 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fe870443cc10799758379e5d35dd41ff1472f2089270c82a4a0aac4b2e0eddc4/python/cpython/issues/156250 |
| og:image:alt | Feature or enhancement Proposal: __setitem__ and __delitem__ share the mp_ass_subscript slot. If a Python subclass of a C mapping overrides only one of them, slot_mp_ass_subscript() is used for bot... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | koxudaxi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width