René's URL Explorer Experiment


Title: Types with `mro()` unconditionally disables type attribute cache, causing performance regression for compatible MRO implementations, such as Zope · Issue #156096 · python/cpython · GitHub

Open Graph Title: Types with `mro()` unconditionally disables type attribute cache, causing performance regression for compatible MRO implementations, such as Zope · Issue #156096 · python/cpython

X Title: Types with `mro()` unconditionally disables type attribute cache, causing performance regression for compatible MRO implementations, such as Zope · Issue #156096 · python/cpython

Description: Bug report Bug description: Since #127773 / #127924, any type whose metaclass defines a custom mro() method has its type attribute cache permanently disabled. This was made initially to fix a problem with metaclasses defining mro() to in...

Open Graph Description: Bug report Bug description: Since #127773 / #127924, any type whose metaclass defines a custom mro() method has its type attribute cache permanently disabled. This was made initially to fix a probl...

X Description: Bug report Bug description: Since #127773 / #127924, any type whose metaclass defines a custom mro() method has its type attribute cache permanently disabled. This was made initially to fix a probl...

Opengraph URL: https://github.com/python/cpython/issues/156096

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Types with `mro()` unconditionally disables type attribute cache, causing performance regression for compatible MRO implementations, such as Zope","articleBody":"# Bug report\n\n### Bug description:\n\n\nSince https://github.com/python/cpython/issues/127773 / https://github.com/python/cpython/pull/127924, any type whose metaclass defines a custom `mro()` method has its type attribute cache permanently disabled. This was made initially to fix a problem with metaclasses defining `mro()` to inject new bases that are not in the class bases.\n\nThis affects [Zope's ExtensionClass](https://github.com/zopefoundation/ExtensionClass), used as base class for most classes the Zope ecosystem. This package has 5000 daily downloads on pypi ( https://pypistats.org/packages/extensionclass ). ExtensionClass defines a custom `mro()`, but only to *reorganizes* bases that are already bases of the class, which is different from the scenario from the issue and it looks like a case where the cache could still be used.\n\nCompared to python3.11, this seems to causes a ~3x performance regression for attribute lookups on all zope classes:\n\n```\n$ uv run --python=3.11 --with Zope python -m timeit -s 'import OFS.Folder; f = OFS.Folder.Folder(\"f\")' 'f.getId'\n2000000 loops, best of 5: 116 nsec per loop\n$ uv run --python=3.14 --with Zope python -m timeit -s 'import OFS.Folder; f = OFS.Folder.Folder(\"f\")' 'f.getId'\n500000 loops, best of 5: 399 nsec per loop\n```\n\nit's hard to tell how much this affect applications, this is just a micro benchmark, but we are also observing that running ERP5 test suites (a complex application based on zope) is slower on python3.13 than it was on python3.11.\n\n## Analysis\n\nIn `type_mro_modified()`, the check `has_custom_mro(type)` unconditionally jumps to `clear:` \n\nhttps://github.com/python/cpython/blob/af49df919dafc3767ae956767dce0482f9cd6d4e/Objects/typeobject.c#L1261-L1262\n\nwhich sets `tp_versions_used = _Py_ATTR_CACHE_UNUSED`, whenever the metaclass overrides `mro()`:\n\nhttps://github.com/python/cpython/blob/af49df919dafc3767ae956767dce0482f9cd6d4e/Objects/typeobject.c#L1279-L1283\n\n\nThis was introduced to fix https://github.com/python/cpython/issues/127773, where a custom `mro()` that injects a class not in `tp_bases` (e.g. `Base`) causes stale cache entries because `PyType_Modified()` only propagates through `tp_subclasses`, not through MRO-only relationships.\n\nAlthough these are not much relevant here, ExtensionClass's `mro` is implemented in C as [`_ExtensionClass.c:569-626`](https://github.com/zopefoundation/ExtensionClass/blob/26e99ca69077016c518ef82bddf66c57475035ed/src/ExtensionClass/_ExtensionClass.c#L569-L626) and also has an equivalent pure-python implementation in [`ExtensionClass.__init__.py:181-200`](https://github.com/zopefoundation/ExtensionClass/blob/26e99ca69077016c518ef82bddf66c57475035ed/src/ExtensionClass/__init__.py#L181-L200).\n\n\n\n## Suggested fix\n\nCheck whether the custom MRO actually contains non-base entries before disabling the cache. This requires an `is_superclass()` helper that walks `tp_bases` (not `tp_mro`) to determine reachability:\n\n```c\n// Return true if `super` is reachable from `sub` through `tp_bases`,\n// as opposed to a type merely injected into the MRO by a custom `mro()`\n// implementation.  Only entries reachable through `tp_bases` are covered\n// by the version-tag invalidation that _PyType_Modified_Unlocked()\n// propagates through `tp_subclasses`.\nstatic int\nis_superclass(PyTypeObject *super, PyTypeObject *sub)\n{\n    PyObject *bases = lookup_tp_bases(sub);\n    if (bases == NULL) {\n        return 0;\n    }\n    Py_ssize_t n = PyTuple_GET_SIZE(bases);\n    for (Py_ssize_t i = 0; i \u003c n; i++) {\n        PyTypeObject *base = _PyType_CAST(PyTuple_GET_ITEM(bases, i));\n        if (base == super || is_superclass(super, base)) {\n            return 1;\n        }\n    }\n    return 0;\n}\n```\n\nThen in `type_mro_modified`, replace the unconditional `goto clear` for custom MROs:\n\n```c\nif (!Py_IS_TYPE(type, &PyType_Type) && has_custom_mro(type)) {\n    // Only disable cache if the custom mro() injected an entry that\n    // is not reachable through tp_bases;\n    PyObject *mro = lookup_tp_mro(type);\n    if (mro == NULL) {\n        goto clear;\n    }\n    Py_ssize_t mro_size = PyTuple_GET_SIZE(mro);\n    for (Py_ssize_t m = 0; m \u003c mro_size; m++) {\n        PyTypeObject *entry = _PyType_CAST(PyTuple_GET_ITEM(mro, m));\n        if (entry != type && !is_superclass(entry, type)) {\n            goto clear;\n        }\n    }\n}\n```\n\nI'm not at all familiar with this, but it seems to me that this would preserve the correctness of https://github.com/python/cpython/pull/127924 for types that do inject non-base entries into their MRO (because cache would still be disabled for those), while restoring cache performance for compatible custom MRO implementations like Zope's ExtensionClass.\n\nIf this approach makes sense, I already have a draft commit implementing this: https://github.com/perrinjerome/cpython/commit/89af3385eb7e930466dcaef97b2d7b9286eb755e and I would be happy to clean it up and make a pull request.\n\n\n### CPython versions tested on:\n\n3.13\n\n### Operating systems tested on:\n\nLinux","author":{"url":"https://github.com/perrinjerome","@type":"Person","name":"perrinjerome"},"datePublished":"2026-08-20T10:39:56Z","url":"https://github.com/python/cpython/issues/156096"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:56bbc251-67b0-43a1-9449-cd7547ff6e57
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB322:785A9:4CA991B:60FDE69:6B025D10
html-safe-noncebc3fb2cf4b501548d39a089871ed296bfcaf1e97ab660b43aa6b0c9ab3f9bc6e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzIyOjc4NUE5OjRDQTk5MUI6NjBGREU2OTo2QjAyNUQxMCIsInZpc2l0b3JfaWQiOiI3NzMyMDgxMTYwNjQ5NTk2MTc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5b044d0844231006fa5ce1be18637a7be1cfbc19163ee9d5f05b96a6fecc4565
hovercard-subject-tagissue:5202478741
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/156096/issue_layout
twitter:imagehttps://opengraph.githubassets.com/9124b02fd5f4ee62d13edfcf07d30b1093fcc5b0e181c2dbc21de588eed0f519/python/cpython/issues/156096
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9124b02fd5f4ee62d13edfcf07d30b1093fcc5b0e181c2dbc21de588eed0f519/python/cpython/issues/156096
og:image:altBug report Bug description: Since #127773 / #127924, any type whose metaclass defines a custom mro() method has its type attribute cache permanently disabled. This was made initially to fix a probl...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameperrinjerome
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/156096#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F156096
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F156096
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/156096
Reloadhttps://github.com/python/cpython/issues/156096
Reloadhttps://github.com/python/cpython/issues/156096
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/156096
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/156096
Types with mro() unconditionally disables type attribute cache, causing performance regression for compatible MRO implementations, such as Zopehttps://github.com/python/cpython/issues/156096#top
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/perrinjerome
perrinjeromehttps://github.com/perrinjerome
on Aug 20, 2026https://github.com/python/cpython/issues/156096#issue-5202478741
#127773https://github.com/python/cpython/issues/127773
#127924https://github.com/python/cpython/pull/127924
Zope's ExtensionClasshttps://github.com/zopefoundation/ExtensionClass
https://pypistats.org/packages/extensionclasshttps://pypistats.org/packages/extensionclass
cpython/Objects/typeobject.chttps://github.com/python/cpython/blob/af49df919dafc3767ae956767dce0482f9cd6d4e/Objects/typeobject.c#L1261-L1262
af49df9https://github.com/python/cpython/commit/af49df919dafc3767ae956767dce0482f9cd6d4e
cpython/Objects/typeobject.chttps://github.com/python/cpython/blob/af49df919dafc3767ae956767dce0482f9cd6d4e/Objects/typeobject.c#L1279-L1283
af49df9https://github.com/python/cpython/commit/af49df919dafc3767ae956767dce0482f9cd6d4e
#127773https://github.com/python/cpython/issues/127773
_ExtensionClass.c:569-626https://github.com/zopefoundation/ExtensionClass/blob/26e99ca69077016c518ef82bddf66c57475035ed/src/ExtensionClass/_ExtensionClass.c#L569-L626
ExtensionClass.__init__.py:181-200https://github.com/zopefoundation/ExtensionClass/blob/26e99ca69077016c518ef82bddf66c57475035ed/src/ExtensionClass/__init__.py#L181-L200
#127924https://github.com/python/cpython/pull/127924
perrinjerome@89af338https://github.com/perrinjerome/cpython/commit/89af3385eb7e930466dcaef97b2d7b9286eb755e
perrinjeromehttps://github.com/perrinjerome
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
on Aug 20, 2026https://github.com/python/cpython/issues/156096#event-29737785900
https://github.com/perrinjerome
perrinjeromehttps://github.com/perrinjerome
on Aug 26, 2026https://github.com/python/cpython/issues/156096#issuecomment-5422993632
@encukouhttps://github.com/encukou
@colesburyhttps://github.com/colesbury
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/156096
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/156096
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.