Title: asyncio: a plain-function client_connected_cb that raises leaves the server transport open · Issue #155941 · python/cpython · GitHub
Open Graph Title: asyncio: a plain-function client_connected_cb that raises leaves the server transport open · Issue #155941 · python/cpython
X Title: asyncio: a plain-function client_connected_cb that raises leaves the server transport open · Issue #155941 · python/cpython
Description: Bug report Bug description: Bug report Bug description asyncio.start_server() accepts both coroutine and plain-function callbacks. When a coroutine callback raises, gh-110894 (gh-111601) made StreamReaderProtocol.connection_made() report...
Open Graph Description: Bug report Bug description: Bug report Bug description asyncio.start_server() accepts both coroutine and plain-function callbacks. When a coroutine callback raises, gh-110894 (gh-111601) made Strea...
X Description: Bug report Bug description: Bug report Bug description asyncio.start_server() accepts both coroutine and plain-function callbacks. When a coroutine callback raises, gh-110894 (gh-111601) made Strea...
Opengraph URL: https://github.com/python/cpython/issues/155941
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"asyncio: a plain-function client_connected_cb that raises leaves the server transport open","articleBody":"# Bug report\n\n### Bug description:\n\n# Bug report\n\n## Bug description\n\n`asyncio.start_server()` accepts both coroutine and plain-function callbacks. When a coroutine callback raises, gh-110894 (gh-111601) made `StreamReaderProtocol.connection_made()` report the error and close the transport. The plain-function branch was not covered. If the callback raises synchronously, the exception propagates out of `connection_made()` (`Lib/asyncio/streams.py`).\n\n1. **The transport is never closed.** The client sees an established connection that never answers, and the server-side connection leaks until process exit (`ResourceWarning: unclosed transport` and `unclosed socket`).\n2. **`Server.wait_closed()` hangs forever**, because the leaked connection never finishes. A failing callback breaks graceful shutdown.\n3. The error is reported with the generic `'Exception in callback StreamReaderProtocol.connection_made()'` message instead of the `'Unhandled exception in client_connected_cb'` message used by the coroutine branch.\n\nRelated: gh-155934 covers the same failure class one stage earlier in the server pipeline, an error while creating the transport for an accepted connection in `BaseSelectorEventLoop._accept_connection2()`.\n\n## Reproducer\n\n```python\nimport asyncio\n\n\nasync def main():\n loop = asyncio.get_running_loop()\n messages = []\n loop.set_exception_handler(lambda l, ctx: messages.append(ctx.get(\"message\")))\n\n def cb(reader, writer): # plain function, not async\n raise RuntimeError(\"boom in client_connected_cb\")\n\n server = await asyncio.start_server(cb, \"127.0.0.1\", 0)\n port = server.sockets[0].getsockname()[1]\n\n rd, wr = await asyncio.open_connection(\"127.0.0.1\", port)\n wr.write(b\"hello\")\n await wr.drain()\n try:\n data = await asyncio.wait_for(rd.read(), timeout=1.0)\n print(\"server closed the connection, read ->\", data)\n except ConnectionResetError:\n print(\"server closed the connection (RST, unread data was pending)\")\n except TimeoutError:\n print(\"TIMEOUT: server never closed the connection (transport left open)\")\n wr.close()\n server.close()\n try:\n await asyncio.wait_for(server.wait_closed(), timeout=1.0)\n print(\"server.wait_closed() returned\")\n except TimeoutError:\n print(\"server.wait_closed() HANGS (leaked connection keeps the server alive)\")\n print(\"exception handler messages:\", messages)\n\n\nasyncio.run(main())\n```\n\nOutput on current main:\n\n```\nTIMEOUT: server never closed the connection (transport left open)\nserver.wait_closed() HANGS (leaked connection keeps the server alive)\nexception handler messages: ['Exception in callback StreamReaderProtocol.connection_made()']\n\u003csys>:0: ResourceWarning: unclosed \u003csocket.socket fd=8, ...>\nResourceWarning: unclosed transport \u003c_SelectorSocketTransport fd=8>\n```\n\n## Suggested fix\n\nWrap the synchronous call in `connection_made()` and mirror the coroutine branch on failure. Report through the loop exception handler with the same message and close the transport. With that change the reproducer prints:\n\n```\nserver closed the connection (RST, unread data was pending)\nserver.wait_closed() returned\nexception handler messages: ['Unhandled exception in client_connected_cb']\n```\n\nI'd like to work on this as part of the PyCon KR sprint. @corona10 @hugovk \n\nFound while verifying entries from [devdanzin's stdlib audit catalog](https://gist.github.com/devd0a7b4e0768e5f) n.26\n\n### CPython versions tested on:\n\nCPython main branch\n\n### Operating systems tested on:\n\nmacOS\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-155942\n* gh-156273\n* gh-156274\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/danielKim614","@type":"Person","name":"danielKim614"},"datePublished":"2026-08-17T07:15:48Z","url":"https://github.com/python/cpython/issues/155941"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:af8d36f4-c0a5-3ffb-913f-4b74d7ad5c26 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 95F8:CE438:16E035E:1E775C7:6B021B80 |
| html-safe-nonce | 91b72e771b5a6eb30af30cd03f4f3a87d16dbccc2169f40192ebc32986815a24 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NUY4OkNFNDM4OjE2RTAzNUU6MUU3NzVDNzo2QjAyMUI4MCIsInZpc2l0b3JfaWQiOiI5MTU2NTAwMjAxMDEwMjQwMzg0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 5e67c850025f0844e4b14404443f5eb3a3eaa6902949930b6218c18590802395 |
| hovercard-subject-tag | issue:5169311470 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/155941/issue_layout |
| twitter:image | https://opengraph.githubassets.com/20152a29468e401f4739391e5c8081baeafae29e116b74e288fc4d8735e1a25b/python/cpython/issues/155941 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/20152a29468e401f4739391e5c8081baeafae29e116b74e288fc4d8735e1a25b/python/cpython/issues/155941 |
| og:image:alt | Bug report Bug description: Bug report Bug description asyncio.start_server() accepts both coroutine and plain-function callbacks. When a coroutine callback raises, gh-110894 (gh-111601) made Strea... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | danielKim614 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width