René's URL Explorer Experiment


Title: asyncio: a plain-function client_connected_cb that raises leaves the server transport open · Issue #155941 · python/cpython · GitHub

Open Graph Title: asyncio: a plain-function client_connected_cb that raises leaves the server transport open · Issue #155941 · python/cpython

X Title: asyncio: a plain-function client_connected_cb that raises leaves the server transport open · Issue #155941 · python/cpython

Description: Bug report Bug description: Bug report Bug description asyncio.start_server() accepts both coroutine and plain-function callbacks. When a coroutine callback raises, gh-110894 (gh-111601) made StreamReaderProtocol.connection_made() report...

Open Graph Description: Bug report Bug description: Bug report Bug description asyncio.start_server() accepts both coroutine and plain-function callbacks. When a coroutine callback raises, gh-110894 (gh-111601) made Strea...

X Description: Bug report Bug description: Bug report Bug description asyncio.start_server() accepts both coroutine and plain-function callbacks. When a coroutine callback raises, gh-110894 (gh-111601) made Strea...

Opengraph URL: https://github.com/python/cpython/issues/155941

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"asyncio: a plain-function client_connected_cb that raises leaves the server transport open","articleBody":"# Bug report\n\n### Bug description:\n\n# Bug report\n\n## Bug description\n\n`asyncio.start_server()` accepts both coroutine and plain-function callbacks. When a coroutine callback raises, gh-110894 (gh-111601) made `StreamReaderProtocol.connection_made()` report the error and close the transport. The plain-function branch was not covered. If the callback raises synchronously, the exception propagates out of `connection_made()` (`Lib/asyncio/streams.py`).\n\n1. **The transport is never closed.** The client sees an established connection that never answers, and the server-side connection leaks until process exit (`ResourceWarning: unclosed transport` and `unclosed socket`).\n2. **`Server.wait_closed()` hangs forever**, because the leaked connection never finishes. A failing callback breaks graceful shutdown.\n3. The error is reported with the generic `'Exception in callback StreamReaderProtocol.connection_made()'` message instead of the `'Unhandled exception in client_connected_cb'` message used by the coroutine branch.\n\nRelated: gh-155934 covers the same failure class one stage earlier in the server pipeline, an error while creating the transport for an accepted connection in `BaseSelectorEventLoop._accept_connection2()`.\n\n## Reproducer\n\n```python\nimport asyncio\n\n\nasync def main():\n    loop = asyncio.get_running_loop()\n    messages = []\n    loop.set_exception_handler(lambda l, ctx: messages.append(ctx.get(\"message\")))\n\n    def cb(reader, writer):          # plain function, not async\n        raise RuntimeError(\"boom in client_connected_cb\")\n\n    server = await asyncio.start_server(cb, \"127.0.0.1\", 0)\n    port = server.sockets[0].getsockname()[1]\n\n    rd, wr = await asyncio.open_connection(\"127.0.0.1\", port)\n    wr.write(b\"hello\")\n    await wr.drain()\n    try:\n        data = await asyncio.wait_for(rd.read(), timeout=1.0)\n        print(\"server closed the connection, read ->\", data)\n    except ConnectionResetError:\n        print(\"server closed the connection (RST, unread data was pending)\")\n    except TimeoutError:\n        print(\"TIMEOUT: server never closed the connection (transport left open)\")\n    wr.close()\n    server.close()\n    try:\n        await asyncio.wait_for(server.wait_closed(), timeout=1.0)\n        print(\"server.wait_closed() returned\")\n    except TimeoutError:\n        print(\"server.wait_closed() HANGS (leaked connection keeps the server alive)\")\n    print(\"exception handler messages:\", messages)\n\n\nasyncio.run(main())\n```\n\nOutput on current main:\n\n```\nTIMEOUT: server never closed the connection (transport left open)\nserver.wait_closed() HANGS (leaked connection keeps the server alive)\nexception handler messages: ['Exception in callback StreamReaderProtocol.connection_made()']\n\u003csys>:0: ResourceWarning: unclosed \u003csocket.socket fd=8, ...>\nResourceWarning: unclosed transport \u003c_SelectorSocketTransport fd=8>\n```\n\n## Suggested fix\n\nWrap the synchronous call in `connection_made()` and mirror the coroutine branch on failure. Report through the loop exception handler with the same message and close the transport. With that change the reproducer prints:\n\n```\nserver closed the connection (RST, unread data was pending)\nserver.wait_closed() returned\nexception handler messages: ['Unhandled exception in client_connected_cb']\n```\n\nI'd like to work on this as part of the PyCon KR sprint. @corona10 @hugovk \n\nFound while verifying entries from [devdanzin's stdlib audit catalog](https://gist.github.com/devd0a7b4e0768e5f) n.26\n\n### CPython versions tested on:\n\nCPython main branch\n\n### Operating systems tested on:\n\nmacOS\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-155942\n* gh-156273\n* gh-156274\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/danielKim614","@type":"Person","name":"danielKim614"},"datePublished":"2026-08-17T07:15:48Z","url":"https://github.com/python/cpython/issues/155941"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:af8d36f4-c0a5-3ffb-913f-4b74d7ad5c26
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id95F8:CE438:16E035E:1E775C7:6B021B80
html-safe-nonce91b72e771b5a6eb30af30cd03f4f3a87d16dbccc2169f40192ebc32986815a24
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NUY4OkNFNDM4OjE2RTAzNUU6MUU3NzVDNzo2QjAyMUI4MCIsInZpc2l0b3JfaWQiOiI5MTU2NTAwMjAxMDEwMjQwMzg0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5e67c850025f0844e4b14404443f5eb3a3eaa6902949930b6218c18590802395
hovercard-subject-tagissue:5169311470
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/155941/issue_layout
twitter:imagehttps://opengraph.githubassets.com/20152a29468e401f4739391e5c8081baeafae29e116b74e288fc4d8735e1a25b/python/cpython/issues/155941
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/20152a29468e401f4739391e5c8081baeafae29e116b74e288fc4d8735e1a25b/python/cpython/issues/155941
og:image:altBug report Bug description: Bug report Bug description asyncio.start_server() accepts both coroutine and plain-function callbacks. When a coroutine callback raises, gh-110894 (gh-111601) made Strea...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanielKim614
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/155941#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F155941
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F155941
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/155941
Reloadhttps://github.com/python/cpython/issues/155941
Reloadhttps://github.com/python/cpython/issues/155941
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/155941
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/155941
asyncio: a plain-function client_connected_cb that raises leaves the server transport openhttps://github.com/python/cpython/issues/155941#top
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
topic-asynciohttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-asyncio%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/danielKim614
danielKim614https://github.com/danielKim614
on Aug 17, 2026https://github.com/python/cpython/issues/155941#issue-5169311470
gh-110894https://github.com/python/cpython/issues/110894
gh-111601https://github.com/python/cpython/pull/111601
gh-155934https://github.com/python/cpython/issues/155934
@corona10https://github.com/corona10
@hugovkhttps://github.com/hugovk
devdanzin's stdlib audit cataloghttps://gist.github.com/devd0a7b4e0768e5f
gh-155941: Close the transport when a plain client_connected_cb raises #155942https://github.com/python/cpython/pull/155942
[3.14] gh-155941: Close the transport when client_connected_cb raises in asyncio (GH-155942) #156273https://github.com/python/cpython/pull/156273
[3.15] gh-155941: Close the transport when client_connected_cb raises in asyncio (GH-155942) #156274https://github.com/python/cpython/pull/156274
danielKim614https://github.com/danielKim614
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
on Aug 17, 2026https://github.com/python/cpython/issues/155941#event-29548026680
picnixzhttps://github.com/picnixz
topic-asynciohttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-asyncio%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
on Aug 17, 2026https://github.com/python/cpython/issues/155941#event-29554077302
github-project-automationhttps://github.com/apps/github-project-automation
asynciohttps://github.com/orgs/python/projects/29
on Aug 17, 2026https://github.com/python/cpython/issues/155941#event-29554082118
github-project-automationhttps://github.com/apps/github-project-automation
asynciohttps://github.com/orgs/python/projects/29
on Aug 17, 2026https://github.com/python/cpython/issues/155941
kumaraditya303https://github.com/kumaraditya303
on Aug 18, 2026https://github.com/python/cpython/issues/155941#event-29622343068
gh-155941: Close the transport when client_connected_cb raises in asy…https://github.com/python/cpython/commit/95e32ba8262b2f08d4c574bce55425589cbf9885
gh-155941https://github.com/python/cpython/issues/155941
95e32bahttps://github.com/python/cpython/commit/95e32ba8262b2f08d4c574bce55425589cbf9885
kumaraditya303https://github.com/kumaraditya303
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Aug 18, 2026https://github.com/python/cpython/issues/155941#event-29622350514
github-project-automationhttps://github.com/apps/github-project-automation
asynciohttps://github.com/orgs/python/projects/29
on Aug 18, 2026https://github.com/python/cpython/issues/155941
hugovkhttps://github.com/hugovk
asyncio.start_server() leaves the transport open when a synchronous client callback raises #155928https://github.com/python/cpython/issues/155928
on Aug 28, 2026https://github.com/python/cpython/issues/155941#event-30145982150
kumaraditya303https://github.com/kumaraditya303
on Sep 8, 2026https://github.com/python/cpython/issues/155941#event-30739717970
[3.14] gh-155941: Close the transport when client_connected_cb raises…https://github.com/python/cpython/commit/fdc25ea1b1f2f48135a6017927057e346b080c97
gh-155941https://github.com/python/cpython/issues/155941
fdc25eahttps://github.com/python/cpython/commit/fdc25ea1b1f2f48135a6017927057e346b080c97
serhiy-storchakahttps://github.com/serhiy-storchaka
on Oct 10, 2026https://github.com/python/cpython/issues/155941#event-32936933655
[3.15] gh-155941: Close the transport when client_connected_cb raises…https://github.com/python/cpython/commit/bae2f74af270cb0d7c1c361acd41e56f1292d254
gh-155941https://github.com/python/cpython/issues/155941
bae2f74https://github.com/python/cpython/commit/bae2f74af270cb0d7c1c361acd41e56f1292d254
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/155941
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/155941
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
topic-asynciohttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-asyncio%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
asynciohttps://github.com/orgs/python/projects/29
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.