René's URL Explorer Experiment


Title: _testcapi mishandles Py_fopen() failures · Issue #155905 · python/cpython · GitHub

Open Graph Title: _testcapi mishandles Py_fopen() failures · Issue #155905 · python/cpython

X Title: _testcapi mishandles Py_fopen() failures · Issue #155905 · python/cpython

Description: Bug report Py_fopen() sets an exception and returns NULL on error, but several _testcapi helpers ignore both halves of that contract. Modules/_testcapi/object.c does not check the result at all. All four helpers pass it straight to PyObj...

Open Graph Description: Bug report Py_fopen() sets an exception and returns NULL on error, but several _testcapi helpers ignore both halves of that contract. Modules/_testcapi/object.c does not check the result at all. Al...

X Description: Bug report Py_fopen() sets an exception and returns NULL on error, but several _testcapi helpers ignore both halves of that contract. Modules/_testcapi/object.c does not check the result at all. Al...

Opengraph URL: https://github.com/python/cpython/issues/155905

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"_testcapi mishandles Py_fopen() failures","articleBody":"# Bug report\n\n`Py_fopen()` sets an exception and returns `NULL` on error, but several `_testcapi` helpers ignore both halves of that contract.\n\n**`Modules/_testcapi/object.c` does not check the result at all.** All four helpers pass it straight to `PyObject_Print()`:\n\n```c\n    fp = Py_fopen(filename, \"w+\");\n\n    if (PyObject_Print(object, fp, flags) \u003c 0) {\n```\n\nso a `NULL` file pointer reaches `fprintf()` and the interpreter crashes:\n\n```pycon\n>>> import _testcapi\n>>> _testcapi.call_pyobject_print('x', '/nonexistent-dir/out.txt', False)\nSegmentation fault\n```\n\nThe same happens with `pyobject_print_null()`, `pyobject_print_noref_object()` and `pyobject_print_os_error()`.\n\n**`Modules/_testcapimodule.c` sets a second exception.** The six `pymarshal_*` helpers do:\n\n```c\n    fp = Py_fopen(filename, \"rb\");\n    if (fp == NULL) {\n        PyErr_SetFromErrno(PyExc_OSError);\n        return NULL;\n    }\n```\n\nso `OSError` is instantiated while `Py_fopen()`'s exception is still pending:\n\n```pycon\n>>> _testcapi.pymarshal_read_object_from_file('nonexistent')\nSystemError: \u003cclass 'OSError'> returned a result with an exception set\n```\n\nOn a debug build it aborts instead: ``Objects/call.c:342: _PyObject_Call: Assertion `!_PyErr_Occurred(tstate)' failed.``\n\nBoth date from f89e5e20cb8 (gh-127350), which converted these helpers from `fopen()` to `Py_fopen()`.  They affect 3.14 and later.\n\nRelated cleanup: these helpers also close the file with `fclose()` rather than `Py_fclose()`, which the documentation requires -- 8 sites in `object.c`, 6 in `_testcapimodule.c` and 14 in `run.c`.  It is harmless today, since `Py_fclose()` is just a wrapper.\n\nAll other `Py_fopen()` call sites in the tree check the result correctly.\n\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-155906\n* gh-156580\n* gh-156581\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/serhiy-storchaka","@type":"Person","name":"serhiy-storchaka"},"datePublished":"2026-08-16T17:31:21Z","url":"https://github.com/python/cpython/issues/155905"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2522eeca-2ecf-b825-5b1f-e2db14bf8c6f
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC622:62F48:D6B4AA:11B858B:6B01FE9A
html-safe-nonce22f95e669e68343b6d7e00fd81473749384264a69a580e598b39043566fbeaff
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjIyOjYyRjQ4OkQ2QjRBQToxMUI4NThCOjZCMDFGRTlBIiwidmlzaXRvcl9pZCI6IjE3NzI2MDA1NDMyMTUyMjI0MjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc1df697a00021ce178bbb8aaf9b066e8a8becd04e95582ed87538b5052dc1111
hovercard-subject-tagissue:5165483512
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/155905/issue_layout
twitter:imagehttps://opengraph.githubassets.com/6426ff7b83cb1e723704aaffcb422053bbaf6ffbdf9bf245946a34b5a2c268f3/python/cpython/issues/155905
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6426ff7b83cb1e723704aaffcb422053bbaf6ffbdf9bf245946a34b5a2c268f3/python/cpython/issues/155905
og:image:altBug report Py_fopen() sets an exception and returns NULL on error, but several _testcapi helpers ignore both halves of that contract. Modules/_testcapi/object.c does not check the result at all. Al...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameserhiy-storchaka
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/155905#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F155905
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F155905
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/155905
Reloadhttps://github.com/python/cpython/issues/155905
Reloadhttps://github.com/python/cpython/issues/155905
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/155905
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/155905
_testcapi mishandles Py_fopen() failureshttps://github.com/python/cpython/issues/155905#top
3.14bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.14%22
3.15bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.15%22
3.16new features, bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.16%22
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
type-crashA hard crash of the interpreter, possibly with a core dumphttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-crash%22
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
on Aug 16, 2026https://github.com/python/cpython/issues/155905#issue-5165483512
f89e5e2https://github.com/python/cpython/commit/f89e5e20cb8964653ea7d6f53d3e40953b6548ce
gh-127350https://github.com/python/cpython/issues/127350
gh-155905: Fix error handling in _testcapi helpers #155906https://github.com/python/cpython/pull/155906
[3.15] gh-155905: Fix error handling in _testcapi helpers (GH-155906) #156580https://github.com/python/cpython/pull/156580
[3.14] gh-155905: Fix error handling in _testcapi helpers (GH-155906) #156581https://github.com/python/cpython/pull/156581
serhiy-storchakahttps://github.com/serhiy-storchaka
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
type-crashA hard crash of the interpreter, possibly with a core dumphttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-crash%22
3.14bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.14%22
3.15bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.15%22
3.16new features, bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.16%22
on Aug 16, 2026https://github.com/python/cpython/issues/155905#event-29527917365
serhiy-storchakahttps://github.com/serhiy-storchaka
on Aug 29, 2026https://github.com/python/cpython/issues/155905#event-30214507117
gh-155905: Fix error handling in _testcapi helpers (GH-155906)https://github.com/python/cpython/commit/a175da7a3ae3ba8d8aab9225c755bb41782edb4c
gh-155905https://github.com/python/cpython/issues/155905
GH-155906https://github.com/python/cpython/pull/155906
a175da7https://github.com/python/cpython/commit/a175da7a3ae3ba8d8aab9225c755bb41782edb4c
serhiy-storchakahttps://github.com/serhiy-storchaka
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Aug 29, 2026https://github.com/python/cpython/issues/155905#event-30214532886
serhiy-storchakahttps://github.com/serhiy-storchaka
on Aug 29, 2026https://github.com/python/cpython/issues/155905#event-30215130946
[3.14] gh-155905: Fix error handling in _testcapi helpers (GH-155906) (…https://github.com/python/cpython/commit/c392157f5836bccfe1c67d80ae39c42a1ca8e23f
gh-155905https://github.com/python/cpython/issues/155905
GH-155906https://github.com/python/cpython/pull/155906
…https://github.com/python/cpython/pull/156581
c392157https://github.com/python/cpython/commit/c392157f5836bccfe1c67d80ae39c42a1ca8e23f
clin1234https://github.com/clin1234
on Sep 12, 2026https://github.com/python/cpython/issues/155905#event-31023911318
pythongh-155905: Fix error handling in _testcapi helpers (pythonGH-15…https://github.com/clin1234/cpython/commit/df6cc0ccadb6d19f615b6fe18bee4c43b94427e7
pythongh-155905https://github.com/python/cpython/issues/155905
pythonGH-15…https://github.com/python/cpython/pull/155906
df6cc0chttps://github.com/clin1234/cpython/commit/df6cc0ccadb6d19f615b6fe18bee4c43b94427e7
serhiy-storchakahttps://github.com/serhiy-storchaka
on Oct 10, 2026https://github.com/python/cpython/issues/155905#event-32935136503
[3.15] gh-155905: Fix error handling in _testcapi helpers (GH-155906) (…https://github.com/python/cpython/commit/af3c8a8bba6ae9902ae92593a815ee9ddf4f9c1a
gh-155905https://github.com/python/cpython/issues/155905
GH-155906https://github.com/python/cpython/pull/155906
…https://github.com/python/cpython/pull/156580
af3c8a8https://github.com/python/cpython/commit/af3c8a8bba6ae9902ae92593a815ee9ddf4f9c1a
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/155905
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/155905
3.14bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.14%22
3.15bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.15%22
3.16new features, bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.16%22
testsTests in the Lib/test dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22tests%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
type-crashA hard crash of the interpreter, possibly with a core dumphttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-crash%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.