René's URL Explorer Experiment


Title: tarfile extraction filters raise raw ValueError for Windows drive-relative paths · Issue #154987 · python/cpython · GitHub

Open Graph Title: tarfile extraction filters raise raw ValueError for Windows drive-relative paths · Issue #154987 · python/cpython

X Title: tarfile extraction filters raise raw ValueError for Windows drive-relative paths · Issue #154987 · python/cpython

Description: Bug report Bug description: tarfile extraction filters raise a raw ValueError on Windows when handling drive-relative member names or link targets such as C:bad.txt. This looks like an inconsistency in the extraction-filter error handlin...

Open Graph Description: Bug report Bug description: tarfile extraction filters raise a raw ValueError on Windows when handling drive-relative member names or link targets such as C:bad.txt. This looks like an inconsistenc...

X Description: Bug report Bug description: tarfile extraction filters raise a raw ValueError on Windows when handling drive-relative member names or link targets such as C:bad.txt. This looks like an inconsistenc...

Opengraph URL: https://github.com/python/cpython/issues/154987

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"tarfile extraction filters raise raw ValueError for Windows drive-relative paths","articleBody":"# Bug report\n\n### Bug description:\n\n`tarfile` extraction filters raise a raw `ValueError` on Windows when handling drive-relative member names or link targets such as `C:bad.txt`.\n\nThis looks like an inconsistency in the extraction-filter error handling path. The affected cases are rejected through a raw `ValueError` from Windows path handling instead of the structured `tarfile` filter exceptions that similar rejected paths use.\n\nFor example, with `filter=\"data\"` and `errorlevel = 0`, I expected the invalid member to be skipped/refused and extraction to continue to later members. Instead, extraction aborts with:\n\n```text\nValueError: Paths don't have the same drive\n```\n\nMinimal reproducer:\n\n```python\nimport io\nimport os\nimport tarfile\nimport tempfile\nfrom pathlib import Path\n\n\ndef add_file(tf, name, data=b\"x\"):\n    info = tarfile.TarInfo(name)\n    info.size = len(data)\n    tf.addfile(info, io.BytesIO(data))\n\n\ndef build_archive_with_drive_relative_member(path):\n    with tarfile.open(path, \"w\") as tf:\n        add_file(tf, \"before.txt\", b\"before\")\n        add_file(tf, \"C:bad.txt\", b\"bad\")\n        add_file(tf, \"after.txt\", b\"after\")\n\n\ndef main():\n    if os.name != \"nt\":\n        print(\"This reproducer is Windows-specific.\")\n        return 0\n\n    with tempfile.TemporaryDirectory() as tmp:\n        tmp = Path(tmp)\n        archive_path = tmp / \"drive_relative.tar\"\n        extract_dir = tmp / \"extract\"\n        extract_dir.mkdir()\n\n        build_archive_with_drive_relative_member(archive_path)\n\n        try:\n            with tarfile.open(archive_path, \"r\") as tf:\n                tf.errorlevel = 0\n                tf.extractall(extract_dir, filter=\"data\")\n        except Exception as exc:\n            print(\"exception_type:\", type(exc).__name__)\n            print(\"exception_message:\", str(exc))\n\n        print(\"before_exists:\", (extract_dir / \"before.txt\").exists())\n        print(\"after_exists:\", (extract_dir / \"after.txt\").exists())\n\n\nif __name__ == \"__main__\":\n    raise SystemExit(main())\n```\n\nObserved output on Windows:\n\n```text\nexception_type: ValueError\nexception_message: Paths don't have the same drive\nbefore_exists: True\nafter_exists: False\n```\n\nExpected behavior:\n\nThe drive-relative member should be handled through the normal `tarfile` extraction-filter exception path, for example `OutsideDestinationError`, so that `errorlevel = 0` can skip/refuse that member and continue extracting later members.\n\nExpected output would be:\n\n```text\nbefore_exists: True\nafter_exists: True\n```\n\nI also observed the same raw `ValueError` behavior for drive-relative hardlink and symlink targets under `filter=\"data\"`.\n\nExpected structured exceptions:\n\n```text\nDrive-relative member name: OutsideDestinationError\nDrive-relative hardlink target: LinkOutsideDestinationError\nDrive-relative symlink target: LinkOutsideDestinationError\n```\n\nThe issue appears to come from `ntpath.commonpath()` raising `ValueError` for incompatible drive/path semantics, and that exception escaping directly instead of being converted into the appropriate `tarfile` filter exception.\n\nA possible fix would be to treat `ValueError` from the containment/commonpath check as an outside-destination condition and raise the appropriate structured `tarfile` exception.\n\n\n### CPython versions tested on:\n\nCPython main branch\n\n### Operating systems tested on:\n\nWindows\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-154993\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/zainnadeem786","@type":"Person","name":"zainnadeem786"},"datePublished":"2026-07-31T10:07:53Z","url":"https://github.com/python/cpython/issues/154987"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5514c448-d415-f0eb-def6-5202ed3185c0
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA20A:1201C:394CC9E:4C08628:6B0211FC
html-safe-nonceeb18b58bab08c69f03f75f582d4908e5026dca5423c9095c695f53c388493fa5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjBBOjEyMDFDOjM5NENDOUU6NEMwODYyODo2QjAyMTFGQyIsInZpc2l0b3JfaWQiOiI4NDQ3NTc5MDQ1MjMwNjc4NTI0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfc4e6ffe359f1f23093135e1334bf2a27b068f7d675454aa23f8546d21ad0551
hovercard-subject-tagissue:5028604588
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/154987/issue_layout
twitter:imagehttps://opengraph.githubassets.com/26c992f6164949c20a3db707d3c94a5c992a9a01cecbfe73194e6b63f70c220e/python/cpython/issues/154987
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/26c992f6164949c20a3db707d3c94a5c992a9a01cecbfe73194e6b63f70c220e/python/cpython/issues/154987
og:image:altBug report Bug description: tarfile extraction filters raise a raw ValueError on Windows when handling drive-relative member names or link targets such as C:bad.txt. This looks like an inconsistenc...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezainnadeem786
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/154987#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F154987
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F154987
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/154987
Reloadhttps://github.com/python/cpython/issues/154987
Reloadhttps://github.com/python/cpython/issues/154987
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/154987
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/154987
#154993https://github.com/python/cpython/pull/154993
tarfile extraction filters raise raw ValueError for Windows drive-relative pathshttps://github.com/python/cpython/issues/154987#top
#154993https://github.com/python/cpython/pull/154993
OS-windowshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22OS-windows%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/zainnadeem786
zainnadeem786https://github.com/zainnadeem786
on Jul 31, 2026https://github.com/python/cpython/issues/154987#issue-5028604588
gh-154987: Handle ValueError for drive-relative paths in tarfile filters #154993https://github.com/python/cpython/pull/154993
zainnadeem786https://github.com/zainnadeem786
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
on Jul 31, 2026https://github.com/python/cpython/issues/154987#event-28770628527
https://github.com/zainnadeem786
zainnadeem786https://github.com/zainnadeem786
on Jul 31, 2026https://github.com/python/cpython/issues/154987#issuecomment-5141750210
https://github.com/picnixz
picnixzhttps://github.com/picnixz
on Jul 31, 2026https://github.com/python/cpython/issues/154987#issuecomment-5143185932
picnixzhttps://github.com/picnixz
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
pendingThe issue will be closed if no feedback is providedhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22pending%22
on Jul 31, 2026https://github.com/python/cpython/issues/154987#event-28777662991
https://github.com/zainnadeem786
zainnadeem786https://github.com/zainnadeem786
on Jul 31, 2026https://github.com/python/cpython/issues/154987#issuecomment-5143226109
@picnixzhttps://github.com/picnixz
#133890https://github.com/python/cpython/issues/133890
#133890https://github.com/python/cpython/issues/133890
https://github.com/picnixz
picnixzhttps://github.com/picnixz
on Jul 31, 2026https://github.com/python/cpython/issues/154987#issuecomment-5143250274
picnixzhttps://github.com/picnixz
pendingThe issue will be closed if no feedback is providedhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22pending%22
on Jul 31, 2026https://github.com/python/cpython/issues/154987#event-28777957948
https://github.com/zainnadeem786
zainnadeem786https://github.com/zainnadeem786
on Jul 31, 2026https://github.com/python/cpython/issues/154987#issuecomment-5143281574
#154993https://github.com/python/cpython/pull/154993
picnixzhttps://github.com/picnixz
OS-windowshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22OS-windows%22
on Jul 31, 2026https://github.com/python/cpython/issues/154987#event-28778236042
StanFromIrelandhttps://github.com/StanFromIreland
Tarfile issues 🗄️https://github.com/orgs/python/projects/11
on Jul 31, 2026https://github.com/python/cpython/issues/154987#event-28790129507
https://github.com/encukou
encukouhttps://github.com/encukou
on Oct 9, 2026https://github.com/python/cpython/issues/154987#issuecomment-6081851036
kevinprimeraquecreo-stackhttps://github.com/kevinprimeraquecreo-stack
Project_VKhttps://github.com/users/kevinprimeraquecreo-stack/projects/1
on Oct 18, 2026https://github.com/python/cpython/issues/154987#event-33592122427
github-project-automationhttps://github.com/apps/github-project-automation
Project_VKhttps://github.com/users/kevinprimeraquecreo-stack/projects/1
on Oct 18, 2026https://github.com/python/cpython/issues/154987
github-project-automationhttps://github.com/apps/github-project-automation
Project_VKhttps://github.com/users/kevinprimeraquecreo-stack/projects/1
on Oct 18, 2026https://github.com/python/cpython/issues/154987
kevinprimeraquecreo-stackhttps://github.com/kevinprimeraquecreo-stack
Project_VKhttps://github.com/users/kevinprimeraquecreo-stack/projects/1
on Oct 18, 2026https://github.com/python/cpython/issues/154987#event-33592173486
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/154987
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/154987
OS-windowshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22OS-windows%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
Tarfile issues 🗄️https://github.com/orgs/python/projects/11
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.