Title: Umbrella issue: idlelib analysis with code-review-toolkit · Issue #154760 · python/cpython · GitHub
Open Graph Title: Umbrella issue: idlelib analysis with code-review-toolkit · Issue #154760 · python/cpython
X Title: Umbrella issue: idlelib analysis with code-review-toolkit · Issue #154760 · python/cpython
Description: Bug report Bug description: A two-pass review of Lib/idlelib turned up 69 findings — 37 FIX (a wrong result, silent data loss, or an unreachable feature) and 32 CONSIDER. Every one carries a file:line, a concrete failure scenario, and — ...
Open Graph Description: Bug report Bug description: A two-pass review of Lib/idlelib turned up 69 findings — 37 FIX (a wrong result, silent data loss, or an unreachable feature) and 32 CONSIDER. Every one carries a file:l...
X Description: Bug report Bug description: A two-pass review of Lib/idlelib turned up 69 findings — 37 FIX (a wrong result, silent data loss, or an unreachable feature) and 32 CONSIDER. Every one carries a file:l...
Opengraph URL: https://github.com/python/cpython/issues/154760
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Umbrella issue: idlelib analysis with code-review-toolkit","articleBody":"# Bug report\n\n### Bug description:\n\nA two-pass review of `Lib/idlelib` turned up **69 findings** — 37 `FIX` (a wrong result, silent data loss, or an unreachable feature) and 32 `CONSIDER`. Every one carries a `file:line`, a concrete failure scenario, and — where idlelib already handles the same situation correctly somewhere else — the **guarded twin** that shows it is a defect by the project's own standard and suggests the fix.\n\nI'm filing them under one umbrella so they can be picked off individually rather than flooding the tracker.\n\n**Please don't start work on a row until a maintainer has cleared it.** These are a reviewer's findings, not triaged bugs: some will be intentional behaviour, some not worth the churn, and some wrong. Every row starts at *Under analysis*, which means **not yet cleared — do not work on it**. A maintainer moving a row off *Under analysis* is what opens it up; a PR against an uncleared row may be wasted effort, and several of these touch code where the current behaviour is load-bearing.\n\n**To take a cleared one:** open a normal issue or PR for it and drop a comment here with the link — I'll put it in the Status column. If any row is a duplicate, a non-bug, or intentional, say so and I'll annotate it.\n\nFound with [code-review-toolkit](https://github.com/devdanzin/code-review-toolkit). Reports were drafted with AI assistance (Claude Code) and then re-verified by hand — see *Disclosure* at the end.\n\n### Scope and verification\n\n- **Everything below is against `main` at `993a0c65a7b` (2026-07-27).** The review itself was carried out on the 3.14 branch at `6080c866096`; every finding was then re-checked against main by comparing the enclosing function (46 byte-identical, 13 changed and read individually, 11 module-level checked by hand), and every line number here is main's. Line numbers drift; the cited function and mechanism will not.\n- **18 findings were reproduced** against a running interpreter (real Tk where the widget matters); the rest were confirmed by reading the code and its tests. Each gist entry says which. The reproductions were re-run on a release build of main at the commit above.\n- `python -m test test_idle` passes on this commit (305 run, 83 skipped headless). **Every finding below is one the suite cannot see** — and four of them ([26](https://gist.github.com/devdanzin/f5c7aee89c8518ff0cc95ec1ca1b1441#26--five-tests-in-the-suite-cannot-fail), [71](https://gist.github.com/devdanzin/f5c7aee89c8518ff0cc95ec1ca1b1441#71--the-shared-test-stubs-cannot-express-the-conditions-the-guards-under-test-exist-for), [72](https://gist.github.com/devdanzin/f5c7aee89c8518ff0cc95ec1ca1b1441#72--a-test-class-freezes-textindex-to-a-constant-leaving-seven-mutations-of-live-code-undetected), [73](https://gist.github.com/devdanzin/f5c7aee89c8518ff0cc95ec1ca1b1441#73--four-test-files-exit-0-even-when-their-tests-fail)) are about why.\n- **Prior art was checked for all 73 findings** against the whole tracker: 1626 `topic-IDLE` issues, 281 unlabelled issues mentioning idlelib, 573 PRs and 86 `idle.rst` items (2503 unique). Three were already reported and have been **removed** from this report — they are listed at the bottom so nobody re-derives them. Where an open issue covers the area without covering the defect, the table names it.\n\n## Three systemic roots\n\nThese are worth reading first: each explains several of the individual rows below, and fixing the root is a smaller change than fixing its instances one at a time.\n\n- **[31](https://gist.github.com/devdanzin/885741290c23c12256f11db69ba0dfb2#31--five-independent-hand-written-recognizers-for-python-syntax-with-no-shared-source-of-truth) — Five independent hand-written recognizers for Python syntax with no shared source of truth** \n idlelib answers “is this Python syntax?” in five hand-written places with no shared definition, and new syntax reaches some and not others. `colorizer` is consistently the one that gets updated — four of the rows below are drift between it and a sibling.\n- **[32](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06#32--the--n-execution-backend-is-missing-five-cross-cutting-protections-the-rpc-backend-has) — The `-n` execution backend is missing five cross-cutting protections the RPC backend has** \n `use_subprocess` selects between two interchangeable execution backends, and every cross-cutting protection lives inside the RPC one rather than in a shared driver. `SystemExit` is the sharpest cell and the two are opposites: the RPC backend contains it and returns to the prompt, while `-n` asks “Do you want to exit altogether?” with `default=\"yes\"` and raises out of `mainloop()`, so unsaved editor buffers get no save prompt. Ctrl-C, Restart and the recursion headroom are missing from `-n` too.\n- **[34](https://gist.github.com/devdanzin/85d7c940ad8bb3c068f28c3c21d63970#34--widgetredirector-swallows-every-tclerror-so-textindex-can-never-raise-on-any-idle-widget) — WidgetRedirector swallows every TclError, so text.index() can never raise on any IDLE widget** \n `except TclError: return \"\"` in `WidgetRedirector.dispatch` intercepts every subcommand of every percolated Text — which is every EditorWindow, PyShell and OutputWindow. On the widgets idlelib actually uses, `text.index()` therefore never raises and never returns `None`, callers cannot tell “no selection” from “the call failed”, and three incompatible guard idioms have grown in one file.\n\n## Start here\n\nLowest effort to confirm, highest cost if left alone — all silent:\n\n- [35](https://gist.github.com/devdanzin/0e2d9434d8d40cc5dc4f73b22547d8ef#35--format-paragraph-silently-deletes-characters-from-every-non-comment-line-of-a-selection) — Format Paragraph silently deletes characters from every non-comment line of a selection (`format.py:59`)\n- [36](https://gist.github.com/devdanzin/17606be27ac3be616ee42545ac594a3a#36--a-literal--in-any-setting-strips-every-open-windows-keybindings-and-leaves-them-off) — A literal % in any setting strips every open window's keybindings and leaves them off (`config.py:48`)\n- [27](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06#27--copy-with-prompts-drops-the-last-line-whenever-the-selection-ends-at-column-10-20-100) — Copy-with-prompts drops the last line whenever the selection ends at column 10, 20, 100... (`pyshell.py:1034`)\n- [60](https://gist.github.com/devdanzin/0e2d9434d8d40cc5dc4f73b22547d8ef#60--saving-a-file-whose-coding-cookie-cannot-encode-its-text-writes-a-bom-and-keeps-the-cookie) — Saving a file whose coding cookie cannot encode its text writes a BOM and keeps the cookie (`iomenu.py:324-326`)\n- [51](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06#51--restore_file_breaks-appends-without-clearing-so-save-as-carries-the-old-files-breakpoints-over) — restore_file_breaks appends without clearing, so Save As carries the old file's breakpoints over (`pyshell.py:268`)\n- [59](https://gist.github.com/devdanzin/885741290c23c12256f11db69ba0dfb2#59--_study1-has-no-f-string-state-so-a-pep-701-multi-line-f-string-is-read-as-three-statements) — _study1 has no f-string state, so a PEP 701 multi-line f-string is read as three statements (`pyparse.py:245`)\n- [43](https://gist.github.com/devdanzin/17606be27ac3be616ee42545ac594a3a#43--three-keysyms-shipped-in-every-keyset-cannot-be-spelled-by-the-key-configuration-dialog) — Three keysyms shipped in every keyset cannot be spelled by the key-configuration dialog (`config_key.py:15`)\n- [34](https://gist.github.com/devdanzin/85d7c940ad8bb3c068f28c3c21d63970#34--widgetredirector-swallows-every-tclerror-so-textindex-can-never-raise-on-any-idle-widget) — WidgetRedirector swallows every TclError, so text.index() can never raise on any IDLE widget (`redirector.py:116`)\n\n## Findings\n\n**The `#` column is a row number in this issue, not an identifier.** Please cite this issue plus the row (“#‹this issue› row 35”) rather than the bare number on its own — a bare number does not autolink and does not lead anyone back here.\n\nStatus: **Under analysis** = awaiting a maintainer's call, **not cleared for work** · `#N` = filed, in progress · `#N FIXED` = filed and fixed · *won't fix* / *intentional* = closed by a maintainer.\n\n**Prior art** names an existing issue where one is relevant: *from* = this is residue of that merged change; *see* = that issue covers the area but not this defect, so a comment there may be better than a new issue.\n\n### Shell, the `-n` backend, and breakpoints (15)\n\n`pyshell.py`, `run.py`, `rpc.py` — [full reports](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06)\n\n| # | Sev | Location | Finding | Prior art | Status |\n|---|---|---|---|---|---|\n| [2](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06#2--one-subprocess-accept-timeout-wedges-idle-permanently) | FIX | `pyshell.py:499-540` | One subprocess-accept timeout wedges IDLE permanently | | Under analysis |\n| [8](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06#8--stack-viewer-reads-an-attribute-only-runcode-ever-creates) | FIX | `run.py:635-639,695` | Stack Viewer reads an attribute only runcode() ever creates | | Under analysis |\n| [27](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06#27--copy-with-prompts-drops-the-last-line-whenever-the-selection-ends-at-column-10-20-100) | FIX | `pyshell.py:1034` | Copy-with-prompts drops the last line whenever the selection ends at column 10, 20, 100... | from #95511 | Under analysis |\n| [28](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06#28--get_prompt_text-zips-a-computed-line-range-against-actual-lines) | FIX | `pyshell.py:1016` | get_prompt_text zips a computed line range against actual lines | from #95191 | Under analysis |\n| [32](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06#32--the--n-execution-backend-is-missing-five-cross-cutting-protections-the-rpc-backend-has) | FIX | `pyshell.py:792-803` | The `-n` execution backend is missing five cross-cutting protections the RPC backend has | | Under analysis |\n| [33](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06#33--under-idle--n-file-is-silently-idles-own-path-instead-of-the-scripts) | FIX | `pyshell.py:680` | Under `idle -n`, __file__ is silently IDLE's own path instead of the script's | from #77165 | Under analysis |\n| [51](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06#51--restore_file_breaks-appends-without-clearing-so-save-as-carries-the-old-files-breakpoints-over) | FIX | `pyshell.py:268` | restore_file_breaks appends without clearing, so Save As carries the old file's breakpoints over | | Under analysis |\n| [52](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06#52--breakpoints-are-keyed-by-the-raw-filename-while-windows-are-keyed-by-the-normalized-one) | FIX | `pyshell.py:244` | Breakpoints are keyed by the raw filename while windows are keyed by the normalized one | | Under analysis |\n| [53](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06#53--breakpointslst-uses--as-its-delimiter-which-is-legal-in-a-path) | FIX | `pyshell.py:259` | breakpoints.lst uses `=` as its delimiter, which is legal in a path | | Under analysis |\n| [12](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06#12--the-subprocesss-last-resort-handler-can-itself-raise-nameerror) | CONSIDER | `run.py:190-197` | The subprocess's last-resort handler can itself raise NameError | | Under analysis |\n| [13](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06#13--every-oserror-on-recv-becomes-the-peer-hung-up) | CONSIDER | `rpc.py:358-361` | Every OSError on recv becomes 'the peer hung up' | | Under analysis |\n| [14](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06#14--endexecuting-is-skipped-if-showtraceback-fails) | CONSIDER | `pyshell.py:804-821` | endexecuting() is skipped if showtraceback() fails | | Under analysis |\n| [15](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06#15--remote-internal-errors-are-reported-only-at-a-permanently-disabled-debug-level) | CONSIDER | `rpc.py:258-260` | Remote internal errors are reported only at a permanently-disabled debug level | | Under analysis |\n| [18](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06#18--reconnect-resets-some-per-connection-state-but-not-the-packet-read-buffer) | CONSIDER | `rpc.py:130-141` | Reconnect resets some per-connection state but not the packet read buffer | | Under analysis |\n| [21](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06#21--terminate_subprocess-catches-every-oserror-though-its-comment-names-one) | CONSIDER | `pyshell.py:564-574` | terminate_subprocess catches every OSError though its comment names one | | Under analysis |\n\n### Configuration and the Settings dialog (9)\n\n`config.py`, `configdialog.py`, `config_key.py` — [full reports](https://gist.github.com/devdanzin/17606be27ac3be616ee42545ac594a3a)\n\n| # | Sev | Location | Finding | Prior art | Status |\n|---|---|---|---|---|---|\n| [1](https://gist.github.com/devdanzin/17606be27ac3be616ee42545ac594a3a#1--a-failed-config-save-deletes-the-users-config-file) | FIX | `config.py:136-140` | A failed config save deletes the user's config file | | Under analysis |\n| [36](https://gist.github.com/devdanzin/17606be27ac3be616ee42545ac594a3a#36--a-literal--in-any-setting-strips-every-open-windows-keybindings-and-leaves-them-off) | FIX | `config.py:48` | A literal % in any setting strips every open window's keybindings and leaves them off | | Under analysis |\n| [43](https://gist.github.com/devdanzin/17606be27ac3be616ee42545ac594a3a#43--three-keysyms-shipped-in-every-keyset-cannot-be-spelled-by-the-key-configuration-dialog) | FIX | `config_key.py:15` | Three keysyms shipped in every keyset cannot be spelled by the key-configuration dialog | | Under analysis |\n| [48](https://gist.github.com/devdanzin/17606be27ac3be616ee42545ac594a3a#48--an-invalid-value-in-the-default-config-is-swallowed-where-the-user-config-clause-warns) | FIX | `config.py:244` | An invalid value in the DEFAULT config is swallowed where the user-config clause warns | from #60715 | Under analysis |\n| [49](https://gist.github.com/devdanzin/17606be27ac3be616ee42545ac594a3a#49--the-keybinding-collision-test-compares-whole-lists-so-a-partial-overlap-is-undetected-and-silent) | FIX | `config.py:605` | The keybinding collision test compares whole lists, so a partial overlap is undetected and silent | | Under analysis |\n| [61](https://gist.github.com/devdanzin/17606be27ac3be616ee42545ac594a3a#61--help-sources-are-numbered-on-write-and-sorted-as-strings-on-read-so-entry-10-sorts-before-entry-2) | FIX | `config.py:756` | Help sources are numbered on write and sorted as strings on read, so entry 10 sorts before entry 2 | see #71652 | Under analysis |\n| [62](https://gist.github.com/devdanzin/17606be27ac3be616ee42545ac594a3a#62--an-advanced-key-binding-stored-as-a-tk-event-sequence-is-read-back-as-a-whitespace-separated-list) | FIX | `config_key.py:227` | An advanced key binding stored as a Tk event sequence is read back as a whitespace-separated list | see #55646, #152747 | Under analysis |\n| [50](https://gist.github.com/devdanzin/17606be27ac3be616ee42545ac594a3a#50--the-whole-idle-profile-location-is-a-function-of-the-launch-directory-when-home-is-unusable) | CONSIDER | `config.py:199` | The whole IDLE profile location is a function of the launch directory when HOME is unusable | see #60066, #52478 | Under analysis |\n| [69](https://gist.github.com/devdanzin/17606be27ac3be616ee42545ac594a3a#69--two-extensions-in-code-fallback-defaults-disagree-with-the-values-actually-shipped) | CONSIDER | `parenmatch.py:53` | Two extensions' in-code fallback defaults disagree with the values actually shipped | | Under analysis |\n\n### Editor: formatting, undo, search/replace, save and run (14)\n\n`format.py`, `undo.py`, `replace.py`, `searchengine.py`, `iomenu.py`, `runscript.py`, `zoomheight.py` — [full reports](https://gist.github.com/devdanzin/0e2d9434d8d40cc5dc4f73b22547d8ef)\n\n| # | Sev | Location | Finding | Prior art | Status |\n|---|---|---|---|---|---|\n| [3](https://gist.github.com/devdanzin/0e2d9434d8d40cc5dc4f73b22547d8ef#3--replaces-null-guard-tests-the-call-receiver-instead-of-the-match) | FIX | `replace.py:226-229` | Replace's NULL-guard tests the call receiver instead of the match | | Under analysis |\n| [5](https://gist.github.com/devdanzin/0e2d9434d8d40cc5dc4f73b22547d8ef#5--forward-search-abandons-the-rest-of-a-line-after-a-zero-width-match) | FIX | `searchengine.py:146-151` | Forward search abandons the rest of a line after a zero-width match | | Under analysis |\n| [9](https://gist.github.com/devdanzin/0e2d9434d8d40cc5dc4f73b22547d8ef#9--a-failed-window-probe-leaves-the-users-window-stuck-maximized) | FIX | `zoomheight.py:66-105` | A failed window probe leaves the user's window stuck maximized | from #81220 | Under analysis |\n| [35](https://gist.github.com/devdanzin/0e2d9434d8d40cc5dc4f73b22547d8ef#35--format-paragraph-silently-deletes-characters-from-every-non-comment-line-of-a-selection) | FIX | `format.py:59` | Format Paragraph silently deletes characters from every non-comment line of a selection | see #143774, #143775 | Under analysis |\n| [45](https://gist.github.com/devdanzin/0e2d9434d8d40cc5dc4f73b22547d8ef#45--undo_block_startstop-is-unpaired-on-the-exception-path-in-four-places) | FIX | `replace.py:161` | undo_block_start/stop is unpaired on the exception path in four places | | Under analysis |\n| [60](https://gist.github.com/devdanzin/0e2d9434d8d40cc5dc4f73b22547d8ef#60--saving-a-file-whose-coding-cookie-cannot-encode-its-text-writes-a-bom-and-keeps-the-cookie) | FIX | `iomenu.py:324-326` | Saving a file whose coding cookie cannot encode its text writes a BOM and keeps the cookie | | Under analysis |\n| [67](https://gist.github.com/devdanzin/0e2d9434d8d40cc5dc4f73b22547d8ef#67--run-module-ignores-the-return-of-iosave-so-a-failed-save-runs-the-old-code-from-disk) | FIX | `runscript.py:189` | Run Module ignores the return of io.save(), so a failed save runs the old code from disk | | Under analysis |\n| [11](https://gist.github.com/devdanzin/0e2d9434d8d40cc5dc4f73b22547d8ef#11--a-bad-print-command-orphans-the-users-unsaved-source-in-tmp) | CONSIDER | `iomenu.py:360-375` | A bad print command orphans the user's unsaved source in /tmp | | Under analysis |\n| [19](https://gist.github.com/devdanzin/0e2d9434d8d40cc5dc4f73b22547d8ef#19--replace-alls-final-selection-uses-the-pre-replacement-span) | CONSIDER | `replace.py:172-188` | Replace All's final selection uses the pre-replacement span | | Under analysis |\n| [20](https://gist.github.com/devdanzin/0e2d9434d8d40cc5dc4f73b22547d8ef#20--getprog-catches-only-repatternerror-so-overflowerror-escapes-to-every-caller) | CONSIDER | `searchengine.py:85-89` | getprog catches only re.PatternError, so OverflowError escapes to every caller | | Under analysis |\n| [24](https://gist.github.com/devdanzin/0e2d9434d8d40cc5dc4f73b22547d8ef#24--recent-files-list-is-updated-outside-the-success-guard) | CONSIDER | `iomenu.py:253,261` | Recent-files list is updated outside the success guard | | Under analysis |\n| [46](https://gist.github.com/devdanzin/0e2d9434d8d40cc5dc4f73b22547d8ef#46--undo_block_stop-does-not-guard-the-sentinel-its-own-twin-guards) | CONSIDER | `undo.py:104` | undo_block_stop does not guard the sentinel its own twin guards | | Under analysis |\n| [64](https://gist.github.com/devdanzin/0e2d9434d8d40cc5dc4f73b22547d8ef#64--untabify-rewrites-the-whole-line-where-its-tabify-mirror-rewrites-only-the-indent) | CONSIDER | `format.py:340` | Untabify rewrites the whole line where its tabify mirror rewrites only the indent | | Under analysis |\n| [65](https://gist.github.com/devdanzin/0e2d9434d8d40cc5dc4f73b22547d8ef#65--deletecommandundo-reinserts-text-without-tags-where-the-insert-mirror-round-trips-them) | CONSIDER | `undo.py:294` | DeleteCommand.undo reinserts text without tags where the Insert mirror round-trips them | | Under analysis |\n\n### The five hand-written syntax recognizers (7)\n\n`pyparse.py`, `hyperparser.py`, `codecontext.py`, `colorizer.py` — [full reports](https://gist.github.com/devdanzin/885741290c23c12256f11db69ba0dfb2)\n\n| # | Sev | Location | Finding | Prior art | Status |\n|---|---|---|---|---|---|\n| [30](https://gist.github.com/devdanzin/885741290c23c12256f11db69ba0dfb2#30--hyperparsers-string-prefix-scanner-never-learned-f-or-t) | FIX | `hyperparser.py:298` | HyperParser's string-prefix scanner never learned `f` or `t` | from #139742, #139756 | Under analysis |\n| [47](https://gist.github.com/devdanzin/885741290c23c12256f11db69ba0dfb2#47--codecontexts-blockopeners-lacks-matchcase-so-those-blocks-never-appear-in-code-context) | FIX | `codecontext.py:22` | codecontext's BLOCKOPENERS lacks match/case, so those blocks never appear in Code Context | from #77745, #25851 | Under analysis |\n| [59](https://gist.github.com/devdanzin/885741290c23c12256f11db69ba0dfb2#59--_study1-has-no-f-string-state-so-a-pep-701-multi-line-f-string-is-read-as-three-statements) | FIX | `pyparse.py:245` | _study1 has no f-string state, so a PEP 701 multi-line f-string is read as three statements | see #77061 | Under analysis |\n| [63](https://gist.github.com/devdanzin/885741290c23c12256f11db69ba0dfb2#63--bracket-matching-checks-the-bracket-type-on-the-backward-scan-only) | FIX | `hyperparser.py:137-140` | Bracket matching checks the bracket type on the backward scan only | see #124451 | Under analysis |\n| [17](https://gist.github.com/devdanzin/885741290c23c12256f11db69ba0dfb2#17--a-comment-with-no-space-after--is-invisible-to-hyperparser) | CONSIDER | `pyparse.py:44-48` | A comment with no space after # is invisible to HyperParser | | Under analysis |\n| [31](https://gist.github.com/devdanzin/885741290c23c12256f11db69ba0dfb2#31--five-independent-hand-written-recognizers-for-python-syntax-with-no-shared-source-of-truth) | CONSIDER | `hyperparser.py:298` | Five independent hand-written recognizers for Python syntax with no shared source of truth | | Under analysis |\n| [58](https://gist.github.com/devdanzin/885741290c23c12256f11db69ba0dfb2#58--_synchre-matches-def-but-cannot-match-async-def-making-indent-analysis-quadratic-in-async-modules) | CONSIDER | `pyparse.py:21` | _synchre matches `def` but cannot match `async def`, making indent analysis quadratic in async modules | see #77061 | Under analysis |\n\n### Completions and calltips (5)\n\n`autocomplete*.py`, `calltip.py` — [full reports](https://gist.github.com/devdanzin/c2d03bc167079b6fb72a600542d726c7)\n\n| # | Sev | Location | Finding | Prior art | Status |\n|---|---|---|---|---|---|\n| [4](https://gist.github.com/devdanzin/c2d03bc167079b6fb72a600542d726c7#4--autocompletes-mode-filter-never-applies-to-attrs-because-attrs--0) | FIX | `autocomplete.py:117,134` | Autocomplete's mode filter never applies to ATTRS because ATTRS == 0 | | Under analysis |\n| [6](https://gist.github.com/devdanzin/c2d03bc167079b6fb72a600542d726c7#6--get_argspec-guards-two-of-its-three-touches-of-a-user-object) | FIX | `calltip.py:189` | get_argspec guards two of its three touches of a user object | | Under analysis |\n| [10](https://gist.github.com/devdanzin/c2d03bc167079b6fb72a600542d726c7#10--a-failed-is_active-check-permanently-disables-the-completion-windows-configure-handler) | FIX | `autocomplete_w.py:238` | A failed is_active check permanently disables the completion window's Configure handler | from #26404 | Under analysis |\n| [29](https://gist.github.com/devdanzin/c2d03bc167079b6fb72a600542d726c7#29--and-binds-tighter-than-or-so-the-modifier-guard-covers-one-completion-mode-of-two) | FIX | `autocomplete_w.py:363-368` | `and` binds tighter than `or`, so the modifier guard covers one completion mode of two | | Under analysis |\n| [68](https://gist.github.com/devdanzin/c2d03bc167079b6fb72a600542d726c7#68--the-completion-popup-teardown-is-unguarded-where-the-calltips-identical-teardown-guards-every-step) | FIX | `autocomplete_w.py:454-491` | The completion popup teardown is unguarded where the calltip's identical teardown guards every step | | Under analysis |\n\n### Infrastructure: redirector, file list, debugger, trees (9)\n\n`redirector.py`, `filelist.py`, `debugger*.py`, `tree.py`, `stackviewer.py` — [full reports](https://gist.github.com/devdanzin/85d7c940ad8bb3c068f28c3c21d63970)\n\n| # | Sev | Location | Finding | Prior art | Status |\n|---|---|---|---|---|---|\n| [34](https://gist.github.com/devdanzin/85d7c940ad8bb3c068f28c3c21d63970#34--widgetredirector-swallows-every-tclerror-so-textindex-can-never-raise-on-any-idle-widget) | FIX | `redirector.py:116` | WidgetRedirector swallows every TclError, so text.index() can never raise on any IDLE widget | | Under analysis |\n| [54](https://gist.github.com/devdanzin/85d7c940ad8bb3c068f28c3c21d63970#54--after-a-name-conflict-the-displaced-window-is-marked-none-instead-of-re-pointed-so-the-next-collision-is-silent) | FIX | `filelist.py:90` | After a Name Conflict the displaced window is marked None instead of re-pointed, so the NEXT collision is silent | | Under analysis |\n| [55](https://gist.github.com/devdanzin/85d7c940ad8bb3c068f28c3c21d63970#55--dictproxygetitem-returns-a-repr-and-only-one-of-its-two-consumers-strips-the-extra-quotes) | FIX | `debugger_r.py:271` | DictProxy.__getitem__ returns a repr, and only one of its two consumers strips the extra quotes | | Under analysis |\n| [16](https://gist.github.com/devdanzin/85d7c940ad8bb3c068f28c3c21d63970#16--a-failed-getcwd-silently-yields-a-relative-path-used-as-a-window-identity-key) | CONSIDER | `filelist.py:105-108` | A failed getcwd() silently yields a relative path used as a window identity key | | Under analysis |\n| [22](https://gist.github.com/devdanzin/85d7c940ad8bb3c068f28c3c21d63970#22--debuggerclose-swallows-every-failure-of-quit) | CONSIDER | `debugger.py:159-162` | Debugger.close swallows every failure of quit() | | Under analysis |\n| [25](https://gist.github.com/devdanzin/85d7c940ad8bb3c068f28c3c21d63970#25--idbuser_exception-calls-into-the-gui-unguarded-where-its-twin-is-guarded) | CONSIDER | `debugger.py:55-56` | Idb.user_exception calls into the GUI unguarded where its twin is guarded | | Under analysis |\n| [56](https://gist.github.com/devdanzin/85d7c940ad8bb3c068f28c3c21d63970#56--four-id-keyed-debugger-tables-are-never-cleared-so-memory-grows-with-every-debugger-stop) | CONSIDER | `debugger_r.py:35` | Four id()-keyed debugger tables are never cleared, so memory grows with every debugger stop | | Under analysis |\n| [57](https://gist.github.com/devdanzin/85d7c940ad8bb3c068f28c3c21d63970#57--tree-redraw-re-binds-every-nodes-canvas-item-and-never-deletes-the-bindings) | CONSIDER | `tree.py:234` | Tree redraw re-binds every node's canvas item and never deletes the bindings | | Under analysis |\n| [70](https://gist.github.com/devdanzin/85d7c940ad8bb3c068f28c3c21d63970#70--stack-viewer-module-globals-pin-every-frame-of-the-last-exception-for-the-process-lifetime) | CONSIDER | `stackviewer.py:12` | Stack Viewer module globals pin every frame of the last exception for the process lifetime | | Under analysis |\n\n### Documentation and the generated in-app help (6)\n\n`Doc/library/idle.rst`, `help.py`, `help.html`, `config-main.def` — [full reports](https://gist.github.com/devdanzin/e3d3dbbedc0f7a310747a550515fcb87)\n\n| # | Sev | Location | Finding | Prior art | Status |\n|---|---|---|---|---|---|\n| [37](https://gist.github.com/devdanzin/e3d3dbbedc0f7a310747a550515fcb87#37--the-documented-sysargv0-contract-for-idle--r-is-wrong-and-idle--h-contradicts-it-correctly) | FIX | `Doc/library/idle.rst:731-732` | The documented sys.argv[0] contract for `idle -r` is wrong, and `idle -h` contradicts it correctly | | Under analysis |\n| [38](https://gist.github.com/devdanzin/e3d3dbbedc0f7a310747a550515fcb87#38--the-network-diagnostic-in-the-docs-names-a-port-idle-has-never-listened-on) | FIX | `Doc/library/idle.rst:752` | The network diagnostic in the docs names a port IDLE has never listened on | | Under analysis |\n| [39](https://gist.github.com/devdanzin/e3d3dbbedc0f7a310747a550515fcb87#39--the-in-app-help-is-generated-correctly-so-every-documentation-error-is-faithfully-shipped) | CONSIDER | `help.py:251` | The in-app help is generated correctly, so every documentation error is faithfully shipped | | Under analysis |\n| [40](https://gist.github.com/devdanzin/e3d3dbbedc0f7a310747a550515fcb87#40--documentation-still-names-ui-that-was-renamed-or-split-two-releases-ago) | CONSIDER | `Doc/library/idle.rst` | Documentation still names UI that was renamed or split two releases ago | | Under analysis |\n| [41](https://gist.github.com/devdanzin/e3d3dbbedc0f7a310747a550515fcb87#41--four-config-options-are-fully-supported-and-completely-invisible-and-one-has-no-consumer) | CONSIDER | `config-main.def:48` | Four config options are fully supported and completely invisible, and one has no consumer | | Under analysis |\n| [44](https://gist.github.com/devdanzin/e3d3dbbedc0f7a310747a550515fcb87#44--three-virtual-events-are-declared-but-unreachable-one-of-them-from-a-live-menu) | CONSIDER | `mainmenu.py:80` | Three virtual events are declared but unreachable, one of them from a live menu | | Under analysis |\n\n### Test-suite integrity (4)\n\n`idle_test/` — [full reports](https://gist.github.com/devdanzin/f5c7aee89c8518ff0cc95ec1ca1b1441)\n\n| # | Sev | Location | Finding | Prior art | Status |\n|---|---|---|---|---|---|\n| [26](https://gist.github.com/devdanzin/f5c7aee89c8518ff0cc95ec1ca1b1441#26--five-tests-in-the-suite-cannot-fail) | CONSIDER | `idle_test/test_autocomplete.py:241` | Five tests in the suite cannot fail | | Fixed |\n| [71](https://gist.github.com/devdanzin/f5c7aee89c8518ff0cc95ec1ca1b1441#71--the-shared-test-stubs-cannot-express-the-conditions-the-guards-under-test-exist-for) | CONSIDER | `idle_test/mock_idle.py:48` | The shared test stubs cannot express the conditions the guards under test exist for | | Under analysis |\n| [72](https://gist.github.com/devdanzin/f5c7aee89c8518ff0cc95ec1ca1b1441#72--a-test-class-freezes-textindex-to-a-constant-leaving-seven-mutations-of-live-code-undetected) | CONSIDER | `idle_test/test_searchengine.py:279` | A test class freezes text.index to a constant, leaving seven mutations of live code undetected | | Under analysis |\n| [73](https://gist.github.com/devdanzin/f5c7aee89c8518ff0cc95ec1ca1b1441#73--four-test-files-exit-0-even-when-their-tests-fail) | CONSIDER | `idle_test/test_undo.py` | Four test files exit 0 even when their tests fail | | Fixed |\n\n## Excluded — please don't pursue these\n\nFound by the review and then dropped — three because they are already reported, one because main already fixed it. Listed only so the same ground isn't covered twice:\n\n| Finding | Why it is not in the tables |\n|---|---|\n| Custom run arguments are corrupted by a Tcl list round-trip (`query.py:352,368-376`) | already reported: #93016 |\n| A bare except guards a four-link attribute chain (`autocomplete.py:173-175`) | already reported: #59518 |\n| `\u003c\u003cpython-context-help>>` is offered in Settings, bound by nothing, and has never had a handler (`config.py:614`) | already reported: #88740 |\n| Configure IDLE → Keys raises `KeyError` for any third-party extension that ships disabled (`config.py:486` on 3.14) | **fixed on main** by gh-89520 / GH-28713 — `GetExtensionKeys` now uses `current_keyset.get(event, None)`. Still present on the 3.14 branch; a backport may be wanted. |\n\n## Disclosure & caveats\n\n- The reports were **drafted with AI assistance (Claude Code)**; each gist carries an explicit disclaimer. Before publishing, every cited line was re-read in the tree at the stated commit, and every \"Verified\" transcript was produced by running the code.\n- That re-verification changed three findings, which is the reason it is worth mentioning: [59](https://gist.github.com/devdanzin/885741290c23c12256f11db69ba0dfb2#59--_study1-has-no-f-string-state-so-a-pep-701-multi-line-f-string-is-read-as-three-statements) was upgraded from an argument to a reproduction by a differential its author had not run; a fourth claim (about how many test files return 0 on failure) was **wrong by an order of magnitude** and is corrected in [73](https://gist.github.com/devdanzin/f5c7aee89c8518ff0cc95ec1ca1b1441#73--four-test-files-exit-0-even-when-their-tests-fail); and two line numbers were off.\n- **[33](https://gist.github.com/devdanzin/9728d51e72efafc9dc38a8ce54e33b06#33--under-idle--n-file-is-silently-idles-own-path-instead-of-the-scripts) is deliberate in part.** The commit that introduced the `-n` exclusion says so in its own message. What is reported is only the part that commit did not consider: under `-n` the name is not absent, it is IDLE's own entry point.\n- Severities are the reviewer's, not a maintainer's. `CONSIDER` items in particular are judgement calls and several may be intentional; say so and I'll annotate them.\n\n*Each finding is also classified against a catalogue of recurring Python bug shapes; the shape name in each gist entry (`zip-truncates-on-length-mismatch`, `per-line-property-derived-from-the-aggregate`, …) is what let the review hunt siblings of a confirmed defect rather than stop at the first instance. Several rows here were found that way.*\n\n\n\n### CPython versions tested on:\n\nCPython main branch\n\n### Operating systems tested on:\n\nLinux\n","author":{"url":"https://github.com/devdanzin","@type":"Person","name":"devdanzin"},"datePublished":"2026-07-27T08:43:52Z","url":"https://github.com/python/cpython/issues/154760"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:ebf24595-b1de-1bf3-ae5f-80f38190fd96 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C9BC:1FE434:160D268:1D1901E:6B01FE6E |
| html-safe-nonce | 1e21760adc1eae2df8389595b79e093e60e12f6862ae0f3cb0140b531e0c76db |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUJDOjFGRTQzNDoxNjBEMjY4OjFEMTkwMUU6NkIwMUZFNkUiLCJ2aXNpdG9yX2lkIjoiODI1NTQ2MzI3MjU4OTk1MDU3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 55560615b472fa632c60a87e97dac609b8385686c6d43823fc1a1727676d215a |
| hovercard-subject-tag | issue:4986072340 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/154760/issue_layout |
| twitter:image | https://opengraph.githubassets.com/631518d953ca019de27dd5a4c830dd758cb09025f1ba2b77e6e4cb814e876898/python/cpython/issues/154760 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/631518d953ca019de27dd5a4c830dd758cb09025f1ba2b77e6e4cb814e876898/python/cpython/issues/154760 |
| og:image:alt | Bug report Bug description: A two-pass review of Lib/idlelib turned up 69 findings — 37 FIX (a wrong result, silent data loss, or an unreachable feature) and 32 CONSIDER. Every one carries a file:l... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | devdanzin |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width