René's URL Explorer Experiment


Title: profiling.sampling heatmap reads non-regular and oversized files · Issue #153838 · python/cpython · GitHub

Open Graph Title: profiling.sampling heatmap reads non-regular and oversized files · Issue #153838 · python/cpython

X Title: profiling.sampling heatmap reads non-regular and oversized files · Issue #153838 · python/cpython

Description: Bug description The heatmap exporter in profiling.sampling reads source files named in a profile unconditionally via Path(filename).read_text(). It does not check whether the path is a regular file or whether the file size is reasonable....

Open Graph Description: Bug description The heatmap exporter in profiling.sampling reads source files named in a profile unconditionally via Path(filename).read_text(). It does not check whether the path is a regular file...

X Description: Bug description The heatmap exporter in profiling.sampling reads source files named in a profile unconditionally via Path(filename).read_text(). It does not check whether the path is a regular file...

Opengraph URL: https://github.com/python/cpython/issues/153838

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"profiling.sampling heatmap reads non-regular and oversized files","articleBody":"### Bug description\n\nThe heatmap exporter in `profiling.sampling` reads source files named in a profile unconditionally via `Path(filename).read_text()`. It does not check whether the path is a regular file or whether the file size is reasonable.\n\nWhen replaying a binary profile, a filename pointing to a device file (e.g. `/dev/zero`) causes unbounded memory growth. An oversized file has the same effect.\n\nThe fix adds an `is_file()` guard and a 10 MB size cap before reading, consistent with the binary reader hardening in gh-152718.\n\n### CPython versions tested on\n\nmain\n\n### Operating systems tested on\n\nmacOS\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-153839\n* gh-158853\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/tonghuaroot","@type":"Person","name":"tonghuaroot"},"datePublished":"2026-07-17T09:58:57Z","url":"https://github.com/python/cpython/issues/153838"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:a6fc4c14-4a19-d54c-83bc-f150c2a6f9f2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9C08:2F543F:1ACF6CF:236B94C:6B021B9D
html-safe-nonceef5a3c5840b1bbf2928c8c8e74e0b096ac0041e9dd8c607e9f184f1f41f837bd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzA4OjJGNTQzRjoxQUNGNkNGOjIzNkI5NEM6NkIwMjFCOUQiLCJ2aXNpdG9yX2lkIjoiNjg0MjQyMTA5ODA4NTIyNzQyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1d9073f68ba21f4d7fc22714a3dfd9f8f902f10cd6aef27bc0bbd6c03325bc9e
hovercard-subject-tagissue:4910233626
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/153838/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c0c48ef38751654e2d84cbcf3b9d3f63906eaa2652d5e194792b66b2f6d7ddc3/python/cpython/issues/153838
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c0c48ef38751654e2d84cbcf3b9d3f63906eaa2652d5e194792b66b2f6d7ddc3/python/cpython/issues/153838
og:image:altBug description The heatmap exporter in profiling.sampling reads source files named in a profile unconditionally via Path(filename).read_text(). It does not check whether the path is a regular file...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametonghuaroot
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/153838#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F153838
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F153838
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/153838
Reloadhttps://github.com/python/cpython/issues/153838
Reloadhttps://github.com/python/cpython/issues/153838
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/153838
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/153838
#153839https://github.com/python/cpython/pull/153839
profiling.sampling heatmap reads non-regular and oversized fileshttps://github.com/python/cpython/issues/153838#top
#153839https://github.com/python/cpython/pull/153839
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
topic-profilinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-profiling%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com/tonghuaroot
tonghuaroothttps://github.com/tonghuaroot
on Jul 17, 2026https://github.com/python/cpython/issues/153838#issue-4910233626
gh-152718https://github.com/python/cpython/issues/152718
gh-153838: Skip non-regular source files in the heatmap exporter #153839https://github.com/python/cpython/pull/153839
[3.15] gh-153838: Skip non-regular source files in the heatmap exporter (GH-153839) #158853https://github.com/python/cpython/pull/158853
https://github.com/picnixz
picnixzhttps://github.com/picnixz
on Jul 17, 2026https://github.com/python/cpython/issues/153838#issuecomment-5001911839
picnixzhttps://github.com/picnixz
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
pendingThe issue will be closed if no feedback is providedhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22pending%22
topic-profilinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-profiling%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
on Jul 17, 2026https://github.com/python/cpython/issues/153838#event-28115262419
https://github.com/tonghuaroot
tonghuaroothttps://github.com/tonghuaroot
on Jul 17, 2026https://github.com/python/cpython/issues/153838#issuecomment-5002022687
picnixzhttps://github.com/picnixz
pendingThe issue will be closed if no feedback is providedhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22pending%22
on Jul 17, 2026https://github.com/python/cpython/issues/153838#event-28115922824
pablogsalhttps://github.com/pablogsal
on Oct 5, 2026https://github.com/python/cpython/issues/153838#event-32515172025
pythongh-153838: Verify non-regular sources are never openedhttps://github.com/tonghuaroot/cpython/commit/1408d115717699a75fb58b0f3eed981afebc5f90
pythongh-153838https://github.com/python/cpython/issues/153838
1408d11https://github.com/tonghuaroot/cpython/commit/1408d115717699a75fb58b0f3eed981afebc5f90
gh-153838: Skip non-regular source files in the heatmap exporter (#15…https://github.com/python/cpython/commit/722687092f8aaa005708302a502e930a729e8660
gh-153838https://github.com/python/cpython/issues/153838
#15…https://github.com/python/cpython/pull/153839
7226870https://github.com/python/cpython/commit/722687092f8aaa005708302a502e930a729e8660
pablogsalhttps://github.com/pablogsal
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#153839https://github.com/python/cpython/pull/153839
on Oct 5, 2026https://github.com/python/cpython/issues/153838#event-32519073729
pablogsalhttps://github.com/pablogsal
on Oct 5, 2026https://github.com/python/cpython/issues/153838#event-32519586206
[3.15] gh-153838: Skip non-regular source files in the heatmap export…https://github.com/python/cpython/commit/48998df2510c0daa837f98bbbbe6cc49ef60dc43
gh-153838https://github.com/python/cpython/issues/153838
48998dfhttps://github.com/python/cpython/commit/48998df2510c0daa837f98bbbbe6cc49ef60dc43
Revert "[3.15] pythongh-153838: Skip non-regular source files in the …https://github.com/pablogsal/cpython/commit/5eb436cd9b047c56aa93f49dcb635c6b64618d17
pythongh-153838https://github.com/python/cpython/issues/153838
5eb436chttps://github.com/pablogsal/cpython/commit/5eb436cd9b047c56aa93f49dcb635c6b64618d17
[3.15] Restore deferred backports for 3.15.1, including GH-158874 (#1…https://github.com/python/cpython/commit/4ceb3faf2c1f5bf17c56be085c4b1c1b38e47f9e
GH-158874https://github.com/python/cpython/pull/158874
#1…https://github.com/python/cpython/pull/158882
4ceb3fahttps://github.com/python/cpython/commit/4ceb3faf2c1f5bf17c56be085c4b1c1b38e47f9e
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/153838
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/153838
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
topic-profilinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-profiling%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.