Title: `asyncio.create_connection()` leaks the socket if the transport cannot be created · Issue #153133 · python/cpython · GitHub
Open Graph Title: `asyncio.create_connection()` leaks the socket if the transport cannot be created · Issue #153133 · python/cpython
X Title: `asyncio.create_connection()` leaks the socket if the transport cannot be created · Issue #153133 · python/cpython
Description: Bug report Bug description: Bug description BaseEventLoop._create_connection_transport() closes the socket only if await waiter fails: try: await waiter except: transport.close() raise If sock.setblocking(), protocol_factory() or _make_*...
Open Graph Description: Bug report Bug description: Bug description BaseEventLoop._create_connection_transport() closes the socket only if await waiter fails: try: await waiter except: transport.close() raise If sock.setb...
X Description: Bug report Bug description: Bug description BaseEventLoop._create_connection_transport() closes the socket only if await waiter fails: try: await waiter except: transport.close() raise If sock.setb...
Opengraph URL: https://github.com/python/cpython/issues/153133
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`asyncio.create_connection()` leaks the socket if the transport cannot be created","articleBody":"# Bug report\n\n### Bug description:\n\n#### Bug description\n\n`BaseEventLoop._create_connection_transport()` closes the socket only if await waiter fails:\n\n```python\ntry:\n await waiter\nexcept:\n transport.close()\n raise\n```\n\nIf `sock.setblocking()`, `protocol_factory()` or `_make_*_transport()` raises before the transport exists, the socket is never closed\n\n#### Reproducer\n\n```python\nimport asyncio\nimport socket\n\n\nasync def main():\n loop = asyncio.get_running_loop()\n sock = socket.socket()\n try:\n await loop.create_connection(lambda: 1 / 0, sock=sock)\n except ZeroDivisionError:\n pass\n print(\"leak: socket not closed\" if sock.fileno() != -1 else \"ok: closed\")\n sock.close()\n\n\nasyncio.run(main())\n```\n\nExpected: `ok: closed` but actually: `leak: socket not closed`\n\n\n#### Proposed fix\n\nClose the socket on error when the transport hasn't been created yet:\n\n```python\nasync def _create_connection_transport(\n self, sock, protocol_factory, ssl,\n server_hostname, server_side=False,\n ssl_handshake_timeout=None,\n ssl_shutdown_timeout=None, context=None):\n\n transport = None\n try:\n sock.setblocking(False)\n context = context if context is not None else contextvars.copy_context()\n\n protocol = protocol_factory()\n waiter = self.create_future()\n if ssl:\n sslcontext = None if isinstance(ssl, bool) else ssl\n transport = self._make_ssl_transport(\n sock, protocol, sslcontext, waiter,\n server_side=server_side, server_hostname=server_hostname,\n ssl_handshake_timeout=ssl_handshake_timeout,\n ssl_shutdown_timeout=ssl_shutdown_timeout,\n context=context)\n else:\n transport = self._make_socket_transport(sock, protocol, waiter, context=context)\n\n await waiter\n except:\n if transport is None:\n sock.close()\n else:\n transport.close()\n raise\n\n return transport, protocol\n```\n\nI have a fix ready\n\n### CPython versions tested on:\n\nCPython main branch\n\n### Operating systems tested on:\n\nmacOS\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-153134\n* gh-154631\n* gh-154897\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/deadlovelll","@type":"Person","name":"deadlovelll"},"datePublished":"2026-07-05T14:37:32Z","url":"https://github.com/python/cpython/issues/153133"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:92df4edd-79e6-504f-87ff-ccdf142bcb76 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8450:62F48:161FA3F:1D15DD4:6B0231AD |
| html-safe-nonce | 407b2e558f2bab9df5b0ff83f4fd0ef922df3a465e8e6b48e670f54577a11840 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDUwOjYyRjQ4OjE2MUZBM0Y6MUQxNURENDo2QjAyMzFBRCIsInZpc2l0b3JfaWQiOiI3MzI3MjkyMzA3NDM0NTAwMjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 000c6efcafd7a961dad7ca03920bb1db2444a17ee97182bab3766f3a27337b8e |
| hovercard-subject-tag | issue:4813231317 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/153133/issue_layout |
| twitter:image | https://opengraph.githubassets.com/942441959233681501ef94e44bfa3f2672bb9d4b2d44340bac6c66985498c1fa/python/cpython/issues/153133 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/942441959233681501ef94e44bfa3f2672bb9d4b2d44340bac6c66985498c1fa/python/cpython/issues/153133 |
| og:image:alt | Bug report Bug description: Bug description BaseEventLoop._create_connection_transport() closes the socket only if await waiter fails: try: await waiter except: transport.close() raise If sock.setb... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | deadlovelll |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width