René's URL Explorer Experiment


Title: `asyncio.create_connection()` leaks the socket if the transport cannot be created · Issue #153133 · python/cpython · GitHub

Open Graph Title: `asyncio.create_connection()` leaks the socket if the transport cannot be created · Issue #153133 · python/cpython

X Title: `asyncio.create_connection()` leaks the socket if the transport cannot be created · Issue #153133 · python/cpython

Description: Bug report Bug description: Bug description BaseEventLoop._create_connection_transport() closes the socket only if await waiter fails: try: await waiter except: transport.close() raise If sock.setblocking(), protocol_factory() or _make_*...

Open Graph Description: Bug report Bug description: Bug description BaseEventLoop._create_connection_transport() closes the socket only if await waiter fails: try: await waiter except: transport.close() raise If sock.setb...

X Description: Bug report Bug description: Bug description BaseEventLoop._create_connection_transport() closes the socket only if await waiter fails: try: await waiter except: transport.close() raise If sock.setb...

Opengraph URL: https://github.com/python/cpython/issues/153133

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`asyncio.create_connection()` leaks the socket if the transport cannot be created","articleBody":"# Bug report\n\n### Bug description:\n\n#### Bug description\n\n`BaseEventLoop._create_connection_transport()` closes the socket only if await waiter fails:\n\n```python\ntry:\n    await waiter\nexcept:\n    transport.close()\n    raise\n```\n\nIf `sock.setblocking()`, `protocol_factory()` or `_make_*_transport()` raises before the transport exists, the socket is never closed\n\n#### Reproducer\n\n```python\nimport asyncio\nimport socket\n\n\nasync def main():\n    loop = asyncio.get_running_loop()\n    sock = socket.socket()\n    try:\n        await loop.create_connection(lambda: 1 / 0, sock=sock)\n    except ZeroDivisionError:\n        pass\n    print(\"leak: socket not closed\" if sock.fileno() != -1 else \"ok: closed\")\n    sock.close()\n\n\nasyncio.run(main())\n```\n\nExpected: `ok: closed` but actually: `leak: socket not closed`\n\n\n#### Proposed fix\n\nClose the socket on error when the transport hasn't been created yet:\n\n```python\nasync def _create_connection_transport(\n        self, sock, protocol_factory, ssl,\n        server_hostname, server_side=False,\n        ssl_handshake_timeout=None,\n        ssl_shutdown_timeout=None, context=None):\n\n    transport = None\n    try:\n        sock.setblocking(False)\n        context = context if context is not None else contextvars.copy_context()\n\n        protocol = protocol_factory()\n        waiter = self.create_future()\n        if ssl:\n            sslcontext = None if isinstance(ssl, bool) else ssl\n            transport = self._make_ssl_transport(\n                sock, protocol, sslcontext, waiter,\n                server_side=server_side, server_hostname=server_hostname,\n                ssl_handshake_timeout=ssl_handshake_timeout,\n                ssl_shutdown_timeout=ssl_shutdown_timeout,\n                context=context)\n        else:\n            transport = self._make_socket_transport(sock, protocol, waiter, context=context)\n\n        await waiter\n    except:\n        if transport is None:\n            sock.close()\n        else:\n            transport.close()\n        raise\n\n    return transport, protocol\n```\n\nI have a fix ready\n\n### CPython versions tested on:\n\nCPython main branch\n\n### Operating systems tested on:\n\nmacOS\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-153134\n* gh-154631\n* gh-154897\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/deadlovelll","@type":"Person","name":"deadlovelll"},"datePublished":"2026-07-05T14:37:32Z","url":"https://github.com/python/cpython/issues/153133"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:92df4edd-79e6-504f-87ff-ccdf142bcb76
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8450:62F48:161FA3F:1D15DD4:6B0231AD
html-safe-nonce407b2e558f2bab9df5b0ff83f4fd0ef922df3a465e8e6b48e670f54577a11840
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDUwOjYyRjQ4OjE2MUZBM0Y6MUQxNURENDo2QjAyMzFBRCIsInZpc2l0b3JfaWQiOiI3MzI3MjkyMzA3NDM0NTAwMjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac000c6efcafd7a961dad7ca03920bb1db2444a17ee97182bab3766f3a27337b8e
hovercard-subject-tagissue:4813231317
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/153133/issue_layout
twitter:imagehttps://opengraph.githubassets.com/942441959233681501ef94e44bfa3f2672bb9d4b2d44340bac6c66985498c1fa/python/cpython/issues/153133
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/942441959233681501ef94e44bfa3f2672bb9d4b2d44340bac6c66985498c1fa/python/cpython/issues/153133
og:image:altBug report Bug description: Bug description BaseEventLoop._create_connection_transport() closes the socket only if await waiter fails: try: await waiter except: transport.close() raise If sock.setb...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedeadlovelll
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/153133#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F153133
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F153133
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/153133
Reloadhttps://github.com/python/cpython/issues/153133
Reloadhttps://github.com/python/cpython/issues/153133
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/153133
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/153133
asyncio.create_connection() leaks the socket if the transport cannot be createdhttps://github.com/python/cpython/issues/153133#top
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
topic-asynciohttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-asyncio%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/deadlovelll
deadlovelllhttps://github.com/deadlovelll
on Jul 5, 2026https://github.com/python/cpython/issues/153133#issue-4813231317
gh-153133: Fix socket leak in asyncio create_connection #153134https://github.com/python/cpython/pull/153134
[3.15] gh-153133: Fix socket leak in error path of asyncio create_connection (GH-153134) #154631https://github.com/python/cpython/pull/154631
[3.14] gh-153133: Fix socket leak in error path of asyncio create_connection (GH-153134) #154897https://github.com/python/cpython/pull/154897
deadlovelllhttps://github.com/deadlovelll
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
on Jul 5, 2026https://github.com/python/cpython/issues/153133#event-27575102935
sobolevnhttps://github.com/sobolevn
topic-asynciohttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-asyncio%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
on Jul 5, 2026https://github.com/python/cpython/issues/153133#event-27575865132
github-project-automationhttps://github.com/apps/github-project-automation
asynciohttps://github.com/orgs/python/projects/29
on Jul 5, 2026https://github.com/python/cpython/issues/153133#event-27575865746
github-project-automationhttps://github.com/apps/github-project-automation
asynciohttps://github.com/orgs/python/projects/29
on Jul 5, 2026https://github.com/python/cpython/issues/153133
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
on Jul 7, 2026https://github.com/python/cpython/issues/153133#issuecomment-4906292714
https://github.com/deadlovelll
deadlovelllhttps://github.com/deadlovelll
on Jul 7, 2026https://github.com/python/cpython/issues/153133#issuecomment-4907170600
explicitlyhttps://docs.python.org/3/library/socket.html#socket.socket.close:~:text=Sockets%20are%20automatically%20closed%20when%20they%20are%20garbage%2Dcollected%2C%20but%20it%20is%20recommended%20to%20close()%20them%20explicitly%2C%20or%20to%20use%20a%20with%20statement%20around%20them.
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
on Jul 7, 2026https://github.com/python/cpython/issues/153133#issuecomment-4907753840
kumaraditya303https://github.com/kumaraditya303
on Jul 7, 2026https://github.com/python/cpython/issues/153133#event-27681599144
gh-153133: Fix socket leak in error path of asyncio create_connection (…https://github.com/python/cpython/commit/374920a23d49130f446fe6369220bc548be57cd2
gh-153133https://github.com/python/cpython/issues/153133
…https://github.com/python/cpython/pull/153134
374920ahttps://github.com/python/cpython/commit/374920a23d49130f446fe6369220bc548be57cd2
kumaraditya303https://github.com/kumaraditya303
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jul 7, 2026https://github.com/python/cpython/issues/153133#event-27681608816
github-project-automationhttps://github.com/apps/github-project-automation
asynciohttps://github.com/orgs/python/projects/29
on Jul 7, 2026https://github.com/python/cpython/issues/153133
https://github.com/deadlovelll
deadlovelllhttps://github.com/deadlovelll
on Jul 7, 2026https://github.com/python/cpython/issues/153133#issuecomment-4907937022
kumaraditya303https://github.com/kumaraditya303
on Jul 25, 2026https://github.com/python/cpython/issues/153133#event-28466200146
[3.15] gh-153133: Fix socket leak in error path of asyncio create_con…https://github.com/python/cpython/commit/b4d0b2621a97f8433e25bb88cbd9c815fff7abe0
gh-153133https://github.com/python/cpython/issues/153133
b4d0b26https://github.com/python/cpython/commit/b4d0b2621a97f8433e25bb88cbd9c815fff7abe0
kumaraditya303https://github.com/kumaraditya303
on Aug 5, 2026https://github.com/python/cpython/issues/153133#event-29017830374
[3.14] gh-153133: Fix socket leak in error path of asyncio create_con…https://github.com/python/cpython/commit/162bd7ea554c274de94815b75e44e68dbfabcf08
gh-153133https://github.com/python/cpython/issues/153133
162bd7ehttps://github.com/python/cpython/commit/162bd7ea554c274de94815b75e44e68dbfabcf08
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/153133
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/153133
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
topic-asynciohttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-asyncio%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
asynciohttps://github.com/orgs/python/projects/29
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.