René's URL Explorer Experiment


Title: datetime.fromisoformat() raises AssertionError instead of ValueError in the pure-Python implementation · Issue #152060 · python/cpython · GitHub

Open Graph Title: datetime.fromisoformat() raises AssertionError instead of ValueError in the pure-Python implementation · Issue #152060 · python/cpython

X Title: datetime.fromisoformat() raises AssertionError instead of ValueError in the pure-Python implementation · Issue #152060 · python/cpython

Description: Bug report Bug description: The pure-Python datetime.fromisoformat() raises a bare AssertionError for some malformed strings, where the C accelerator correctly raises ValueError. fromisoformat is documented to raise ValueError for invali...

Open Graph Description: Bug report Bug description: The pure-Python datetime.fromisoformat() raises a bare AssertionError for some malformed strings, where the C accelerator correctly raises ValueError. fromisoformat is d...

X Description: Bug report Bug description: The pure-Python datetime.fromisoformat() raises a bare AssertionError for some malformed strings, where the C accelerator correctly raises ValueError. fromisoformat is d...

Opengraph URL: https://github.com/python/cpython/issues/152060

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"datetime.fromisoformat() raises AssertionError instead of ValueError in the pure-Python implementation","articleBody":"# Bug report\n\n### Bug description:\n\nThe pure-Python `datetime.fromisoformat()` raises a bare `AssertionError` for some\nmalformed strings, where the C accelerator correctly raises `ValueError`. `fromisoformat`\nis documented to raise `ValueError` for invalid input only.\n\n```python\n>>> import _pydatetime, _datetime\n>>> _pydatetime.datetime.fromisoformat('2020-2020')\nTraceback (most recent call last):\n  ...\nAssertionError\n>>> _datetime.datetime.fromisoformat('2020-2020')\nTraceback (most recent call last):\n  ...\nValueError: Invalid isoformat string: '2020-2020'\n```\n\n`'2020-1234'` triggers the same divergence.\n\nBecause the failing check is an `assert`, it is stripped under `python -O`, so the\nbehaviour also differs by build flag:\n\n```\n$ python -O -c \"import _pydatetime; _pydatetime.datetime.fromisoformat('2020-2020')\"\nValueError: Invalid isoformat string: '2020-2020'\n```\n\n### Root cause\n\nFor a 9-character input such as `'2020-2020'`, `datetime.fromisoformat()` calls\n`_find_isoformat_datetime_separator()`, which (seeing a `-` at index 4 and a non-`W` at\nindex 5) returns 10 — the `YYYY-MM-DD` branch. The date portion slice is then the full\n9-character string, and `_parse_isoformat_date()` trips its\n`assert len(dtstr) in (7, 8, 10)`. The caller's `except ValueError` does not catch\n`AssertionError`, so it escapes.\n\nThis is the sibling assert site to gh-151770 (an assert reached via the `24:00`\nmidnight-rollover path with an out-of-range month), which was fixed in #151771. The\npresent site is a different location and a different input class.\n\n### Suggested fix\n\nReplace the bare assert in `_parse_isoformat_date()` with an explicit `ValueError` whose\nmessage matches the C implementation. `date.fromisoformat()` already length-checks before\ncalling `_parse_isoformat_date()`, so it is unaffected; `datetime.fromisoformat()`\nre-wraps the `ValueError` with the full input string, producing the same message as the C\naccelerator.\n\nI have a patch and a regression test (added to `test_fromisoformat_fails_datetime`, which\nruns under both the C and pure-Python test classes) ready.\n\n### CPython versions tested on:\n\n3.16 (main, built from source)\n\n### Operating systems tested on:\n\nmacOS\n\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-152061\n* gh-152081\n* gh-152786\n* gh-152787\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/tonghuaroot","@type":"Person","name":"tonghuaroot"},"datePublished":"2026-06-24T10:46:13Z","url":"https://github.com/python/cpython/issues/152060"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:14887073-ba2c-4e87-258c-26a7a564077d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9484:19AA62:399FD6D:4924556:6B01F79B
html-safe-nonce85ffb00baa477544d1341a96208cde7b2aa6d50af4e671ce80ccdce362375135
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDg0OjE5QUE2MjozOTlGRDZEOjQ5MjQ1NTY6NkIwMUY3OUIiLCJ2aXNpdG9yX2lkIjoiNzE2NjE4MTc5NzM1MTUyMDE1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac30b05147c7b495dd22c830707a5a2c318e94f87cf333c9e7006942f71d42929a
hovercard-subject-tagissue:4734058361
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/152060/issue_layout
twitter:imagehttps://opengraph.githubassets.com/1e60b9ce3a07b5300721bf5d48546c361ad18a34f9e5010fdbc680ca079358f4/python/cpython/issues/152060
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1e60b9ce3a07b5300721bf5d48546c361ad18a34f9e5010fdbc680ca079358f4/python/cpython/issues/152060
og:image:altBug report Bug description: The pure-Python datetime.fromisoformat() raises a bare AssertionError for some malformed strings, where the C accelerator correctly raises ValueError. fromisoformat is d...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametonghuaroot
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/152060#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F152060
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F152060
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/152060
Reloadhttps://github.com/python/cpython/issues/152060
Reloadhttps://github.com/python/cpython/issues/152060
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/152060
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/152060
#152061https://github.com/python/cpython/pull/152061
datetime.fromisoformat() raises AssertionError instead of ValueError in the pure-Python implementationhttps://github.com/python/cpython/issues/152060#top
#152061https://github.com/python/cpython/pull/152061
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/tonghuaroot
tonghuaroothttps://github.com/tonghuaroot
on Jun 24, 2026https://github.com/python/cpython/issues/152060#issue-4734058361
gh-151770https://github.com/python/cpython/issues/151770
#151771https://github.com/python/cpython/pull/151771
gh-152060: Fix datetime.fromisoformat() raising AssertionError in pure Python #152061https://github.com/python/cpython/pull/152061
[3.15] gh-152060: Fix _pydatetime.fromisoformat() raising AssertionError on invalid lengths (GH-152061) #152081https://github.com/python/cpython/pull/152081
[3.14] gh-152060: Fix _pydatetime.fromisoformat() raising AssertionError on invalid lengths (GH-152061) #152786https://github.com/python/cpython/pull/152786
[3.13] gh-152060: Fix _pydatetime.fromisoformat() raising AssertionError on invalid lengths (GH-152061) #152787https://github.com/python/cpython/pull/152787
StanFromIrelandhttps://github.com/StanFromIreland
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
on Jun 24, 2026https://github.com/python/cpython/issues/152060#event-27140641141
StanFromIrelandhttps://github.com/StanFromIreland
Date and time issues 🕰️https://github.com/orgs/python/projects/21
on Jun 24, 2026https://github.com/python/cpython/issues/152060#event-27140647344
tonghuaroothttps://github.com/tonghuaroot
on Jun 24, 2026https://github.com/python/cpython/issues/152060#event-27144934318
pythongh-152060: Address review — simplify error message, drop duplic…https://github.com/tonghuaroot/cpython/commit/e203639e9045b1d7ff2e58e3744995e3a5372675
pythongh-152060https://github.com/python/cpython/issues/152060
e203639https://github.com/tonghuaroot/cpython/commit/e203639e9045b1d7ff2e58e3744995e3a5372675
StanFromIrelandhttps://github.com/StanFromIreland
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#152061https://github.com/python/cpython/pull/152061
on Jun 24, 2026https://github.com/python/cpython/issues/152060#event-27147697693
StanFromIrelandhttps://github.com/StanFromIreland
on Jun 24, 2026https://github.com/python/cpython/issues/152060#event-27147697718
gh-152060: Fix `_pydatetime.fromisoformat()` raising `AssertionError`…https://github.com/python/cpython/commit/ff781d52d451db56e154aac35ae7f2c41b1695a4
gh-152060https://github.com/python/cpython/issues/152060
ff781d5https://github.com/python/cpython/commit/ff781d52d451db56e154aac35ae7f2c41b1695a4
github-project-automationhttps://github.com/apps/github-project-automation
Date and time issues 🕰️https://github.com/orgs/python/projects/21
on Jun 24, 2026https://github.com/python/cpython/issues/152060
StanFromIrelandhttps://github.com/StanFromIreland
on Jun 24, 2026https://github.com/python/cpython/issues/152060#event-27147760659
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
on Jun 24, 2026https://github.com/python/cpython/issues/152060#issuecomment-4789908919
StanFromIrelandhttps://github.com/StanFromIreland
on Jun 24, 2026https://github.com/python/cpython/issues/152060#event-27149082645
[3.15] gh-152060: Fix `_pydatetime.fromisoformat()` raising `Assertio…https://github.com/python/cpython/commit/8146fa4727314cb32af5eb53bb4f4a3fa8c6fe26
gh-152060https://github.com/python/cpython/issues/152060
8146fa4https://github.com/python/cpython/commit/8146fa4727314cb32af5eb53bb4f4a3fa8c6fe26
StanFromIrelandhttps://github.com/StanFromIreland
on Jul 1, 2026https://github.com/python/cpython/issues/152060#event-27444708047
[3.13] gh-152060: Fix `_pydatetime.fromisoformat()` raising `Assertio…https://github.com/python/cpython/commit/f05bfc3685a803e41dafcdfe1cdf0f33136c6db2
gh-152060https://github.com/python/cpython/issues/152060
f05bfc3https://github.com/python/cpython/commit/f05bfc3685a803e41dafcdfe1cdf0f33136c6db2
[3.14] gh-152060: Fix `_pydatetime.fromisoformat()` raising `Assertio…https://github.com/python/cpython/commit/205dfff87cd09af308351763f2a53a77974a56be
gh-152060https://github.com/python/cpython/issues/152060
205dfffhttps://github.com/python/cpython/commit/205dfff87cd09af308351763f2a53a77974a56be
StanFromIrelandhttps://github.com/StanFromIreland
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jul 1, 2026https://github.com/python/cpython/issues/152060#event-27444726330
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/152060
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/152060
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
Date and time issues 🕰️https://github.com/orgs/python/projects/21
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.