René's URL Explorer Experiment


Title: JIT: segfault from `_PyObject_LookupSpecialMethod` · Issue #149459 · python/cpython · GitHub

Open Graph Title: JIT: segfault from `_PyObject_LookupSpecialMethod` · Issue #149459 · python/cpython

X Title: JIT: segfault from `_PyObject_LookupSpecialMethod` · Issue #149459 · python/cpython

Description: Crash report What happened? A JIT-enabled interpreter will crash by running the following code: MRE: def f1(): class Context: def __enter__(self): ... def __exit__(self, e, v, t): ... with Context(): pass for i_f1 in range(4100): f1() Ba...

Open Graph Description: Crash report What happened? A JIT-enabled interpreter will crash by running the following code: MRE: def f1(): class Context: def __enter__(self): ... def __exit__(self, e, v, t): ... with Context(...

X Description: Crash report What happened? A JIT-enabled interpreter will crash by running the following code: MRE: def f1(): class Context: def __enter__(self): ... def __exit__(self, e, v, t): ... with Context(...

Opengraph URL: https://github.com/python/cpython/issues/149459

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"JIT: segfault from `_PyObject_LookupSpecialMethod`","articleBody":"# Crash report\n\n### What happened?\n\nA JIT-enabled interpreter will crash by running the following code:\n\nMRE:\n```python\ndef f1():\n    class Context:\n        def __enter__(self): ...\n        def __exit__(self, e, v, t): ...\n\n    with Context():\n        pass\n\nfor i_f1 in range(4100):\n    f1()\n```\n\nBacktrace:\n```\nProgram received signal SIGSEGV, Segmentation fault.\n0x0000555555c9f8d4 in _Py_TYPE_impl (ob=0x0) at ./Include/object.h:234\n234         return ob->ob_type;\n\n#0  0x0000555555c9f8d4 in _Py_TYPE_impl (ob=0x0) at ./Include/object.h:234\n#1  _PyObject_LookupSpecialMethod (attr=attr@entry=0x555556a2d9d8 \u003c_PyRuntime+80600>, method_and_self=method_and_self@entry=0x7e8ff6de5300) at Objects/typeobject.c:2972\n#2  0x0000555555e95f5c in _PyEval_EvalFrameDefault (tstate=\u003coptimized out>, frame=\u003coptimized out>, throwflag=\u003coptimized out>) at Python/generated_cases.c.h:9933\n#3  0x0000555555e89408 in _PyEval_EvalFrame (tstate=0x555556a72138 \u003c_PyRuntime+361016>, frame=0x7e8ff6de5220, throwflag=0) at ./Include/internal/pycore_ceval.h:122\n#4  _PyEval_Vector (tstate=\u003coptimized out>, func=\u003coptimized out>, locals=\u003coptimized out>, args=\u003coptimized out>, argcount=\u003coptimized out>, kwnames=0x0) at Python/ceval.c:2124\n#5  0x0000555555e88e25 in PyEval_EvalCode (co=\u003coptimized out>, globals=\u003coptimized out>, locals=0x7c7ff6e8a0c0) at Python/ceval.c:686\n#6  0x000055555617a090 in run_eval_code_obj (tstate=tstate@entry=0x555556a72138 \u003c_PyRuntime+361016>, co=co@entry=0x7d1ff6e85f50, globals=globals@entry=0x7c7ff6e8a0c0,\n    locals=locals@entry=0x7c7ff6e8a0c0) at Python/pythonrun.c:1369\n#7  0x000055555617925c in run_mod (mod=\u003coptimized out>, filename=\u003coptimized out>, globals=\u003coptimized out>, locals=\u003coptimized out>, flags=\u003coptimized out>, arena=\u003coptimized out>,\n    interactive_src=\u003coptimized out>, generate_new_source=\u003coptimized out>) at Python/pythonrun.c:1472\n#8  0x00005555561736ad in pyrun_file (fp=fp@entry=0x7d4ff6e03a80, filename=filename@entry=0x7ccff6e2ccd0, start=start@entry=257, globals=globals@entry=0x7c7ff6e8a0c0,\n    locals=locals@entry=0x7c7ff6e8a0c0, closeit=closeit@entry=1, flags=0x7bfff5c77710) at Python/pythonrun.c:1296\n#9  0x000055555617120d in _PyRun_SimpleFileObject (fp=\u003coptimized out>, filename=\u003coptimized out>, closeit=\u003coptimized out>, flags=\u003coptimized out>) at Python/pythonrun.c:518\n#10 0x000055555617057e in _PyRun_AnyFileObject (fp=fp@entry=0x7d4ff6e03a80, filename=filename@entry=0x7ccff6e2ccd0, closeit=closeit@entry=1, flags=flags@entry=0x7bfff5c77710)\n    at Python/pythonrun.c:81\n#11 0x00005555561f0cdb in pymain_run_file_obj (program_name=0x7caff6e82500, filename=0x7ccff6e2ccd0, skip_source_first_line=0) at Modules/main.c:411\n#12 pymain_run_file (config=0x555556a3d0f0 \u003c_PyRuntime+143856>) at Modules/main.c:430\n#13 0x00005555561eef72 in pymain_run_python (exitcode=0x7bfff5c77300) at Modules/main.c:715\n#14 Py_RunMain () at Modules/main.c:796\n#15 0x00005555561efca7 in pymain_main (args=\u003coptimized out>) at Modules/main.c:826\n#16 0x00005555561efe18 in Py_BytesMain (argc=\u003coptimized out>, argv=0x7fffffffdb78) at Modules/main.c:850\n#17 0x00007ffff7c2a575 in __libc_start_call_main (main=main@entry=0x555555913c40 \u003cmain>, argc=argc@entry=2, argv=argv@entry=0x7fffffffdb78) at ../sysdeps/nptl/libc_start_call_main.h:58\n#18 0x00007ffff7c2a628 in __libc_start_main_impl (main=0x555555913c40 \u003cmain>, argc=2, argv=0x7fffffffdb78, init=\u003coptimized out>, fini=\u003coptimized out>, rtld_fini=\u003coptimized out>,\n    stack_end=0x7fffffffdb68) at ../csu/libc-start.c:360\n#19 0x000055555582a4f5 in _start ()\n```\n\n\nOutput from running with `PYTHON_LLTRACE=4 PYTHON_OPT_DEBUG=4`:\n[lltrace_opt_debug.txt](https://github.com/user-attachments/files/27439779/lltrace_opt_debug.txt)\nThis log file ends in:\n```\n[...]\n  55 uop: _CHECK_VALIDITY_r11 (0, jump_target=132, operand0=0, operand1=0)\n    locals=[\u003ctype at 0x6f8dffa7c9a0>]\n    stack=[]\n    cache=[\u003cContext at 0x6f2dffa3f4b0>, ---, ---]\n  56 uop: _COPY_1_r12 (1, target=18, operand0=0, operand1=0)\n    locals=[\u003ctype at 0x6f8dffa7c9a0>]\n    stack=[]\n    cache=[\u003cContext at 0x6f2dffa3f4b0>, \u003cContext at 0x6f2dffa3f4b0>, ---]\n  57 uop: _SPILL_OR_RELOAD_r21 (0, target=0, operand0=0, operand1=0)\n    locals=[\u003ctype at 0x6f8dffa7c9a0>]\n    stack=[\u003cContext at 0x6f2dffa3f4b0>]\n    cache=[\u003cContext at 0x6f2dffa3f4b0>, ---, ---]\n  58 uop: _INSERT_NULL_r10 (1, target=19, operand0=0, operand1=0)\n    locals=[\u003ctype at 0x6f8dffa7c9a0>]\n    stack=[\u003cContext at 0x6f2dffa3f4b0>, \u003cNULL>, \u003cContext at 0x6f2dffa3f4b0>]\n    cache=[---, ---, ---]\n  59 uop: _GUARD_TYPE_VERSION_r01 (0, jump_target=133, operand0=0x20110, operand1=0)\n    locals=[\u003ctype at 0x6f8dffa7c9a0>]\n    stack=[\u003cContext at 0x6f2dffa3f4b0>, \u003cNULL>, \u003cContext at 0x6f2dffa3f4b0>]\n    cache=[---, ---, ---]\n 133 uop: _EXIT_TRACE_r00 (0, target=19, operand0=0x6ffdff9f3158, operand1=0)\nSIDE EXIT: [UOp _EXIT_TRACE_r00 (0, target=19, operand0=0x6ffdff9f3158, operand1=0), exit 5, temp 510, target 19 -> LOAD_SPECIAL, is_control_flow 0]\n    locals=[\u003ctype at 0x6f8dffa7c9a0>]\n    stack=[\u003cContext at 0x6f2dffa3f4b0>, \u003cNULL>, \u003cContext at 0x6f2dffa3f4b0>]\n    cache=[---, ---, ---]\n   0 uop: _COLD_EXIT_r00 (52685, jump_target=52685, operand0=0xcdcdcdcdcdcdcdcd, operand1=0xcdcdcdcdcdcdcdcd)\nAddressSanitizer:DEADLYSIGNAL\n=================================================================\n==2328978==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000008 (pc 0x61a5c39808d4 bp 0x7fff81470a50 sp 0x7fff814709f0 T0)\n==2328978==The signal is caused by a READ memory access.\n==2328978==Hint: address points to the zero page.\n    #0 0x61a5c39808d4 in _Py_TYPE_impl /home/danzin/projects/jit_cpython/./Include/object.h:234:16\n    #1 0x61a5c39808d4 in _PyObject_LookupSpecialMethod /home/danzin/projects/jit_cpython/Objects/typeobject.c:2972:38\n    #2 0x61a5c3b76f5b in _PyEval_EvalFrameDefault /home/danzin/projects/jit_cpython/Python/generated_cases.c.h:9933:27\n    #3 0x61a5c3b6a407 in _PyEval_EvalFrame /home/danzin/projects/jit_cpython/./Include/internal/pycore_ceval.h:122:16\n[...]\n```\n\nClaude's one sentence explanation:\n\n> The JIT's `_LOAD_SPECIAL` specialisation in `Python/optimizer_bytecodes.c:2015–2031` injects `_GUARD_TYPE_VERSION` *after* `_INSERT_NULL` has already been emitted into the output trace, but the guard's deopt target is the `LOAD_SPECIAL` bytecode, which expects the stack in its pre-`_INSERT_NULL` state. When the guard fails, tier 1 re-runs the full `LOAD_SPECIAL` macro on a stack that's already been bumped by `_INSERT_NULL`, producing one extra slot that propagates through the surrounding `SWAP 2`/`SWAP 3` and lands a `NULL` as the receiver of the next `LOAD_SPECIAL` (`__enter__`), where `_PyObject_LookupSpecialMethod` does `Py_TYPE(self)` on it.\n\n\nFound using [lafleur](https://github.com/devdanzin/lafleur/).\n\n### CPython versions tested on:\n\nCPython main branch, 3.15\n\n### Operating systems tested on:\n\nLinux\n\n### Output from running 'python -VV' on the command line:\n\nPython 3.15.0a8+ (heads/main-dirty:0bf6e31941f, May  6 2026, 07:41:51) [Clang 21.1.2 (2ubuntu6)]\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-149478\n* gh-149552\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/devdanzin","@type":"Person","name":"devdanzin"},"datePublished":"2026-05-06T13:11:19Z","url":"https://github.com/python/cpython/issues/149459"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:442181d7-2fb8-c68a-079d-953cfea3ba00
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id94B0:296654:3285D15:4357A15:6B01F345
html-safe-noncef0f7464eda8043f4f3f9160e9dfe440cf54b4c374fd8f13ad501719062fdf218
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NEIwOjI5NjY1NDozMjg1RDE1OjQzNTdBMTU6NkIwMUYzNDUiLCJ2aXNpdG9yX2lkIjoiNzQzNjIxMTc5ODYxNDg2NDcxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8f8874e52970878d4da4ac0012f2d886f1a1b3a41ea0d0a53da07915a166497c
hovercard-subject-tagissue:4391598314
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/149459/issue_layout
twitter:imagehttps://opengraph.githubassets.com/966daac014ab302552890398269ff98215bf9a5e8e183c747726814439ddae73/python/cpython/issues/149459
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/966daac014ab302552890398269ff98215bf9a5e8e183c747726814439ddae73/python/cpython/issues/149459
og:image:altCrash report What happened? A JIT-enabled interpreter will crash by running the following code: MRE: def f1(): class Context: def __enter__(self): ... def __exit__(self, e, v, t): ... with Context(...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedevdanzin
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/149459#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F149459
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F149459
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/149459
Reloadhttps://github.com/python/cpython/issues/149459
Reloadhttps://github.com/python/cpython/issues/149459
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/149459
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/149459
JIT: segfault from _PyObject_LookupSpecialMethodhttps://github.com/python/cpython/issues/149459#top
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
topic-JIThttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-JIT%22
type-crashA hard crash of the interpreter, possibly with a core dumphttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-crash%22
https://github.com/devdanzin
devdanzinhttps://github.com/devdanzin
on May 6, 2026https://github.com/python/cpython/issues/149459#issue-4391598314
lltrace_opt_debug.txthttps://github.com/user-attachments/files/27439779/lltrace_opt_debug.txt
lafleurhttps://github.com/devdanzin/lafleur/
gh-149459: Fix segfault when _LOAD_SPECIAL guard deoptimizes #149478https://github.com/python/cpython/pull/149478
[3.15] gh-149459: Fix segfault when _LOAD_SPECIAL guard deoptimizes (GH-149478) #149552https://github.com/python/cpython/pull/149552
devdanzinhttps://github.com/devdanzin
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
type-crashA hard crash of the interpreter, possibly with a core dumphttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-crash%22
topic-JIThttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-JIT%22
on May 6, 2026https://github.com/python/cpython/issues/149459#event-25219445376
cocolatohttps://github.com/cocolato
on May 7, 2026https://github.com/python/cpython/issues/149459#event-25246740867
Merge branch 'pythongh-149459' of https://github.com/cocolato/cpython …https://github.com/cocolato/cpython/commit/93db7958bfe267fb87d48a3489a8cf71a03a4a8e
pythongh-149459https://github.com/python/cpython/issues/149459
https://github.com/cocolato/cpythonhttps://github.com/cocolato/cpython
93db795https://github.com/cocolato/cpython/commit/93db7958bfe267fb87d48a3489a8cf71a03a4a8e
Merge branch 'main' into pythongh-149459https://github.com/cocolato/cpython/commit/b9c06179f461498e2d39c54c31978f15c7718618
pythongh-149459https://github.com/python/cpython/issues/149459
b9c0617https://github.com/cocolato/cpython/commit/b9c06179f461498e2d39c54c31978f15c7718618
kumaraditya303https://github.com/kumaraditya303
on May 8, 2026https://github.com/python/cpython/issues/149459#event-25302314221
Merge branch 'main' into pythongh-149459https://github.com/cocolato/cpython/commit/888060178a283dea4816a8b598608efb432f2b5a
pythongh-149459https://github.com/python/cpython/issues/149459
8880601https://github.com/cocolato/cpython/commit/888060178a283dea4816a8b598608efb432f2b5a
gh-149459: Fix segfault when `_LOAD_SPECIAL` guard deoptimizes (#149478)https://github.com/python/cpython/commit/c341e341b25cec03d28d1b2c368bb871d76ca88b
gh-149459https://github.com/python/cpython/issues/149459
#149478https://github.com/python/cpython/pull/149478
c341e34https://github.com/python/cpython/commit/c341e341b25cec03d28d1b2c368bb871d76ca88b
kumaraditya303https://github.com/kumaraditya303
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on May 8, 2026https://github.com/python/cpython/issues/149459#event-25303192062
kumaraditya303https://github.com/kumaraditya303
on May 8, 2026https://github.com/python/cpython/issues/149459#event-25304045177
[3.15] gh-149459: Fix segfault when `_LOAD_SPECIAL` guard deoptimizes (…https://github.com/python/cpython/commit/f9e5975deb6b01c434eadff66f28bd53e0ca4c55
gh-149459https://github.com/python/cpython/issues/149459
…https://github.com/python/cpython/pull/149478
f9e5975https://github.com/python/cpython/commit/f9e5975deb6b01c434eadff66f28bd53e0ca4c55
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/149459
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/149459
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
topic-JIThttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-JIT%22
type-crashA hard crash of the interpreter, possibly with a core dumphttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-crash%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.