René's URL Explorer Experiment


Title: `_remote_debugging`: binary reader does not enforce `thread_count` · Issue #149009 · python/cpython · GitHub

Open Graph Title: `_remote_debugging`: binary reader does not enforce `thread_count` · Issue #149009 · python/cpython

X Title: `_remote_debugging`: binary reader does not enforce `thread_count` · Issue #149009 · python/cpython

Description: Bug report Bug description: While familiarizing myself with the state of the consts, for the purpose of #148972 (comment), I've noticed that there's thread_count in the format: cpython/Modules/_remote_debugging/binary_io.h Line 314 in 6d...

Open Graph Description: Bug report Bug description: While familiarizing myself with the state of the consts, for the purpose of #148972 (comment), I've noticed that there's thread_count in the format: cpython/Modules/_rem...

X Description: Bug report Bug description: While familiarizing myself with the state of the consts, for the purpose of #148972 (comment), I've noticed that there's thread_count in the format: cpython/Modu...

Opengraph URL: https://github.com/python/cpython/issues/149009

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`_remote_debugging`: binary reader does not enforce `thread_count`","articleBody":"# Bug report\n\n### Bug description:\n\nWhile familiarizing myself with the state of the consts, for the purpose of https://github.com/python/cpython/pull/148972#discussion_r3142681347, I've noticed that there's `thread_count` in the format:\n\nhttps://github.com/python/cpython/blob/6d4ca16f47586533c9223fe5729f6b7e221fa9f9/Modules/_remote_debugging/binary_io.h#L314\n\nhttps://github.com/python/cpython/blob/6d4ca16f47586533c9223fe5729f6b7e221fa9f9/Modules/_remote_debugging/binary_io_reader.c#L95\n\nThat said, it seems that `reader_get_or_create_thread_state` in the `BinaryReader` just ignores it:\n\nhttps://github.com/python/cpython/blob/6d4ca16f47586533c9223fe5729f6b7e221fa9f9/Modules/_remote_debugging/binary_io_reader.c#L553-L598\n\nI believe that an evil file with a lot of `(thread_id, interpreter_id)` could effectively DoS the reader.\n\n### Reproduction\n\n```python\nimport struct\nimport tempfile\nimport resource\n\nfrom _remote_debugging import (\n    BinaryReader,\n    FrameInfo,\n    InterpreterInfo,\n    LocationInfo,\n    ThreadInfo,\n)\nfrom profiling.sampling.binary_collector import BinaryCollector\n\n\n# Thanks Claude for this idea...\nclass ThreadCountingSink:\n    def __init__(self):\n        self.unique_threads = set()\n\n    def collect(self, sample, timestamps):\n        for interp in sample:\n            for thread in interp.threads:\n                self.unique_threads.add(\n                    (interp.interpreter_id, thread.thread_id)\n                )\n\n\nN = 100_000\n\nframe = FrameInfo((\"x.py\", LocationInfo((1, 1, 0, 0)), \"f\", None))\nthreads = [ThreadInfo((i, 0, [frame])) for i in range(N)]\n\nwith tempfile.NamedTemporaryFile(suffix=\".bin\") as f:\n    writer = BinaryCollector(f.name, 1000, compression=\"none\")\n    writer.collect([InterpreterInfo((0, threads))], timestamp_us=1000)\n    writer.export(None)\n\n    # Introduce a lie. :-)\n    with open(f.name, \"r+b\") as raw:\n        raw.seek(32)\n        raw.write(struct.pack(\"\u003cI\", 1))\n\n    print(\"Reading...\")\n\n    reader = BinaryReader(f.name)\n\n    before = resource.getrusage(resource.RUSAGE_SELF).ru_maxrss\n    sink = ThreadCountingSink()\n    samples = reader.replay(sink)\n    after = resource.getrusage(resource.RUSAGE_SELF).ru_maxrss\n\n    print(reader.get_info()[\"thread_count\"])\n    print(f\"{len(sink.unique_threads)} unique (interp_id, thread_id) pairs\")\n    print(f\"RSS diff: {(after - before) / 1024:.1f} MB\")\n    print(f\"samples: {samples}\")\n```\n\n```\n2026-04-26T13:47:07.878443000+0200 maurycy@gimel /Users/maurycy/src/github.com/maurycy/cpython (main 6d4ca16) % ./python.exe bye-sweet-prince.py\nReading...\n1\n100000 unique (interp_id, thread_id) pairs\nRSS diff: 20528.0 MB\nsamples: 100000\n```\n\n(20528.0 MB is higher than I expected...)\n\n### Solution\n\nI think the fix is either a preallocation or a simple `if (reader->thread_state_count >= reader->thread_count)`.\n\nTruth to be told, something like `MAX_THREADS` might be warranted there, too:\n\nhttps://github.com/python/cpython/blob/6d4ca16f47586533c9223fe5729f6b7e221fa9f9/Modules/_remote_debugging/threads.c#L32\n\nAnother obvious angle: check other values in the header.\n\n### CPython versions tested on:\n\nCPython main branch\n\n### Operating systems tested on:\n\nmacOS\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-149147\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/maurycy","@type":"Person","name":"maurycy"},"datePublished":"2026-04-26T11:24:32Z","url":"https://github.com/python/cpython/issues/149009"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:616eb8ad-2674-5f95-e03b-6e6579a3ebaa
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id89C8:2A1EC8:F06819:12DECCE:6B023AA6
html-safe-nonce58907ef3e69de61e9853f28d8ae5b06a848eebaefa6e327448f936e263dcea48
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUM4OjJBMUVDODpGMDY4MTk6MTJERUNDRTo2QjAyM0FBNiIsInZpc2l0b3JfaWQiOiIyMDU2NTcyMDkzMTk4NjQ5OTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7dd7a773a6357c40b4227e5fc97ec019d1020d98695179271404fe2cfe3a905e
hovercard-subject-tagissue:4330730706
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/149009/issue_layout
twitter:imagehttps://opengraph.githubassets.com/dbf1fd62570d31dd47a665cfc51d7b601aacc86fe1e6f7e72125d2cb70156fcf/python/cpython/issues/149009
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dbf1fd62570d31dd47a665cfc51d7b601aacc86fe1e6f7e72125d2cb70156fcf/python/cpython/issues/149009
og:image:altBug report Bug description: While familiarizing myself with the state of the consts, for the purpose of #148972 (comment), I've noticed that there's thread_count in the format: cpython/Modules/_rem...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemaurycy
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/149009#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F149009
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F149009
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/149009
Reloadhttps://github.com/python/cpython/issues/149009
Reloadhttps://github.com/python/cpython/issues/149009
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/149009
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/149009
#149147https://github.com/python/cpython/pull/149147
_remote_debugging: binary reader does not enforce thread_counthttps://github.com/python/cpython/issues/149009#top
#149147https://github.com/python/cpython/pull/149147
extension-modulesC modules in the Modules dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22extension-modules%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/maurycy
maurycyhttps://github.com/maurycy
on Apr 26, 2026https://github.com/python/cpython/issues/149009#issue-4330730706
#148972 (comment)https://github.com/python/cpython/pull/148972#discussion_r3142681347
cpython/Modules/_remote_debugging/binary_io.hhttps://github.com/python/cpython/blob/6d4ca16f47586533c9223fe5729f6b7e221fa9f9/Modules/_remote_debugging/binary_io.h#L314
6d4ca16https://github.com/python/cpython/commit/6d4ca16f47586533c9223fe5729f6b7e221fa9f9
cpython/Modules/_remote_debugging/binary_io_reader.chttps://github.com/python/cpython/blob/6d4ca16f47586533c9223fe5729f6b7e221fa9f9/Modules/_remote_debugging/binary_io_reader.c#L95
6d4ca16https://github.com/python/cpython/commit/6d4ca16f47586533c9223fe5729f6b7e221fa9f9
cpython/Modules/_remote_debugging/binary_io_reader.chttps://github.com/python/cpython/blob/6d4ca16f47586533c9223fe5729f6b7e221fa9f9/Modules/_remote_debugging/binary_io_reader.c#L553-L598
6d4ca16https://github.com/python/cpython/commit/6d4ca16f47586533c9223fe5729f6b7e221fa9f9
cpython/Modules/_remote_debugging/threads.chttps://github.com/python/cpython/blob/6d4ca16f47586533c9223fe5729f6b7e221fa9f9/Modules/_remote_debugging/threads.c#L32
6d4ca16https://github.com/python/cpython/commit/6d4ca16f47586533c9223fe5729f6b7e221fa9f9
gh-149009: Validate thread_count in profiling.sampling binary reader #149147https://github.com/python/cpython/pull/149147
maurycyhttps://github.com/maurycy
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
on Apr 26, 2026https://github.com/python/cpython/issues/149009#event-24878760352
https://github.com/maurycy
maurycyhttps://github.com/maurycy
on Apr 26, 2026https://github.com/python/cpython/issues/149009#issuecomment-4321910688
@pablogsalhttps://github.com/pablogsal
StanFromIrelandhttps://github.com/StanFromIreland
extension-modulesC modules in the Modules dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22extension-modules%22
on Apr 26, 2026https://github.com/python/cpython/issues/149009#event-24879072733
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
on Apr 27, 2026https://github.com/python/cpython/issues/149009#issuecomment-4331116738
https://docs.python.org/3/howto/remote_debugging.html#security-and-threat-modelhttps://docs.python.org/3/howto/remote_debugging.html#security-and-threat-model
pablogsalhttps://github.com/pablogsal
on May 5, 2026https://github.com/python/cpython/issues/149009#event-25156641948
gh-149009: Validate `thread_count` in `profiling.sampling` binary rea…https://github.com/python/cpython/commit/c266f0c375c2e60ea46046254fa7cd5fa2fe1ca2
gh-149009https://github.com/python/cpython/issues/149009
c266f0chttps://github.com/python/cpython/commit/c266f0c375c2e60ea46046254fa7cd5fa2fe1ca2
pablogsalhttps://github.com/pablogsal
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#149147https://github.com/python/cpython/pull/149147
on May 5, 2026https://github.com/python/cpython/issues/149009#event-25156641977
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/149009
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/149009
extension-modulesC modules in the Modules dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22extension-modules%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.