Title: `_remote_debugging`: binary reader does not enforce `thread_count` · Issue #149009 · python/cpython · GitHub
Open Graph Title: `_remote_debugging`: binary reader does not enforce `thread_count` · Issue #149009 · python/cpython
X Title: `_remote_debugging`: binary reader does not enforce `thread_count` · Issue #149009 · python/cpython
Description: Bug report Bug description: While familiarizing myself with the state of the consts, for the purpose of #148972 (comment), I've noticed that there's thread_count in the format: cpython/Modules/_remote_debugging/binary_io.h Line 314 in 6d...
Open Graph Description: Bug report Bug description: While familiarizing myself with the state of the consts, for the purpose of #148972 (comment), I've noticed that there's thread_count in the format: cpython/Modules/_rem...
X Description: Bug report Bug description: While familiarizing myself with the state of the consts, for the purpose of #148972 (comment), I've noticed that there's thread_count in the format: cpython/Modu...
Opengraph URL: https://github.com/python/cpython/issues/149009
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`_remote_debugging`: binary reader does not enforce `thread_count`","articleBody":"# Bug report\n\n### Bug description:\n\nWhile familiarizing myself with the state of the consts, for the purpose of https://github.com/python/cpython/pull/148972#discussion_r3142681347, I've noticed that there's `thread_count` in the format:\n\nhttps://github.com/python/cpython/blob/6d4ca16f47586533c9223fe5729f6b7e221fa9f9/Modules/_remote_debugging/binary_io.h#L314\n\nhttps://github.com/python/cpython/blob/6d4ca16f47586533c9223fe5729f6b7e221fa9f9/Modules/_remote_debugging/binary_io_reader.c#L95\n\nThat said, it seems that `reader_get_or_create_thread_state` in the `BinaryReader` just ignores it:\n\nhttps://github.com/python/cpython/blob/6d4ca16f47586533c9223fe5729f6b7e221fa9f9/Modules/_remote_debugging/binary_io_reader.c#L553-L598\n\nI believe that an evil file with a lot of `(thread_id, interpreter_id)` could effectively DoS the reader.\n\n### Reproduction\n\n```python\nimport struct\nimport tempfile\nimport resource\n\nfrom _remote_debugging import (\n BinaryReader,\n FrameInfo,\n InterpreterInfo,\n LocationInfo,\n ThreadInfo,\n)\nfrom profiling.sampling.binary_collector import BinaryCollector\n\n\n# Thanks Claude for this idea...\nclass ThreadCountingSink:\n def __init__(self):\n self.unique_threads = set()\n\n def collect(self, sample, timestamps):\n for interp in sample:\n for thread in interp.threads:\n self.unique_threads.add(\n (interp.interpreter_id, thread.thread_id)\n )\n\n\nN = 100_000\n\nframe = FrameInfo((\"x.py\", LocationInfo((1, 1, 0, 0)), \"f\", None))\nthreads = [ThreadInfo((i, 0, [frame])) for i in range(N)]\n\nwith tempfile.NamedTemporaryFile(suffix=\".bin\") as f:\n writer = BinaryCollector(f.name, 1000, compression=\"none\")\n writer.collect([InterpreterInfo((0, threads))], timestamp_us=1000)\n writer.export(None)\n\n # Introduce a lie. :-)\n with open(f.name, \"r+b\") as raw:\n raw.seek(32)\n raw.write(struct.pack(\"\u003cI\", 1))\n\n print(\"Reading...\")\n\n reader = BinaryReader(f.name)\n\n before = resource.getrusage(resource.RUSAGE_SELF).ru_maxrss\n sink = ThreadCountingSink()\n samples = reader.replay(sink)\n after = resource.getrusage(resource.RUSAGE_SELF).ru_maxrss\n\n print(reader.get_info()[\"thread_count\"])\n print(f\"{len(sink.unique_threads)} unique (interp_id, thread_id) pairs\")\n print(f\"RSS diff: {(after - before) / 1024:.1f} MB\")\n print(f\"samples: {samples}\")\n```\n\n```\n2026-04-26T13:47:07.878443000+0200 maurycy@gimel /Users/maurycy/src/github.com/maurycy/cpython (main 6d4ca16) % ./python.exe bye-sweet-prince.py\nReading...\n1\n100000 unique (interp_id, thread_id) pairs\nRSS diff: 20528.0 MB\nsamples: 100000\n```\n\n(20528.0 MB is higher than I expected...)\n\n### Solution\n\nI think the fix is either a preallocation or a simple `if (reader->thread_state_count >= reader->thread_count)`.\n\nTruth to be told, something like `MAX_THREADS` might be warranted there, too:\n\nhttps://github.com/python/cpython/blob/6d4ca16f47586533c9223fe5729f6b7e221fa9f9/Modules/_remote_debugging/threads.c#L32\n\nAnother obvious angle: check other values in the header.\n\n### CPython versions tested on:\n\nCPython main branch\n\n### Operating systems tested on:\n\nmacOS\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-149147\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/maurycy","@type":"Person","name":"maurycy"},"datePublished":"2026-04-26T11:24:32Z","url":"https://github.com/python/cpython/issues/149009"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:616eb8ad-2674-5f95-e03b-6e6579a3ebaa |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 89C8:2A1EC8:F06819:12DECCE:6B023AA6 |
| html-safe-nonce | 58907ef3e69de61e9853f28d8ae5b06a848eebaefa6e327448f936e263dcea48 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUM4OjJBMUVDODpGMDY4MTk6MTJERUNDRTo2QjAyM0FBNiIsInZpc2l0b3JfaWQiOiIyMDU2NTcyMDkzMTk4NjQ5OTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7dd7a773a6357c40b4227e5fc97ec019d1020d98695179271404fe2cfe3a905e |
| hovercard-subject-tag | issue:4330730706 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/149009/issue_layout |
| twitter:image | https://opengraph.githubassets.com/dbf1fd62570d31dd47a665cfc51d7b601aacc86fe1e6f7e72125d2cb70156fcf/python/cpython/issues/149009 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dbf1fd62570d31dd47a665cfc51d7b601aacc86fe1e6f7e72125d2cb70156fcf/python/cpython/issues/149009 |
| og:image:alt | Bug report Bug description: While familiarizing myself with the state of the consts, for the purpose of #148972 (comment), I've noticed that there's thread_count in the format: cpython/Modules/_rem... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | maurycy |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width