Title: Segfault in _pickle.c:batch_list_exact when pickling list with concurrent mutation (free-threading) · Issue #146533 · python/cpython · GitHub
Open Graph Title: Segfault in _pickle.c:batch_list_exact when pickling list with concurrent mutation (free-threading) · Issue #146533 · python/cpython
X Title: Segfault in _pickle.c:batch_list_exact when pickling list with concurrent mutation (free-threading) · Issue #146533 · python/cpython
Description: Bug report Bug description Same class of bug as gh-146452 but in the list pickling path. batch_list_exact() uses PyList_GET_ITEM() which returns a borrowed reference, and a concurrent list.clear() or mutation can free the backing array b...
Open Graph Description: Bug report Bug description Same class of bug as gh-146452 but in the list pickling path. batch_list_exact() uses PyList_GET_ITEM() which returns a borrowed reference, and a concurrent list.clear() ...
X Description: Bug report Bug description Same class of bug as gh-146452 but in the list pickling path. batch_list_exact() uses PyList_GET_ITEM() which returns a borrowed reference, and a concurrent list.clear() ...
Opengraph URL: https://github.com/python/cpython/issues/146533
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Segfault in _pickle.c:batch_list_exact when pickling list with concurrent mutation (free-threading)","articleBody":"# Bug report\n\n### Bug description\n\nSame class of bug as gh-146452 but in the list pickling path. `batch_list_exact()` uses `PyList_GET_ITEM()` which returns a borrowed reference, and a concurrent `list.clear()` or mutation can free the backing array before `Py_INCREF` gets to it.\n\nFound while working on the dict fix in gh-146452 — checked the list path and it has the same pattern.\n\n### Reproducer\n\n```python\nimport pickle\nimport threading\n\nshared = list(range(200))\n\nfor trial in range(2000):\n barrier = threading.Barrier(4)\n\n def dumper():\n try:\n barrier.wait()\n pickle.dumps(shared)\n except Exception:\n pass\n\n def mutator():\n try:\n barrier.wait()\n for j in range(500):\n shared.append([j] * 20)\n if len(shared) > 100:\n shared.clear()\n shared.extend(range(50))\n except Exception:\n pass\n\n threads = [\n threading.Thread(target=dumper),\n threading.Thread(target=dumper),\n threading.Thread(target=mutator),\n threading.Thread(target=mutator),\n ]\n for t in threads: t.start()\n for t in threads: t.join()\n```\n\n### Tested on\n\n**3.14.0a4 free-threading (stock install, no sanitizers):**\n```\n$ python3.14t reproducer.py\nSegmentation fault (core dumped)\n```\n\n**3.15.0a7+ free-threading (built with --with-address-sanitizer):**\n```\n==2034815==ERROR: AddressSanitizer: SEGV on unknown address 0x00000000000c\n #0 _Py_atomic_load_uint32_relaxed Include/cpython/pyatomic_gcc.h:367\n #1 Py_INCREF Include/refcount.h:267\n #2 batch_list_exact Modules/_pickle.c:3213\n #3 save_list Modules/_pickle.c:3268\n #4 save Modules/_pickle.c:4595\n #5 dump Modules/_pickle.c:4768\n #6 _pickle_dumps_impl Modules/_pickle.c:7992\n```\n\n### Root cause\n\n`batch_list_exact()` iterates list items using `PyList_GET_ITEM()` (borrowed ref) at lines 3196 and 3212. A concurrent list mutation can invalidate the borrowed reference before `Py_INCREF`. Same pattern as the dict issue in gh-146452.\n\n### Possible fix\n\nSame helper function approach as gh-146452 — wrap `batch_list_exact` in `Py_BEGIN_CRITICAL_SECTION(obj)` / `Py_END_CRITICAL_SECTION()`. Happy to send a PR.\n\n### CPython versions tested on\n\n3.14, CPython main branch\n\n### Operating systems tested on\n\nLinux","author":{"url":"https://github.com/overlorde","@type":"Person","name":"overlorde"},"datePublished":"2026-03-27T20:43:49Z","url":"https://github.com/python/cpython/issues/146533"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:aabbd44d-b75e-db59-07da-8dcec8500ccb |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B368:3A4875:34739BE:45DE59B:6B01FE15 |
| html-safe-nonce | 37a98a7745b7b0e28b8b4331e5d485b796e627717bf27f582c26d2f1d2bed1c5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzY4OjNBNDg3NTozNDczOUJFOjQ1REU1OUI6NkIwMUZFMTUiLCJ2aXNpdG9yX2lkIjoiOTE2MzEyNTk4MjYzMzI2MjYxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2d96cb5e3d9229e03fdf8eb144fc76f87fcdebfffa4a6dbf4bb5b768e9a4fc94 |
| hovercard-subject-tag | issue:4155812250 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/146533/issue_layout |
| twitter:image | https://opengraph.githubassets.com/28f4e0922dd6dcae25f9759447f0370e7e2a5b10d00af52db035a452c2fed924/python/cpython/issues/146533 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/28f4e0922dd6dcae25f9759447f0370e7e2a5b10d00af52db035a452c2fed924/python/cpython/issues/146533 |
| og:image:alt | Bug report Bug description Same class of bug as gh-146452 but in the list pickling path. batch_list_exact() uses PyList_GET_ITEM() which returns a borrowed reference, and a concurrent list.clear() ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | overlorde |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width