Title: Tachyon's `StackTraceCollector` has two different ways to set `skip_idle` · Issue #145458 · python/cpython · GitHub
Open Graph Title: Tachyon's `StackTraceCollector` has two different ways to set `skip_idle` · Issue #145458 · python/cpython
X Title: Tachyon's `StackTraceCollector` has two different ways to set `skip_idle` · Issue #145458 · python/cpython
Description: I was looking at the code in Tachyon and I think I've found something that isn't quite right (or at least is misleading and needs to be documented?) In the StackTraceCollector, it seems like self.skip_idle is set but never used, as every...
Open Graph Description: I was looking at the code in Tachyon and I think I've found something that isn't quite right (or at least is misleading and needs to be documented?) In the StackTraceCollector, it seems like self.s...
X Description: I was looking at the code in Tachyon and I think I've found something that isn't quite right (or at least is misleading and needs to be documented?) In the StackTraceCollector, it seems lik...
Opengraph URL: https://github.com/python/cpython/issues/145458
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Tachyon's `StackTraceCollector` has two different ways to set `skip_idle`","articleBody":"I was looking at the code in Tachyon and I think I've found something that isn't quite right (or at least is misleading and needs to be documented?)\n\nIn the `StackTraceCollector`, it seems like `self.skip_idle` is set but never used, as every `collect` method gets another `skip_idle` parameter that they use in `_iter_stacks` (or their calls to parent class' methods). \n\nBased on the [code](https://github.com/python/cpython/blob/72eca2af59043c78647b0e6be3777a947ea9ef0f/Lib/profiling/sampling/live_collector/collector.py) for e.g. `live_collector`, it seems like the pattern is to use the attribute, not a parameter.\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-145459\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/KowalskiThomas","@type":"Person","name":"KowalskiThomas"},"datePublished":"2026-03-03T09:56:59.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/145458/cpython/issues/145458"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:d0d4596b-fede-9bef-d31d-01b1445d2b1d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9D94:34DA5A:65B4B08:8F0F753:6A50528F |
| html-safe-nonce | cb54f01e7f5f87069457c479209712235ad6c25cf4625431e9d1c37956b87fb3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDk0OjM0REE1QTo2NUI0QjA4OjhGMEY3NTM6NkE1MDUyOEYiLCJ2aXNpdG9yX2lkIjoiNzM4MjAyNjAxMDE2MDU1MDU0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 54925fb9decc9be2fe6400f1499a45fa42c772ddd6ab3d29e9a5273ac5d8d82a |
| hovercard-subject-tag | issue:4015750601 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/145458/issue_layout |
| twitter:image | https://opengraph.githubassets.com/02504d76a15d44745efd2e18231824ceb3ce2515a7a97ae6f925fc3ab1c004df/python/cpython/issues/145458 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/02504d76a15d44745efd2e18231824ceb3ce2515a7a97ae6f925fc3ab1c004df/python/cpython/issues/145458 |
| og:image:alt | I was looking at the code in Tachyon and I think I've found something that isn't quite right (or at least is misleading and needs to be documented?) In the StackTraceCollector, it seems like self.s... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | KowalskiThomas |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5741a45fe07e5f377d0d4c524a92e3056acc51bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width