René's URL Explorer Experiment


Title: Overzealous Optimization For `isinstance` · Issue #144873 · python/cpython · GitHub

Open Graph Title: Overzealous Optimization For `isinstance` · Issue #144873 · python/cpython

X Title: Overzealous Optimization For `isinstance` · Issue #144873 · python/cpython

Description: Bug report Bug description: The custom __instancecheck__ dunder method allows full customization (described in the Data model). However, it produces a spurious result: class CustomIsInstanceMeta(type): def __instancecheck__(cls, instance...

Open Graph Description: Bug report Bug description: The custom __instancecheck__ dunder method allows full customization (described in the Data model). However, it produces a spurious result: class CustomIsInstanceMeta(ty...

X Description: Bug report Bug description: The custom __instancecheck__ dunder method allows full customization (described in the Data model). However, it produces a spurious result: class CustomIsInstanceMeta(ty...

Opengraph URL: https://github.com/python/cpython/issues/144873

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Overzealous Optimization For `isinstance`","articleBody":"# Bug report\n\n### Bug description:\n\nThe custom `__instancecheck__` dunder method allows full customization (described in the [Data model](https://docs.python.org/3.14/reference/datamodel.html#customizing-instance-and-subclass-checks)).\n\nHowever, it produces a spurious result:\n\n```python\nclass CustomIsInstanceMeta(type):\n    def __instancecheck__(cls, instance: object) -> bool:\n        return type(instance) is int\n\nclass CustomIsInstance(metaclass=CustomIsInstanceMeta):\n    ...\n\nclass CustomIsInstanceSubclass(CustomIsInstance):\n    ...\n\n\nprint(isinstance(5, CustomIsInstance)) # True\nprint(isinstance(CustomIsInstance(), CustomIsInstance)) # True (should be False)\nprint(isinstance(CustomIsInstanceSubclass(), CustomIsInstance)) # False\n```\n\nThis is caused by:\nhttps://github.com/python/cpython/blob/23c488d6197191d355be6733699a295c20806932/Objects/abstract.c#L2641-L2644\nwhich is invalid in this case.\n\n\nThis is a reframing of #79264 (request to fix documentation)\n\n### CPython versions tested on:\n\n3.13\n\n### Operating systems tested on:\n\nLinux\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-144874\n* gh-144997\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/George-Ogden","@type":"Person","name":"George-Ogden"},"datePublished":"2026-02-16T12:17:01Z","url":"https://github.com/python/cpython/issues/144873"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:1eed0ac3-06de-b9b8-279f-6e84daebfdc8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC5A4:1050BD:173CB9A:1EB88D0:6B020978
html-safe-nonce978e038ae30a3088e87c55cb8bccf525dabcb1d97d815acc22316bfe438493a5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNUE0OjEwNTBCRDoxNzNDQjlBOjFFQjg4RDA6NkIwMjA5NzgiLCJ2aXNpdG9yX2lkIjoiNTY5MzE4MDA4NzM3MTA2Mjk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac03d76eca7a308762ef321e597d4ec286ae57c2a70d51f0f3cacdd7cebe8e8c6d
hovercard-subject-tagissue:3947485592
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/144873/issue_layout
twitter:imagehttps://opengraph.githubassets.com/4df6467a9ad275bdb771cfece23ba45d31ee4e972216b4bcf73449e5813c5970/python/cpython/issues/144873
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4df6467a9ad275bdb771cfece23ba45d31ee4e972216b4bcf73449e5813c5970/python/cpython/issues/144873
og:image:altBug report Bug description: The custom __instancecheck__ dunder method allows full customization (described in the Data model). However, it produces a spurious result: class CustomIsInstanceMeta(ty...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameGeorge-Ogden
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/144873#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F144873
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F144873
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/144873
Reloadhttps://github.com/python/cpython/issues/144873
Reloadhttps://github.com/python/cpython/issues/144873
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/144873
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/144873
#144997https://github.com/python/cpython/pull/144997
Overzealous Optimization For isinstancehttps://github.com/python/cpython/issues/144873#top
#144997https://github.com/python/cpython/pull/144997
docsDocumentation in the Doc dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22docs%22
https://github.com/George-Ogden
George-Ogdenhttps://github.com/George-Ogden
on Feb 16, 2026https://github.com/python/cpython/issues/144873#issue-3947485592
Data modelhttps://docs.python.org/3.14/reference/datamodel.html#customizing-instance-and-subclass-checks
cpython/Objects/abstract.chttps://github.com/python/cpython/blob/23c488d6197191d355be6733699a295c20806932/Objects/abstract.c#L2641-L2644
23c488dhttps://github.com/python/cpython/commit/23c488d6197191d355be6733699a295c20806932
#79264https://github.com/python/cpython/issues/79264
gh-144873: Remove Overzealous isinstance Optimization #144874https://github.com/python/cpython/pull/144874
gh-144873: Document isinstance Edge Case #144997https://github.com/python/cpython/pull/144997
George-Ogdenhttps://github.com/George-Ogden
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
on Feb 16, 2026https://github.com/python/cpython/issues/144873#event-22823691816
picnixzhttps://github.com/picnixz
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
on Feb 16, 2026https://github.com/python/cpython/issues/144873#event-22824060907
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
on Feb 16, 2026https://github.com/python/cpython/issues/144873#issuecomment-3908902606
https://github.com/George-Ogden
George-Ogdenhttps://github.com/George-Ogden
on Feb 17, 2026https://github.com/python/cpython/issues/144873#issuecomment-3912966020
https://github.com/George-Ogden
George-Ogdenhttps://github.com/George-Ogden
on Feb 17, 2026https://github.com/python/cpython/issues/144873#issuecomment-3912976939
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
on Feb 18, 2026https://github.com/python/cpython/issues/144873#issuecomment-3918009154
@gvanrossumhttps://github.com/gvanrossum
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
on Feb 18, 2026https://github.com/python/cpython/issues/144873#issuecomment-3923732430
rhettingerhttps://github.com/rhettinger
pendingThe issue will be closed if no feedback is providedhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22pending%22
on Feb 18, 2026https://github.com/python/cpython/issues/144873#event-22899100438
gvanrossumhttps://github.com/gvanrossum
docsDocumentation in the Doc dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22docs%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
pendingThe issue will be closed if no feedback is providedhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22pending%22
on Feb 18, 2026https://github.com/python/cpython/issues/144873#event-22899463920
github-project-automationhttps://github.com/apps/github-project-automation
docs issueshttps://github.com/orgs/python/projects/52
on Feb 18, 2026https://github.com/python/cpython/issues/144873#event-22899465465
github-project-automationhttps://github.com/apps/github-project-automation
docs issueshttps://github.com/orgs/python/projects/52
on Feb 18, 2026https://github.com/python/cpython/issues/144873
gvanrossumhttps://github.com/gvanrossum
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
on Feb 18, 2026https://github.com/python/cpython/issues/144873#event-22899466828
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Feb 18, 2026https://github.com/python/cpython/issues/144873#issuecomment-3923869276
https://github.com/George-Ogden
George-Ogdenhttps://github.com/George-Ogden
on Feb 19, 2026https://github.com/python/cpython/issues/144873#issuecomment-3926808710
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
on Jun 3, 2026https://github.com/python/cpython/issues/144873#issuecomment-4611884123
#79264https://github.com/python/cpython/issues/79264
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/144873
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/144873
docsDocumentation in the Doc dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22docs%22
docs issueshttps://github.com/orgs/python/projects/52
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.