Title: Guard against negative offset/length values in tarfile's GNU sparse extraction · Issue #137396 · python/cpython · GitHub
Open Graph Title: Guard against negative offset/length values in tarfile's GNU sparse extraction · Issue #137396 · python/cpython
X Title: Guard against negative offset/length values in tarfile's GNU sparse extraction · Issue #137396 · python/cpython
Description: Bug report Bug description: for i in range(21): try: offset = nti(buf[pos:pos + 12]) numbytes = nti(buf[pos + 12:pos + 24]) except ValueError: break if offset and numbytes: structs.append((offset, numbytes)) pos += 24 cpython/Lib/tarfile...
Open Graph Description: Bug report Bug description: for i in range(21): try: offset = nti(buf[pos:pos + 12]) numbytes = nti(buf[pos + 12:pos + 24]) except ValueError: break if offset and numbytes: structs.append((offset, ...
X Description: Bug report Bug description: for i in range(21): try: offset = nti(buf[pos:pos + 12]) numbytes = nti(buf[pos + 12:pos + 24]) except ValueError: break if offset and numbytes: structs.append((offset, ...
Opengraph URL: https://github.com/python/cpython/issues/137396
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Guard against negative offset/length values in tarfile's GNU sparse extraction","articleBody":"# Bug report\n\n### Bug description:\n\n```\nfor i in range(21):\n try:\n offset = nti(buf[pos:pos + 12])\n numbytes = nti(buf[pos + 12:pos + 24])\n except ValueError:\n break\n if offset and numbytes:\n structs.append((offset, numbytes))\n pos += 24\n```\n\nhttps://github.com/python/cpython/blob/7040aa54f14676938970e10c5f74ea93cd56aa38/Lib/tarfile.py#L1441\n\n- There is no check that offset or numbytes are non-negative.\n- The check if offset and numbytes: only skips zero, not negative numbers.\n\n\n### validation should be added:\n```\nif offset \u003e= 0 and numbytes \u003e= 0:\n structs.append((offset, numbytes))\n```\n- This will prevent the addition of invalid sparse mappings, mitigating the risk.\n\n\n### CPython versions tested on:\n\n3.13\n\n### Operating systems tested on:\n\nWindows\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-137805\n* gh-138726\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/VbhvGupta","@type":"Person","name":"VbhvGupta"},"datePublished":"2025-08-04T22:33:12.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":11},"url":"https://github.com/137396/cpython/issues/137396"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:06d88179-df27-240a-86b3-aa6371479925 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CA7C:1A425C:95B298:C432EA:696B5417 |
| html-safe-nonce | f4969df8e08c16eee526de638805304fbeea1c6271256d4231fea7711b7fafb5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTdDOjFBNDI1Qzo5NUIyOTg6QzQzMkVBOjY5NkI1NDE3IiwidmlzaXRvcl9pZCI6IjM5NjM0OTkyMzY3Mzk5OTQ2NDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d5afe3c208fcf27d092c86c0f3df2fc31074335f9cc629bf350e8f145fa34d37 |
| hovercard-subject-tag | issue:3290970320 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/137396/issue_layout |
| twitter:image | https://opengraph.githubassets.com/d63a0bb493e1ee95a0ba5013ad1e20339434bfba6210f9842d4fda512db9f7ff/python/cpython/issues/137396 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d63a0bb493e1ee95a0ba5013ad1e20339434bfba6210f9842d4fda512db9f7ff/python/cpython/issues/137396 |
| og:image:alt | Bug report Bug description: for i in range(21): try: offset = nti(buf[pos:pos + 12]) numbytes = nti(buf[pos + 12:pos + 24]) except ValueError: break if offset and numbytes: structs.append((offset, ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | VbhvGupta |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width