René's URL Explorer Experiment


Title: Don't inline slow path functions in the interpreter loop · Issue #132336 · python/cpython · GitHub

Open Graph Title: Don't inline slow path functions in the interpreter loop · Issue #132336 · python/cpython

X Title: Don't inline slow path functions in the interpreter loop · Issue #132336 · python/cpython

Description: Feature or enhancement Proposal: I was looking at the IPA inlining dump as part of investigating the root cause of gh-132295 and noticed that we're inlining a number of slow path functions related to specialization, instrumentation, and ...

Open Graph Description: Feature or enhancement Proposal: I was looking at the IPA inlining dump as part of investigating the root cause of gh-132295 and noticed that we're inlining a number of slow path functions related ...

X Description: Feature or enhancement Proposal: I was looking at the IPA inlining dump as part of investigating the root cause of gh-132295 and noticed that we're inlining a number of slow path functions rela...

Opengraph URL: https://github.com/python/cpython/issues/132336

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Don't inline slow path functions in the interpreter loop","articleBody":"# Feature or enhancement\n\n### Proposal:\n\nI was looking at the IPA inlining dump as part of investigating the root cause of gh-132295 and noticed that we're inlining a number of slow path functions related to specialization, instrumentation, and error handling in the interpreter loop when performing LTO (full list [here](https://gist.github.com/mpage/763d253ca6b24a75fccd94bcf84b0247)):\n\n```\n_Py_Specialize_CallKw\n_Py_Specialize_CompareOp\n_Py_Specialize_ContainsOp\n_Py_Specialize_ForIter\n_Py_Specialize_LoadGlobal\n_Py_Specialize_LoadSuperAttr\n_Py_Specialize_Send\n_Py_Specialize_StoreAttr\n_Py_Specialize_StoreSubscr\n_Py_Specialize_ToBool\n_Py_Specialize_UnpackSequence\n_Py_call_instrumentation\n_Py_call_instrumentation_instruction\n_Py_call_instrumentation_line\nget_exception_handler\n```\n\nI suspect these are being inlined because we use unit tests for collecting PGO data. These should be executed relatively infrequently for \"normal\" Python code. We should mark them as `noinline`.\n\n### Has this already been discussed elsewhere?\n\nNo response given\n\n### Links to previous discussion of this feature:\n\n_No response_\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-132337\n* gh-132424\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/mpage","@type":"Person","name":"mpage"},"datePublished":"2025-04-09T23:26:16Z","url":"https://github.com/python/cpython/issues/132336"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8561d92c-e932-0965-59c5-9f8053264440
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9DE2:3B07B3:10F7937:1541816:6B0241C2
html-safe-nonce02acf972631a9ed1b80bdf9b2593e71c709f3ff1c594b688e6e7b9c17b950e2a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REUyOjNCMDdCMzoxMEY3OTM3OjE1NDE4MTY6NkIwMjQxQzIiLCJ2aXNpdG9yX2lkIjoiNjgyMDg1MDEzNTk0MjE4NTQxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac44641399f4db6eba1414ae0141cd009faed4a773b4002f5c297eecc3d259940d
hovercard-subject-tagissue:2984097947
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/132336/issue_layout
twitter:imagehttps://opengraph.githubassets.com/20525e3820d57c1c69307d7d4eb385f1a0bded5d3f7a6e72c37669be022a64a6/python/cpython/issues/132336
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/20525e3820d57c1c69307d7d4eb385f1a0bded5d3f7a6e72c37669be022a64a6/python/cpython/issues/132336
og:image:altFeature or enhancement Proposal: I was looking at the IPA inlining dump as part of investigating the root cause of gh-132295 and noticed that we're inlining a number of slow path functions related ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamempage
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/132336#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F132336
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F132336
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/132336
Reloadhttps://github.com/python/cpython/issues/132336
Reloadhttps://github.com/python/cpython/issues/132336
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/132336
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/132336
Don't inline slow path functions in the interpreter loophttps://github.com/python/cpython/issues/132336#top
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
performancePerformance or resource usagehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22performance%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com/mpage
mpagehttps://github.com/mpage
on Apr 9, 2025https://github.com/python/cpython/issues/132336#issue-2984097947
gh-132295https://github.com/python/cpython/pull/132295
herehttps://gist.github.com/mpage/763d253ca6b24a75fccd94bcf84b0247
gh-132336: Mark a few "slow path" functions used by the interpreter loop as noinline #132337https://github.com/python/cpython/pull/132337
gh-132336: Only mark slow path functions used by the interpreter loop as noinline in free-threaded builds #132424https://github.com/python/cpython/pull/132424
mpagehttps://github.com/mpage
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
on Apr 9, 2025https://github.com/python/cpython/issues/132336#event-17197178476
Yhg1shttps://github.com/Yhg1s
on Apr 10, 2025https://github.com/python/cpython/issues/132336#event-17202084742
gh-132336: Mark a few "slow path" functions used by the interpreter l…https://github.com/python/cpython/commit/619edb802e10741eff8eeab7dd279406bcd4b39c
gh-132336https://github.com/python/cpython/issues/132336
619edb8https://github.com/python/cpython/commit/619edb802e10741eff8eeab7dd279406bcd4b39c
https://github.com/thesamesam
thesamesamhttps://github.com/thesamesam
on Apr 10, 2025https://github.com/python/cpython/issues/132336#issuecomment-2792524848
https://github.com/Yhg1s
Yhg1shttps://github.com/Yhg1s
on Apr 10, 2025https://github.com/python/cpython/issues/132336#issuecomment-2792540230
https://github.com/thesamesam
thesamesamhttps://github.com/thesamesam
on Apr 10, 2025https://github.com/python/cpython/issues/132336#issuecomment-2792543936
https://github.com/markshannon
markshannonhttps://github.com/markshannon
on Apr 11, 2025https://github.com/python/cpython/issues/132336#issuecomment-2796076002
picnixzhttps://github.com/picnixz
performancePerformance or resource usagehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22performance%22
on Apr 11, 2025https://github.com/python/cpython/issues/132336#event-17224137273
https://github.com/mpage
mpagehttps://github.com/mpage
on Apr 11, 2025https://github.com/python/cpython/issues/132336#issuecomment-2797922549
matthiasgoergenshttps://github.com/matthiasgoergens
on Sep 27, 2026https://github.com/python/cpython/issues/132336#event-31950912480
Revert pythongh-132336 noinline attributes on specializer/instrumenta…https://github.com/matthiasgoergens/cpython/commit/bfc422f1d941c23dbe4230946328ff8cc5f042c8
pythongh-132336https://github.com/python/cpython/issues/132336
bfc422fhttps://github.com/matthiasgoergens/cpython/commit/bfc422f1d941c23dbe4230946328ff8cc5f042c8
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/132336
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/132336
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
performancePerformance or resource usagehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22performance%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.