René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Handle error scenarios of HACL* functions","articleBody":"This is a follow-up on https://github.com/python/cpython/pull/130960#issuecomment-2726897435:\n\u003eFor all hash algorithms (NEW with this PR):\nmalloc, malloc_with_params_and_key, malloc_with_key: may return NULL (out of memory)\ncopy: may return NULL (out of memory)\n\nFull list from https://github.com/python/cpython/pull/130960#issuecomment-2715631704\n\u003e For Hacl_Streaming_HMAC:\n\u003e \n\u003e * malloc may return OutOfMemory, InvalidAlgorithm (e.g.  requesting Blake2b_256 on an ARM machine), or Success\n\u003e * reset may return InvalidLength (if trying to reset the state with a key of different length, this is not supported), or Success\n\u003e * update: MaximumLengthExceeded or Success\n\u003e * digest: OutOfMemory or Success\n\u003e * copy: may return NULL (indicates out of memory)\n\u003e \n\u003e For all hash algorithms (_NEW with this PR_):\n\u003e \n\u003e * malloc, malloc_with_params_and_key, malloc_with_key: may return NULL (out of memory)\n\u003e * copy: may return NULL (out of memory)\n\u003e \n\u003e For SHA3/Keccak only:\n\u003e \n\u003e * digest may return InvalidAlgorithm (if the algorithm is shake)\n\u003e * squeeze may return InvalidAlgorithm (if the algorithm is not shake)\n\u003e \n\u003e I think all of these can be handled as a followup, I just thought it would be good to have it in writing here so that you can decide which of these are worth checking for. The reason I brought up other hash algorithms is that, since you requested (or maybe @picnixz ?) proper out of memory handling in HACL*, we now may return NULL for other algorithms (like hash algorithms), meaning that this PR will introduce new possibly-NULL return values as a side-effect of updating the vendored copy of HACL*.\n\u003e \n\u003e For the record, Python ignores MaximumLengthExceeded on the basis that this cannot happen in practice.\n\n\n\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-131324\n* gh-135291\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/chris-eibl","@type":"Person","name":"chris-eibl"},"datePublished":"2025-03-16T07:03:54.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/131316/cpython/issues/131316"}