René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Refactor tests for HMAC","articleBody":"The tests for HMAC are organized in such a way that makes the adoption of HACL* HMAC harder. More precisely, it'll be a bit harder to test the OpenSSL *and* the HACL* implementation of HMAC (for instance, some tests may or may not work with HACL* as they only support a subset of the hash functions supported by OpenSSL).\n\nI am suggesting a way to make the test interface more generic using mixin classes. For instance, we have multiple ways of creating a HMAC object. It can be through `hmac.HMAC` or through `hmac.new` or through `_hashlib.hmac_new`. While `hmac.new` and `hmac.HMAC` are identical, `_hashlib.hmac_new` is different in the sense that the signature is different as well (and that the objects being returned are also different; they are not instances of `hmac.HMAC` but instances of `_hashlib.HMAC`, though they implement the same interface).\n\nNow, once we add HACL* implementation, the interface will be similar to the Python implementation of HMAC and thus we need to test them both. Currently, it's hard to switch from the Python module implementation to the C implementation.\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-130150\n* gh-130788\n* gh-131318\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/picnixz","@type":"Person","name":"picnixz"},"datePublished":"2025-02-15T10:15:42.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/130149/cpython/issues/130149"}