René's URL Explorer Experiment


Title: Race between grow_thread_array and _Py_qsbr_reserve under free threading · Issue #129732 · python/cpython · GitHub

Open Graph Title: Race between grow_thread_array and _Py_qsbr_reserve under free threading · Issue #129732 · python/cpython

X Title: Race between grow_thread_array and _Py_qsbr_reserve under free threading · Issue #129732 · python/cpython

Description: Bug report Bug description: I don't have a succinct reproducer for this bug yet, but I saw the following race in JAX CI: jax-ml/jax#26359 WARNING: ThreadSanitizer: data race (pid=208275) Write of size 8 at 0x555555d43b60 by thread T121: ...

Open Graph Description: Bug report Bug description: I don't have a succinct reproducer for this bug yet, but I saw the following race in JAX CI: jax-ml/jax#26359 WARNING: ThreadSanitizer: data race (pid=208275) Write of s...

X Description: Bug report Bug description: I don't have a succinct reproducer for this bug yet, but I saw the following race in JAX CI: jax-ml/jax#26359 WARNING: ThreadSanitizer: data race (pid=208275) Write ...

Opengraph URL: https://github.com/python/cpython/issues/129732

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Race between grow_thread_array and _Py_qsbr_reserve under free threading","articleBody":"# Bug report\n\n### Bug description:\n\nI don't have a succinct reproducer for this bug yet, but I saw the following race in JAX CI:\n\nhttps://github.com/jax-ml/jax/issues/26359\n\n```\nWARNING: ThreadSanitizer: data race (pid=208275)\n  Write of size 8 at 0x555555d43b60 by thread T121:\n    #0 grow_thread_array /__w/jax/jax/cpython/Python/qsbr.c:101:19 (python3.13+0x4a3905) (BuildId: 8f8869b5f3143bd14dda26aa2bf37336b4902370)\n    #1 _Py_qsbr_reserve /__w/jax/jax/cpython/Python/qsbr.c:203:13 (python3.13+0x4a3905)\n    #2 new_threadstate /__w/jax/jax/cpython/Python/pystate.c:1569:27 (python3.13+0x497df2) (BuildId: 8f8869b5f3143bd14dda26aa2bf37336b4902370)\n    #3 PyGILState_Ensure /__w/jax/jax/cpython/Python/pystate.c:2766:16 (python3.13+0x49af78) (BuildId: 8f8869b5f3143bd14dda26aa2bf37336b4902370)\n    #4 nanobind::gil_scoped_acquire::gil_scoped_acquire() /proc/self/cwd/external/nanobind/include/nanobind/nb_misc.h:15:43 (xla_extension.so+0xa4fe551) (BuildId: 32eac14928efa68545d22a6013f16aa63a686fef)\n    #5 xla::CpuCallback::PrepareAndCall(void*, void**) /proc/self/cwd/external/xla/xla/python/callback.cc:67:26 (xla_extension.so+0xa4fe551)\n    #6 xla::XlaPythonCpuCallback(void*, void**, XlaCustomCallStatus_*) /proc/self/cwd/external/xla/xla/python/callback.cc:177:22 (xla_extension.so+0xa500c9a) (BuildId: 32eac14928efa68545d22a6013f16aa63a686fef)\n...\n\n  Previous read of size 8 at 0x555555d43b60 by thread T124:\n    #0 _Py_qsbr_reserve /__w/jax/jax/cpython/Python/qsbr.c:216:47 (python3.13+0x4a3ad7) (BuildId: 8f8869b5f3143bd14dda26aa2bf37336b4902370)\n    #1 new_threadstate /__w/jax/jax/cpython/Python/pystate.c:1569:27 (python3.13+0x497df2) (BuildId: 8f8869b5f3143bd14dda26aa2bf37336b4902370)\n    #2 PyGILState_Ensure /__w/jax/jax/cpython/Python/pystate.c:2766:16 (python3.13+0x49af78) (BuildId: 8f8869b5f3143bd14dda26aa2bf37336b4902370)\n    #3 nanobind::gil_scoped_acquire::gil_scoped_acquire() /proc/self/cwd/external/nanobind/include/nanobind/nb_misc.h:15:43 (xla_extension.so+0xa4fe551) (BuildId: 32eac14928efa68545d22a6013f16aa63a686fef)\n    #4 xla::CpuCallback::PrepareAndCall(void*, void**) /proc/self/cwd/external/xla/xla/python/callback.cc:67:26 (xla_extension.so+0xa4fe551)\n    #5 xla::XlaPythonCpuCallback(void*, void**, XlaCustomCallStatus_*) /proc/self/cwd/external/xla/xla/python/callback.cc:177:22 (xla_extension.so+0xa500c9a) (BuildId: 32eac14928efa68545d22a6013f16aa63a686fef)\n...\n```\n\nI think what's happening here is that two threads that were *not* created by Python are calling `PyGILState_Ensure` concurrently, so they can call into CPython APIs.\n\nThis appears to be an unlocked access on `shared->array` and it would probably be sufficient to move that read under the mutex in `_Py_qsbr_reserve`.\n\n### CPython versions tested on:\n\n3.13\n\n### Operating systems tested on:\n\nLinux\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-129738\n* gh-129747\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/hawkinsp","@type":"Person","name":"hawkinsp"},"datePublished":"2025-02-06T16:13:40Z","url":"https://github.com/python/cpython/issues/129732"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:34025349-cd61-cfa1-c07a-22325a05b114
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id88A4:88BC0:33A796:4059D2:6B023A99
html-safe-noncefaae346edfb9ff19d63c4ffb490d42cbd0cc3aa7ceb8abe6022f816aa2072195
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OEE0Ojg4QkMwOjMzQTc5Njo0MDU5RDI6NkIwMjNBOTkiLCJ2aXNpdG9yX2lkIjoiMzc0NzI3NDkzNjUyMDE2MTk0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9067767ba4cbbf850f90c4b2a0b3df52256c42bec4372ee95d067389a6a04ed0
hovercard-subject-tagissue:2835970715
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/129732/issue_layout
twitter:imagehttps://opengraph.githubassets.com/14fd8bfee1096b00a5cace37f94ffb9e17a266b147f4f47eb7a8de002be33b0f/python/cpython/issues/129732
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/14fd8bfee1096b00a5cace37f94ffb9e17a266b147f4f47eb7a8de002be33b0f/python/cpython/issues/129732
og:image:altBug report Bug description: I don't have a succinct reproducer for this bug yet, but I saw the following race in JAX CI: jax-ml/jax#26359 WARNING: ThreadSanitizer: data race (pid=208275) Write of s...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehawkinsp
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/129732#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F129732
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F129732
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/129732
Reloadhttps://github.com/python/cpython/issues/129732
Reloadhttps://github.com/python/cpython/issues/129732
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/129732
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/129732
#129738https://github.com/python/cpython/pull/129738
Race between grow_thread_array and _Py_qsbr_reserve under free threadinghttps://github.com/python/cpython/issues/129732#top
#129738https://github.com/python/cpython/pull/129738
topic-free-threadinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-free-threading%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/hawkinsp
hawkinsphttps://github.com/hawkinsp
on Feb 6, 2025https://github.com/python/cpython/issues/129732#issue-2835970715
jax-ml/jax#26359https://github.com/jax-ml/jax/issues/26359
gh-129732: Fix race in on shared->array in qsbr code under free-threa… #129738https://github.com/python/cpython/pull/129738
[3.13] gh-129732: Fix race on shared->array in qsbr code under free-threading (gh-129738) #129747https://github.com/python/cpython/pull/129747
hawkinsphttps://github.com/hawkinsp
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
on Feb 6, 2025https://github.com/python/cpython/issues/129732#event-16212525956
hawkinsphttps://github.com/hawkinsp
on Feb 6, 2025https://github.com/python/cpython/issues/129732#event-16213457700
Fix race in on shared->array in qsbr code under free-threading.https://github.com/hawkinsp/cpython/commit/19a72e1097c26e4b993dc701736ef78cb53e6707
19a72e1https://github.com/hawkinsp/cpython/commit/19a72e1097c26e4b993dc701736ef78cb53e6707
pythongh-129732: Fix race in on shared->array in qsbr code under free…https://github.com/hawkinsp/cpython/commit/d273c8ee13b630dd4a28344874ea78c6d6b7f34a
pythongh-129732https://github.com/python/cpython/issues/129732
d273c8ehttps://github.com/hawkinsp/cpython/commit/d273c8ee13b630dd4a28344874ea78c6d6b7f34a
colesburyhttps://github.com/colesbury
topic-free-threadinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-free-threading%22
on Feb 6, 2025https://github.com/python/cpython/issues/129732#event-16213483382
hawkinsphttps://github.com/hawkinsp
on Feb 6, 2025https://github.com/python/cpython/issues/129732#event-16213514120
pythongh-129732: Fix race in on shared->array in qsbr code under free…https://github.com/hawkinsp/cpython/commit/0d2a58d5877246d30a35fa7c51515be49d91c6de
pythongh-129732https://github.com/python/cpython/issues/129732
0d2a58dhttps://github.com/hawkinsp/cpython/commit/0d2a58d5877246d30a35fa7c51515be49d91c6de
pythongh-129732: Fix race in on shared->array in qsbr code under free…https://github.com/hawkinsp/cpython/commit/c15a0ba540d5a180f78bc830bfd882696154b664
pythongh-129732https://github.com/python/cpython/issues/129732
c15a0bahttps://github.com/hawkinsp/cpython/commit/c15a0ba540d5a180f78bc830bfd882696154b664
colesburyhttps://github.com/colesbury
on Feb 6, 2025https://github.com/python/cpython/issues/129732#event-16214628781
gh-129732: Fix race on `shared->array` in qsbr code under free-thread…https://github.com/python/cpython/commit/b4ff8b22b3066b814c3758f87eaddfa923e657ed
gh-129732https://github.com/python/cpython/issues/129732
b4ff8b2https://github.com/python/cpython/commit/b4ff8b22b3066b814c3758f87eaddfa923e657ed
colesburyhttps://github.com/colesbury
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#129738https://github.com/python/cpython/pull/129738
on Feb 6, 2025https://github.com/python/cpython/issues/129732#event-16214628830
colesburyhttps://github.com/colesbury
on Feb 6, 2025https://github.com/python/cpython/issues/129732#event-16214654190
[3.13] pythongh-129732: Fix race on `shared->array` in qsbr code unde…https://github.com/colesbury/cpython/commit/61d6e0c130776a0f89bfbb3a5292d0467fbc3d39
pythongh-129732https://github.com/python/cpython/issues/129732
61d6e0chttps://github.com/colesbury/cpython/commit/61d6e0c130776a0f89bfbb3a5292d0467fbc3d39
[3.13] gh-129732: Fix race on `shared->array` in qsbr code under free…https://github.com/python/cpython/commit/f7cc8623457ed0f79bddd32dd680303584684641
gh-129732https://github.com/python/cpython/issues/129732
f7cc862https://github.com/python/cpython/commit/f7cc8623457ed0f79bddd32dd680303584684641
srinivasreddyhttps://github.com/srinivasreddy
on Feb 7, 2025https://github.com/python/cpython/issues/129732#event-16221152750
pythongh-129732: Fix race on `shared->array` in qsbr code under free-…https://github.com/srinivasreddy/cpython/commit/8b80c416a17ab0590ed49808a7ab58957a0efd99
pythongh-129732https://github.com/python/cpython/issues/129732
8b80c41https://github.com/srinivasreddy/cpython/commit/8b80c416a17ab0590ed49808a7ab58957a0efd99
cmaloneyhttps://github.com/cmaloney
on Feb 8, 2025https://github.com/python/cpython/issues/129732#event-16236719277
pythongh-129732: Fix race on `shared->array` in qsbr code under free-…https://github.com/cmaloney/cpython/commit/696d0c3e565e3663a665bc046b0fbaa9fa22fb45
pythongh-129732https://github.com/python/cpython/issues/129732
696d0c3https://github.com/cmaloney/cpython/commit/696d0c3e565e3663a665bc046b0fbaa9fa22fb45
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/129732
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/129732
topic-free-threadinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-free-threading%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.