René's URL Explorer Experiment


Title: Inconsistent name mangling in `TypedDict` in function and class forms · Issue #129567 · python/cpython · GitHub

Open Graph Title: Inconsistent name mangling in `TypedDict` in function and class forms · Issue #129567 · python/cpython

X Title: Inconsistent name mangling in `TypedDict` in function and class forms · Issue #129567 · python/cpython

Description: Bug report Let's say that you have a dict like {"__key": 1} and you want to type it. You can write: >>> import typing >>> class A(typing.TypedDict): ... __key: int >>> A.__mutable_keys__ frozenset({'_A__key'}) and: >>> B = typing.TypedDi...

Open Graph Description: Bug report Let's say that you have a dict like {"__key": 1} and you want to type it. You can write: >>> import typing >>> class A(typing.TypedDict): ... __key: int >>> A.__mutable_keys__ frozenset(...

X Description: Bug report Let's say that you have a dict like {"__key": 1} and you want to type it. You can write: >>> import typing >>> class A(typing.TypedDict): ... __key: int &...

Opengraph URL: https://github.com/python/cpython/issues/129567

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Inconsistent name mangling in `TypedDict` in function and class forms","articleBody":"# Bug report\n\nLet's say that you have a dict like `{\"__key\": 1}` and you want to type it.\n\nYou can write:\n\n```python\n>>> import typing\n>>> class A(typing.TypedDict):\n...     __key: int\n\n>>> A.__mutable_keys__\nfrozenset({'_A__key'})\n```\n\nand:\n\n```python\n>>> B = typing.TypedDict(\"B\", [(\"__key\", int)])\n>>> B.__mutable_keys__\nfrozenset({'__key'})\n```\n\nNote that `A` mangles `__key` as a regular name. While `B` does not.\n\nI guess that it is expected, but!\nDocs (https://docs.python.org/3/library/typing.html#typing.TypedDict) does not say anything about this behavior. We only mention that functional form should be used for invalid identifiers. But, `__key` is a valid indentifier.\nWe don't have explicit tests for this either.\nAnd Typing Spec does not mention this as well: https://typing.readthedocs.io/en/latest/spec/typeddict.html\n\n\nSo, what we can do:\n- Do not mangle names in this case (hard and problematic: it can break existing stuff)\n- Document and test current behavior (my vote)\n\nPlease, share your thoughts on this. And I willing to send a PR with the fix.\n\n\u003c!-- gh-linked-prs -->\n### Linked PRs\n* gh-130233\n* gh-130841\n* gh-130842\n\u003c!-- /gh-linked-prs -->\n","author":{"url":"https://github.com/sobolevn","@type":"Person","name":"sobolevn"},"datePublished":"2025-02-02T07:25:27Z","url":"https://github.com/python/cpython/issues/129567"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2a7440dd-0c53-9292-782a-585397585c9d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB310:3F9D33:288A71A:3729DE4:6B004793
html-safe-nonce6fd4d058b3c6abb1d201821f291c0800d5461a0afad4904a0e04bdfad6f58e6f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzEwOjNGOUQzMzoyODhBNzFBOjM3MjlERTQ6NkIwMDQ3OTMiLCJ2aXNpdG9yX2lkIjoiNDg2MDMxNTI4NjA3NjY3MTg5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbd07fbb53eec89a86986cddd3d4679ee7182a6c843ead71cbb11fc8589cc967c
hovercard-subject-tagissue:2825656643
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/129567/issue_layout
twitter:imagehttps://opengraph.githubassets.com/a012bbe38653732505fa1c134e0c0afe39e4dfe3f843f1657bb3e284af476a9f/python/cpython/issues/129567
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a012bbe38653732505fa1c134e0c0afe39e4dfe3f843f1657bb3e284af476a9f/python/cpython/issues/129567
og:image:altBug report Let's say that you have a dict like {"__key": 1} and you want to type it. You can write: >>> import typing >>> class A(typing.TypedDict): ... __key: int >>> A.__mutable_keys__ frozenset(...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesobolevn
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/cpython/issues/129567#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F129567
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F129567
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/129567
Reloadhttps://github.com/python/cpython/issues/129567
Reloadhttps://github.com/python/cpython/issues/129567
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/129567
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/129567
Inconsistent name mangling in TypedDict in function and class formshttps://github.com/python/cpython/issues/129567#top
https://github.com/sobolevn
topic-typinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-typing%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Feb 2, 2025https://github.com/python/cpython/issues/129567#issue-2825656643
https://docs.python.org/3/library/typing.html#typing.TypedDicthttps://docs.python.org/3/library/typing.html#typing.TypedDict
https://typing.readthedocs.io/en/latest/spec/typeddict.htmlhttps://typing.readthedocs.io/en/latest/spec/typeddict.html
gh-129567: Add a note to typing.TypedDict docs about name mangling #130233https://github.com/python/cpython/pull/130233
[3.13] gh-129567: Add a note to typing.TypedDict docs about name mangling (GH-130233) #130841https://github.com/python/cpython/pull/130841
[3.12] gh-129567: Add a note to typing.TypedDict docs about name mangling (GH-130233) #130842https://github.com/python/cpython/pull/130842
sobolevnhttps://github.com/sobolevn
topic-typinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-typing%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
on Feb 2, 2025https://github.com/python/cpython/issues/129567#event-16152069471
sobolevnhttps://github.com/sobolevn
on Feb 2, 2025https://github.com/python/cpython/issues/129567#event-16152069477
https://github.com/picnixz
picnixzhttps://github.com/picnixz
on Feb 2, 2025https://github.com/python/cpython/issues/129567#issuecomment-2629406593
sobolevnhttps://github.com/sobolevn
on Feb 16, 2025https://github.com/python/cpython/issues/129567#event-16325313386
Fix `IntrospectionQuery` type definitionhttps://github.com/sobolevn/graphql-core/commit/358d0e8af0d0fd01aad575cdff4b2321faf907c3
358d0e8https://github.com/sobolevn/graphql-core/commit/358d0e8af0d0fd01aad575cdff4b2321faf907c3
Refactor `_StoreCallSig` to inline formhttps://github.com/sobolevn/hydra-zen/commit/b8b9cba64a57ab83ee5eb034b095326917635e5a
b8b9cbahttps://github.com/sobolevn/hydra-zen/commit/b8b9cba64a57ab83ee5eb034b095326917635e5a
pythongh-129567: Add a note to `typing.TypedDict` docs about name man…https://github.com/sobolevn/cpython/commit/bd8f1c5752b0c653558743e324ca318cab3a097c
pythongh-129567https://github.com/python/cpython/issues/129567
bd8f1c5https://github.com/sobolevn/cpython/commit/bd8f1c5752b0c653558743e324ca318cab3a097c
sobolevnhttps://github.com/sobolevn
on Mar 4, 2025https://github.com/python/cpython/issues/129567#event-16563668684
gh-129567: Add a note to `typing.TypedDict` docs about name mangling (#…https://github.com/python/cpython/commit/63ffb406bb000a42b0dbddcfc01cb98a12f8f76a
gh-129567https://github.com/python/cpython/issues/129567
#…https://github.com/python/cpython/pull/130233
63ffb40https://github.com/python/cpython/commit/63ffb406bb000a42b0dbddcfc01cb98a12f8f76a
miss-islingtonhttps://github.com/miss-islington
on Mar 4, 2025https://github.com/python/cpython/issues/129567#event-16563671825
pythongh-129567: Add a note to `typing.TypedDict` docs about name man…https://github.com/miss-islington/cpython/commit/ce8d276336f305f5a0ae7e4787535dfb360070db
pythongh-129567https://github.com/python/cpython/issues/129567
ce8d276https://github.com/miss-islington/cpython/commit/ce8d276336f305f5a0ae7e4787535dfb360070db
sobolevnhttps://github.com/sobolevn
on Mar 4, 2025https://github.com/python/cpython/issues/129567#event-16563828158
[3.13] gh-129567: Add a note to `typing.TypedDict` docs about name ma…https://github.com/python/cpython/commit/418021e22911dbaf54dacdec9e315c5778185074
gh-129567https://github.com/python/cpython/issues/129567
418021ehttps://github.com/python/cpython/commit/418021e22911dbaf54dacdec9e315c5778185074
[3.12] pythongh-129567: Add a note to typing.TypedDict docs about nam…https://github.com/sobolevn/cpython/commit/1891b30707f1906c4b57295cf6cda5d51217eac9
pythongh-129567https://github.com/python/cpython/issues/129567
1891b30https://github.com/sobolevn/cpython/commit/1891b30707f1906c4b57295cf6cda5d51217eac9
[3.12] gh-129567: Add a note to typing.TypedDict docs about name mang…https://github.com/python/cpython/commit/50270fc9803283d9a7d12731e6d84012f3ef7b32
gh-129567https://github.com/python/cpython/issues/129567
50270fchttps://github.com/python/cpython/commit/50270fc9803283d9a7d12731e6d84012f3ef7b32
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
on Mar 21, 2025https://github.com/python/cpython/issues/129567#issuecomment-2742885458
ZeroIntensityhttps://github.com/ZeroIntensity
completedhttps://github.com/python/cpython/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Mar 21, 2025https://github.com/python/cpython/issues/129567#event-16925594954
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/cpython/issues/129567
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/cpython/issues/129567
sobolevnhttps://github.com/sobolevn
topic-typinghttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-typing%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.