René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Try to avoid invoking a new process to determine the Windows version in the platform module","articleBody":"# Feature or enhancement\n\n### Proposal:\n\nIn Lib/platform.py, there's a code aimed to determine the Windows version python runs in.\n\n```python\n    for cmd in ('ver', 'command /c ver', 'cmd /c ver'):\n        try:\n            info = subprocess.check_output(cmd,\n                                           stdin=subprocess.DEVNULL,\n                                           stderr=subprocess.DEVNULL,\n                                           text=True,\n                                           encoding=\"locale\",\n                                           shell=True)\n```\n\nAs much as I understand, one shouldn't invoke whole new process just to question what OS version he runs at.\n\nso just before invoking cmd.exe, we will try to question winapi directly.\n```python\n# Load ntdll.dll and call RtlGetVersion\n    ntdll = ctypes.WinDLL(\"ntdll\")\n    rtl_get_version = ntdll.RtlGetVersion\n    rtl_get_version(ctypes.byref(os_version))\n```\n\n### Has this already been discussed elsewhere?\n\nNo response given\n\n### Links to previous discussion of this feature:\n\n_No response_\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-129295\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/tomergert","@type":"Person","name":"tomergert"},"datePublished":"2025-01-25T12:03:59.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/129294/cpython/issues/129294"}