Title: Avoid temporary allocation in dec_as_long() · Issue #129275 · python/cpython · GitHub
Open Graph Title: Avoid temporary allocation in dec_as_long() · Issue #129275 · python/cpython
X Title: Avoid temporary allocation in dec_as_long() · Issue #129275 · python/cpython
Description: Feature or enhancement Proposal: After #127925, new code in the decimal module (using the PEP 757) do temporary allocation with mpdecimal's memory functions (in mpd_qexport_u32/16()), just as before: cpython/Modules/_decimal/_decimal.c L...
Open Graph Description: Feature or enhancement Proposal: After #127925, new code in the decimal module (using the PEP 757) do temporary allocation with mpdecimal's memory functions (in mpd_qexport_u32/16()), just as befor...
X Description: Feature or enhancement Proposal: After #127925, new code in the decimal module (using the PEP 757) do temporary allocation with mpdecimal's memory functions (in mpd_qexport_u32/16()), just as b...
Opengraph URL: https://github.com/python/cpython/issues/129275
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Avoid temporary allocation in dec_as_long()","articleBody":"# Feature or enhancement\n\n### Proposal:\n\nAfter #127925, new code in the decimal module (using the [PEP 757](https://peps.python.org/pep-0757/)) do temporary allocation with mpdecimal's memory functions (in mpd_qexport_u32/16()), just as before:\nhttps://github.com/python/cpython/blob/f10b7b29cb2a3cb67d1da114ef9a27be7e62dddd/Modules/_decimal/_decimal.c#L3691-L3706\n\nAccording to [the documentation](https://www.bytereef.org/mpdecimal/doc/libmpdec/various.html#exporting), we can prepare array of digits, which size could be estimated by mpd_sizeinbase(). Given this, the mpd_qexport_u32/16() shouldn't do any resize for this array. [Here is Stefan comment](https://github.com/python/cpython/pull/127925#issuecomment-2560458812) on how safe this approach is:\n\u003e mpd_sizeinbase() uses log10() from math.h for performance reasons. If log10() is IEEE compliant, the result should be sufficiently large. Resizing is for guarding against broken log10() implementations.\n\u003e\n\u003e The current code in _decimal.c sets the libmpdec allocation functions to PyMem_Malloc() etc. So if longobject uses PyMem_Free() it is safe even when resizing occurs.\n\u003e\n\u003e If the new API allows for allocators other that PyMem_Malloc(), it will rely on the IEEE compliance of log10().\n\u003e\n\u003e Stefan Krah\n\nWe can expect slight performance boost for small (2-3 digits) integers.\n\nThe thread on mpdecimal-discuss maillist:\nhttps://lists.sr.ht/~mpdecimal/mpdecimal-discuss/%3CZ2kIike42Wl0_YKd@skirpichev.msk.ru%3E\n\n\n### Has this already been discussed elsewhere?\n\nThis is a minor feature, which does not need previous discussion elsewhere\n\n### Links to previous discussion of this feature:\n\n_No response_\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-129630\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/skirpichev","@type":"Person","name":"skirpichev"},"datePublished":"2025-01-25T02:50:31.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":8},"url":"https://github.com/129275/cpython/issues/129275"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:1d74781b-2d2d-6e5a-651d-bfc28e6e259b |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8D0E:3E485E:10D06:15607:696AF7DF |
| html-safe-nonce | 6a7b32947ca4af09e3b4d8fea6197aa2af1dd78a4e4b538450c6a26abbfe180a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDBFOjNFNDg1RToxMEQwNjoxNTYwNzo2OTZBRjdERiIsInZpc2l0b3JfaWQiOiI3MjEyNDkwNzYxNzc1NTQ0Mjg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 06d947fd286fd3206d57f14811bbcb336fc07e45784da40c0ee51536a3dd96f1 |
| hovercard-subject-tag | issue:2810712958 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/129275/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9192c1ed9f8eb19475944a646c84df5a489ef1a649d58b4b3b2c9f848a540919/python/cpython/issues/129275 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9192c1ed9f8eb19475944a646c84df5a489ef1a649d58b4b3b2c9f848a540919/python/cpython/issues/129275 |
| og:image:alt | Feature or enhancement Proposal: After #127925, new code in the decimal module (using the PEP 757) do temporary allocation with mpdecimal's memory functions (in mpd_qexport_u32/16()), just as befor... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | skirpichev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width