René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Refactor codecs error handlers to use `_PyUnicodeError_GetParams` and extract complex logic into separate functions","articleBody":"# Feature or enhancement\n\n### Proposal:\n\nI want to refactor the different codecs handlers in `Python/codecs.c` to use `_PyUnicodeError_GetParams`. Some codecs handlers will be refactored as part of #126004 but some others are not subject to issues (namely, the `ignore`, `namereplace`, `surrogateescape`, and `surrogatepass` handlers do not suffer from crashes, or at least I wasn't able to make them crash easily). \n\nIn addition, I also plan to split the handlers into functions instead of 2 or 3 big blocks of code handling a specific exception. For that reason, I will introduce the following helper macros:\n\n```c\n#define _PyIsUnicodeEncodeError(EXC)    \\\n    PyObject_TypeCheck(EXC, (PyTypeObject *)PyExc_UnicodeEncodeError)\n#define _PyIsUnicodeDecodeError(EXC)    \\\n    PyObject_TypeCheck(EXC, (PyTypeObject *)PyExc_UnicodeDecodeError)\n#define _PyIsUnicodeTranslateError(EXC) \\\n    PyObject_TypeCheck(EXC, (PyTypeObject *)PyExc_UnicodeTranslateError)\n```\n\nFor handlers that need to be fixed, I will first fix them in-place (no refactorization). Afterwards, I will refactor them and extract the relevant part of the code into functions. That way, the diff will be easier to follow (~~I've observed that it's much harder to read the diff where I did both so I will revert that part in the existing PRs~~; EDIT: actually there is no PR doing both fixes and split...).\n\nI'm creating this issue to track the progression of the refactorization if no issue occurs. \n\ncc @vstinner @encukou \n\n### Has this already been discussed elsewhere?\n\nThis is a minor feature, which does not need previous discussion elsewhere\n\n### Links to previous discussion of this feature:\n\n_No response_\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-129174\n* gh-129135\n* gh-129134\n* gh-129175\n* gh-129893\n* gh-129894\n* gh-129895\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/picnixz","@type":"Person","name":"picnixz"},"datePublished":"2025-01-22T11:12:16.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/129173/cpython/issues/129173"}