René's URL Explorer Experiment


Title: Update FileIO comments, documentation to match implementation · Issue #129011 · python/cpython · GitHub

Open Graph Title: Update FileIO comments, documentation to match implementation · Issue #129011 · python/cpython

X Title: Update FileIO comments, documentation to match implementation · Issue #129011 · python/cpython

Description: Documentation Discuss thread: https://discuss.python.org/t/change-open-write-to-guarantee-all-bytes-will-be-written-or-an-exception-will-be-thrown/71082 FileIO behaves differently than its code comments around read and readall. Update th...

Open Graph Description: Documentation Discuss thread: https://discuss.python.org/t/change-open-write-to-guarantee-all-bytes-will-be-written-or-an-exception-will-be-thrown/71082 FileIO behaves differently than its code com...

X Description: Documentation Discuss thread: https://discuss.python.org/t/change-open-write-to-guarantee-all-bytes-will-be-written-or-an-exception-will-be-thrown/71082 FileIO behaves differently than its code com...

Opengraph URL: https://github.com/python/cpython/issues/129011

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Update FileIO comments, documentation to match implementation","articleBody":"# Documentation\n\nDiscuss thread: https://discuss.python.org/t/change-open-write-to-guarantee-all-bytes-will-be-written-or-an-exception-will-be-thrown/71082\n\n1. FileIO behaves differently than its code comments around `read` and `readall`. Update the code comments to match current behavior\n   - [PEP 475](https://peps.python.org/pep-0475/), reads are retried in some cases\n   - `.readall()` makes multiple system calls by design\n3. Add documentation to [`open()` builtin](https://docs.python.org/3.14/library/functions.html#open) that `buffering=0`, which currently just says \"disables buffering\") changes how `.write()` behaves and may result in data loss as a result of a partial write (ex. gh-126606).\n   - `TextIO` and `BufferedIO` (which are gotten via commonly used `open('README.rst')`, `open('README.rst', 'rb')`) retry partial writes providing a user a guarantee either all bytes will be written or an exception will be thrown.\n   - `FileIO` is \"Raw I/O\" and by [PEP-3116](https://peps.python.org/pep-3116/#raw-i-o) design, as documented, and currently implemented does not retry partial writes. \n   - Most the time, `buffering=0` currently speeds up writing a file, but it can also result in corrupted files, ex. gh-126606 from using FileIO directly\n   - I would like to try and change the behavior of `buffering=0` to use BufferedIO but with a 0 sized buffer, and that is on my roadmap but will be a while (people use the flag for a reason / get benefit!). This will mean `open()` always returns an object which implements \"Write all or throw exception\" behavior.\n   - Add warning / document existing behavior on `open()` in the meantime.\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-129012\n* gh-135328\n* gh-150957\n* gh-150958\n* gh-150959\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/cmaloney","@type":"Person","name":"cmaloney"},"datePublished":"2025-01-19T01:19:28.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/129011/cpython/issues/129011"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:a1a84ed6-67b1-b594-f0f2-48fb823db1d4
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC19A:3AC145:3706:4976:6A521B83
html-safe-nonce7216cad7652d8d34caee08c9ab8fd97f329c39ae58f002dba82ce945c34b9e70
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTlBOjNBQzE0NTozNzA2OjQ5NzY6NkE1MjFCODMiLCJ2aXNpdG9yX2lkIjoiNzY5MDc0ODM0MTAwMTUyNjE0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6cce81c28b72fe385ebfb276dc09c0b21f935e3513579644e23dc3fa26823aea
hovercard-subject-tagissue:2797330399
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/129011/issue_layout
twitter:imagehttps://opengraph.githubassets.com/497c2a35d4968e1bc04fce15443e87dc962bb4d23b5476388a6124800dc0285c/python/cpython/issues/129011
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/497c2a35d4968e1bc04fce15443e87dc962bb4d23b5476388a6124800dc0285c/python/cpython/issues/129011
og:image:altDocumentation Discuss thread: https://discuss.python.org/t/change-open-write-to-guarantee-all-bytes-will-be-written-or-an-exception-will-be-thrown/71082 FileIO behaves differently than its code com...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecmaloney
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/129011#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F129011
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F129011
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/129011
Reloadhttps://github.com/python/cpython/issues/129011
Reloadhttps://github.com/python/cpython/issues/129011
Please reload this pagehttps://github.com/python/cpython/issues/129011
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/129011
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Update FileIO comments, documentation to match implementationhttps://github.com/python/cpython/issues/129011#top
docsDocumentation in the Doc dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22docs%22
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
on Jan 19, 2025https://github.com/python/cpython/issues/129011#issue-2797330399
https://discuss.python.org/t/change-open-write-to-guarantee-all-bytes-will-be-written-or-an-exception-will-be-thrown/71082https://discuss.python.org/t/change-open-write-to-guarantee-all-bytes-will-be-written-or-an-exception-will-be-thrown/71082
PEP 475https://peps.python.org/pep-0475/
open() builtinhttps://docs.python.org/3.14/library/functions.html#open
Corrupt .pyc files stay on disk after failed writes #126606https://github.com/python/cpython/issues/126606
PEP-3116https://peps.python.org/pep-3116/#raw-i-o
Corrupt .pyc files stay on disk after failed writes #126606https://github.com/python/cpython/issues/126606
gh-129011: Update comments in FileIO to match current code #129012https://github.com/python/cpython/pull/129012
gh-129011: Update docs for Raw I/O read, readinto, and write #135328https://github.com/python/cpython/pull/135328
[3.15] gh-129011: Update docs for Raw I/O read, readinto, and write (GH-135328) #150957https://github.com/python/cpython/pull/150957
[3.14] gh-129011: Update docs for Raw I/O read, readinto, and write (GH-135328) #150958https://github.com/python/cpython/pull/150958
[3.13] gh-129011: Update docs for Raw I/O read, readinto, and write (GH-135328) #150959https://github.com/python/cpython/pull/150959
docsDocumentation in the Doc dirhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22docs%22
docs issueshttps://github.com/orgs/python/projects/52
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.